Re: JDK 9 RFR of JDK-8161565: Problem list httpclient/SplitResponse.java and URLPermission/URLTest.java
Amy, I approve the addition of SplitResponse to the ProblemList, but not URLTest. URLTest is too important a test to not be run, instead, I will send out an RFR, soon, to resolve the intermittent issue with the test itself. -Chris. > On 18 Jul 2016, at 06:48, Amy Lu wrote: > > Below tests have been observed to fail intermittently with relatively high > frequency: > > java/net/httpclient/SplitResponse.java (JDK-8157533) > java/net/URLPermission/URLTest.java (JDK-8078568) > > Please review this patch to put them to problem list until issues addressed. > > bug: https://bugs.openjdk.java.net/browse/JDK-8161565 > webrev: http://cr.openjdk.java.net/~amlu/8161565/webrev.00/ > > Thanks, > Amy > > > --- old/test/ProblemList.txt 2016-07-18 13:42:14.0 +0800 > +++ new/test/ProblemList.txt 2016-07-18 13:42:14.0 +0800 > @@ -171,6 +171,10 @@ > > java/net/DatagramSocket/SendDatagramToBadAddress.java 7143960 > macosx-all > > +java/net/URLPermission/URLTest.java 8078568 > generic-all > + > +java/net/httpclient/SplitResponse.java 8157533 > generic-all > + > java/net/httpclient/http2/BasicTest.java8157408 > linux-all > java/net/httpclient/http2/ErrorTest.java8158127 > solaris-all,windows-all > java/net/httpclient/http2/TLSConnection.java8157482 > macosx-all > >
RFR [9] 8078568 java/net/URLPermission/URLTest.java fails intermittently with BindException
The test uses hardcoded port numbers for its listening HTTP and HTTPS severs. These hardcoded port numbers are problematic as the ports may not necessarily be available. The reason for the hardcoded port numbers is that the test uses a number of static, checked in, policy files, to grant ( and restrict ) permission required for various explicit test scenarios. A better solution, which avoids the need for hardcoded port numbers, is for the test to configure the security policy dynamically. This also has the advantage of improving the readability of the test, since the code that grants the permissions is along side the test code that makes assertions based on these permissions. The individual test scenarios have not changed. http://cr.openjdk.java.net/~chegar/8078568/ https://bugs.openjdk.java.net/browse/JDK-8078568 -Chris.
Re: JDK 9 RFR of JDK-8161565: Problem list httpclient/SplitResponse.java and URLPermission/URLTest.java
Sure! Pushed ProblemList.txt change with SplitResponse only. Thank you Chris for taking care of URLTest. Thanks, Amy On 7/20/16 8:30 PM, Chris Hegarty wrote: Amy, I approve the addition of SplitResponse to the ProblemList, but not URLTest. URLTest is too important a test to not be run, instead, I will send out an RFR, soon, to resolve the intermittent issue with the test itself. -Chris. On 18 Jul 2016, at 06:48, Amy Lu wrote: Below tests have been observed to fail intermittently with relatively high frequency: java/net/httpclient/SplitResponse.java (JDK-8157533) java/net/URLPermission/URLTest.java (JDK-8078568) Please review this patch to put them to problem list until issues addressed. bug: https://bugs.openjdk.java.net/browse/JDK-8161565 webrev: http://cr.openjdk.java.net/~amlu/8161565/webrev.00/ Thanks, Amy --- old/test/ProblemList.txt2016-07-18 13:42:14.0 +0800 +++ new/test/ProblemList.txt2016-07-18 13:42:14.0 +0800 @@ -171,6 +171,10 @@ java/net/DatagramSocket/SendDatagramToBadAddress.java 7143960 macosx-all +java/net/URLPermission/URLTest.java 8078568 generic-all + +java/net/httpclient/SplitResponse.java 8157533 generic-all + java/net/httpclient/http2/BasicTest.java8157408 linux-all java/net/httpclient/http2/ErrorTest.java8158127 solaris-all,windows-all java/net/httpclient/http2/TLSConnection.java8157482 macosx-all
