Re: RFR 8071660 :URLPermission not handling empty method lists correctly

[Daniel Fuchs]

Hi Vyom,

This looks strange to me:

 268 if(!this.methods.isEmpty() && that.methods.isEmpty())
 269 return true;
 270 if(this.methods.isEmpty() && !that.methods.isEmpty())
 271 return false;
 272 if(this.methods.isEmpty() && that.methods.isEmpty())
 273 return true;

Namely, lines 269 & 273 will return true before the URL part
of the permission has been checked.
Is that really the expected behavior?

best regards,

-- daniel

On 11/06/16 05:50, vyom wrote:

Hi All,

Please review the below fix.

Bug   : JDK-8071660 URLPermission not handling empty method
lists correctly
Webrev :
http://cr.openjdk.java.net/~vtewari/8071660/webrev0.0/index.html


Thanks,
Vyom

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Alan Bateman]

On 11/06/2016 08:59, John Jiang wrote:

Hi,
Just restarted this job.

On 2016/4/29 15:34, Alan Bateman wrote:


On 28/04/2016 05:50, John Jiang wrote:

Hi,
Please review another webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of 
java/net/httpclient tests, even though some ones have to declare 
other modules.
If a test has the @modules tag then then the "modules" key in the 
test suite configuration (TEST.properties) won't be used. That is, 
@modules overrides rather than augments. I just re-read the tag spec 
[1] and I think have this right. In that case, the java.httpclient 
tests that have @modules jdk.httpserver will need to list 
java.httpclient too.
Please review the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.03
Additionally, test/java/net/CookieHandler/CookieManagerTest.java and 
test/java/net/HttpURLConnection/UnmodifiableMaps.java have defined 
@modules, so this new patch excludes them.

The updated patch looks okay to me.

-Alan