JEP 110: leeway for API changes?

[Anthony Vanelverdinghe]

Hi

With the JDK's "Feature Complete" milestone coming up next week: how 
much leeway is there still for API changes? I've made API suggestions 
(a.o. in [1]), ranging from changing 
HttpResponse.multiProcessor::onStart's return type (from BiFunction<..., 
Boolean> to BiPredicate), to building on the j.u.c.Flow API & 
eliminating HttpResponse.MultiProcessor. So I'm wondering what's still 
on on the table for JEP 110 w.r.t. API changes?


[1] http://mail.openjdk.java.net/pipermail/net-dev/2016-March/009608.html

Kind regards,
Anthony

Re: JEP 110: leeway for API changes?

[Simone Bordet]

Hi,

On Thu, May 19, 2016 at 3:54 PM, Anthony Vanelverdinghe
 wrote:
> Hi
>
> With the JDK's "Feature Complete" milestone coming up next week: how much
> leeway is there still for API changes? I've made API suggestions (a.o. in
> [1]), ranging from changing HttpResponse.multiProcessor::onStart's return
> type (from BiFunction<..., Boolean> to BiPredicate), to building on the
> j.u.c.Flow API & eliminating HttpResponse.MultiProcessor. So I'm wondering
> what's still on on the table for JEP 110 w.r.t. API changes?

I second that. I also made API change proposals, but no feedback.

-- 
Simone Bordet
http://bordet.blogspot.com
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

[Svetlana Nikandrova]

Hello,

please review additional test for Solaris SO_FLOW_SLA socket option.
Test checks that SO_FLOW_SLA option is supported on Solaris 11.2+ and 
not supported on other platforms.


http://cr.openjdk.java.net/~snikandrova/8136933/webrev.00/ 



Thank you,
Svetlana

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

[Artem Smotrakov]

Hi Svetlana,

Please see a couple of comments below. I'll leave the final review to 
official reviewers.


1. You may use test/lib/testlibrary/jdk/testlibrary/OSInfo.java to check 
OS type. I think it also may be good to add getSolarisVersion() to 
OSInfo.java (see getWindowsVersion() method)


You can also use ProcessTools.java in getSolarisVersion()

2. line 46: Did you mean java.lang.String

3. Should it throw an exception after lines 173 and 181? Or, this may 
depend on other constraints? I see you added a comment for 
checkSocketOption() method, but it maybe better to clarify why no 
exception is also fine.


I am also wondering if it should expect no exception in getOption() if 
setOption() succeeded.


Artem

On 05/19/2016 09:13 AM, Svetlana Nikandrova wrote:

Hello,

please review additional test for Solaris SO_FLOW_SLA socket option.
Test checks that SO_FLOW_SLA option is supported on Solaris 11.2+ and 
not supported on other platforms.


http://cr.openjdk.java.net/~snikandrova/8136933/webrev.00/ 



Thank you,
Svetlana

Re: RFR 8157105: HTTP/2 client hangs in blocking mode if an invalid frame has been received

[Roger Riggs]

Hi Michael,

Look ok,

A one line description of the error it is trying to produce would be a 
good addition.

Either in comment, javadoc or @summary

Roger

On 5/18/2016 12:55 PM, Michael McMahon wrote:

Could I get the following change reviewed please?

http://cr.openjdk.java.net/~michaelm/8157105/webrev.1/

Some error conditions not being handled correctly and some
logging cleanup.

Thanks
Michael.