Re: JDK-8148424 Support ipv6-only environments
On 28/01/2016 02:29, Martin Buchholz wrote: Are y'all interested in our ipv6-only changes? https://bugs.openjdk.java.net/browse/JDK-8148424 If yes, there will be some work on both sides, mostly for multi-platform testing. I think so, this is configuration that we attempted to test several times, going back to JDK 1.4. -Alan
Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs
On 27 Jan 2016, at 17:24, Claes Redestad wrote: > > On 2016-01-18 17:20, Claes Redestad wrote: >> >> The ability for URLStreamHandler implementations to override the parseURL >> method seem to prevent this improvement unless we only do this for a subset >> of known, well-behaved URLStreamHandlers, which likely defeat the >> optimization by adding complexity. > > Right, the fast path can only be safely used for the non-overrideable > handlers (jrt and file), but turns out we can make that work without > penalizing other cases: > > http://cr.openjdk.java.net/~redestad/8147462/webrev.04/ This looks fine Claes. Maybe just a comment on the fact that character based comparison is being used for perf reasons. In an older version of the webrev, there was an updated to an existing test, test/java/net/URI/URItoURLTest.java. I assume this was just mistakenly omitted from the latest version? -Chris. > Relevant micros[1] show that this brings a benefit to file/jrt, even when > mixed with slow path URIs, while micros only hitting slow path > (newHttpURIToURL, opaqueURIToURL) doesn't regress: > > Before: > Benchmark Mode CntScoreError Units > URIBench.mixedURIToURLavgt 30 463.748 ± 14.445 ns/op > URIBench.newHttpURIToURL avgt 30 441.497 ± 20.173 ns/op > URIBench.newURIToURL avgt 30 227.106 ± 9.055 ns/op > URIBench.opaqueURIToURL avgt 30 320.904 ± 13.232 ns/op > > Patched: > Benchmark Mode CntScoreError Units > URIBench.mixedURIToURLavgt 30 441.773 ± 16.530 ns/op > URIBench.newHttpURIToURL avgt 30 433.946 ± 18.569 ns/op > URIBench.newURIToURL avgt 30 147.379 ± 6.349 ns/op > URIBench.opaqueURIToURL avgt 30 316.632 ± 12.940 ns/op > > /Claes > > [1] http://cr.openjdk.java.net/~redestad/8147462/URIBench.java
Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs
On 2016-01-28 16:52, Chris Hegarty wrote: ... This looks fine Claes. Thanks, Chris! Maybe just a comment on the fact that character based comparison is being used for perf reasons. In an older version of the webrev, there was an updated to an existing test, test/java/net/URI/URItoURLTest.java. I assume this was just mistakenly omitted from the latest version? Fixed test and added a comment: http://cr.openjdk.java.net/~redestad/8147462/webrev.05/ Thanks! /Claes
Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs
On 28 Jan 2016, at 16:38, Claes Redestad wrote: > On 2016-01-28 16:52, Chris Hegarty wrote: >>> ... >> This looks fine Claes. > > Thanks, Chris! > >> >> Maybe just a comment on the fact that character based comparison is >> being used for perf reasons. >> >> In an older version of the webrev, there was an updated to an existing test, >> test/java/net/URI/URItoURLTest.java. I assume this was just mistakenly >> omitted from the latest version? > > Fixed test and added a comment: > > http://cr.openjdk.java.net/~redestad/8147462/webrev.05/ Reviewed. -Chris.
Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs
This looks okay. I think it would be good to put a javadoc comment on this method, also maybe move it to below all the constructors rather than in the middle. -Alan. On 28/01/2016 16:38, Claes Redestad wrote: On 2016-01-28 16:52, Chris Hegarty wrote: ... This looks fine Claes. Thanks, Chris! Maybe just a comment on the fact that character based comparison is being used for perf reasons. In an older version of the webrev, there was an updated to an existing test, test/java/net/URI/URItoURLTest.java. I assume this was just mistakenly omitted from the latest version? Fixed test and added a comment: http://cr.openjdk.java.net/~redestad/8147462/webrev.05/ Thanks! /Claes
Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs
On 2016-01-28 20:56, Alan Bateman wrote: This looks okay. I think it would be good to put a javadoc comment on this method, also maybe move it to below all the constructors rather than in the middle. -Alan. Sure, as this is package-private API a short description and reference to the URI::toURL method whose specification we adhere to should suffice: http://cr.openjdk.java.net/~redestad/8147462/webrev.06/ Thanks! /Claes
