Re: RFR 8064924: Update java.net.URL to work with modules

[Alan Bateman]

On 09/02/2015 14:57, Chris Hegarty wrote:

:

Updated webrev [ spec and implementation] :
  http://cr.openjdk.java.net/~chegar/8064924/04/

The updated javadoc looks good. I haven't had a chance yet to look at 
the implementation but I think you will need to update 
/make/common/CORE_PKGS.gmk for the spi package.


-Alan.

Re: [8u-dev] Request for approval: JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

[Konstantin Shefov]

Hello,

I have evaluated https://bugs.openjdk.java.net/browse/JDK-8071458

I have tried to use different symbols in networking interface name in 
Linux. I have added a comment to 
https://bugs.openjdk.java.net/browse/JDK-8071458


I am able to use symbols: "-", "+", "=", "#", "@".
I was UNABLE to use: "?", "~", "$", "*", "!", "[", "(", "&", "^", "|", 
"/", ":" and "\".


My network interface name in Linux is now "eth0.1_-+=#@55" (used 
"ifconfig" command).


I think I should create a new review request for JDK 9 again and then 
backport it to 8.


Thanks
-Konstantin

On 23.01.2015 16:47, Seán Coffey wrote:

Konstantin,

can you hold off pushing this fix to jdk8u for the moment ? It's a P4
and could have behavioural consequences (something we try and avoid in
update releases). I see JDK-8071458 was logged to track IPv6 scope
specifications. Let's see how this soaks into JDK 9 over coming days
and let's see how JDK-8071458 progresses.

regards,
Sean.

On 23/01/15 12:56, Konstantin Shefov wrote:

Hello,

Please approve the direct backport of the bug fix to 8u-dev

Patch applies cleanly to JDK 8u.

The bug:https://bugs.openjdk.java.net/browse/JDK-6933879
The webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.01/

JDK 9 changeset:
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/801eb37fc6c4
Review thread:
http://mail.openjdk.java.net/pipermail/net-dev/2015-January/008834.html

Thanks
-Konstantin

Re: [8u-dev] Request for approval: JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

[Chris Hegarty]

On 10 Feb 2015, at 15:28, Konstantin Shefov  
wrote:

> Hello,
> 
> I have evaluated https://bugs.openjdk.java.net/browse/JDK-8071458

6933879 allowed a minimal additional set of non-alphanumeric characters. 
8071458 was filed to examine the potential specification implications that 
arose during the review of 6933879. Before any attempt is made to add further 
non-alphanumeric characters, the specification needs to be examined to see if 
it makes sense to define the allowable set of characters, or other side-effects 
of doing so.

-Chris.

> I have tried to use different symbols in networking interface name in Linux. 
> I have added a comment to https://bugs.openjdk.java.net/browse/JDK-8071458
> 
> I am able to use symbols: "-", "+", "=", "#", "@".
> I was UNABLE to use: "?", "~", "$", "*", "!", "[", "(", "&", "^", "|", "/", 
> ":" and "\".
> 
> My network interface name in Linux is now "eth0.1_-+=#@55" (used "ifconfig" 
> command).
> 
> I think I should create a new review request for JDK 9 again and then 
> backport it to 8.
> 
> Thanks
> -Konstantin
> 
> On 23.01.2015 16:47, Seán Coffey wrote:
>> Konstantin,
>> 
>> can you hold off pushing this fix to jdk8u for the moment ? It's a P4
>> and could have behavioural consequences (something we try and avoid in
>> update releases). I see JDK-8071458 was logged to track IPv6 scope
>> specifications. Let's see how this soaks into JDK 9 over coming days
>> and let's see how JDK-8071458 progresses.
>> 
>> regards,
>> Sean.
>> 
>> On 23/01/15 12:56, Konstantin Shefov wrote:
>>> Hello,
>>> 
>>> Please approve the direct backport of the bug fix to 8u-dev
>>> 
>>> Patch applies cleanly to JDK 8u.
>>> 
>>> The bug:https://bugs.openjdk.java.net/browse/JDK-6933879
>>> The webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.01/
>>> 
>>> JDK 9 changeset:
>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/801eb37fc6c4
>>> Review thread:
>>> http://mail.openjdk.java.net/pipermail/net-dev/2015-January/008834.html
>>> 
>>> Thanks
>>> -Konstantin
>> 
> 

Re: RFR 8064924: Update java.net.URL to work with modules

[Chris Hegarty]

On 10 Feb 2015, at 11:35, Alan Bateman  wrote:

> On 09/02/2015 14:57, Chris Hegarty wrote:
>> :
>> 
>> Updated webrev [ spec and implementation] :
>>  http://cr.openjdk.java.net/~chegar/8064924/04/
>> 
> The updated javadoc looks good. I haven't had a chance yet to look at the 
> implementation but I think you will need to update 
> /make/common/CORE_PKGS.gmk for the spi package.

Sorry, I have the change locally but forgot it. I updated the webrev with the 
changes to the top level repo ( below ):

$ hg diff make/common/CORE_PKGS.gmk 
diff --git a/make/common/CORE_PKGS.gmk b/make/common/CORE_PKGS.gmk
--- a/make/common/CORE_PKGS.gmk
+++ b/make/common/CORE_PKGS.gmk
@@ -103,6 +103,7 @@
 java.lang.reflect \
 java.math \
 java.net \
+java.net.spi \
 java.nio \
 java.nio.channels \
 java.nio.channels.spi \

-Chris.

> -Alan.

Re: Patch for NetworkInterface.c to fix incorrect returned values for broadcast address and net mask on Linux

[Doychin Bondzhev]

Hi,

Anyone who can look into this?

Thanks in advance

On 20.1.2015 г. 22:20 ч., Doychin Bondzhev wrote:

Hi,

Please review this patch
http://dmitryalexandrov.net/~bgjug/network-interface/webrev.00/

It fixes the problem described in this thread

http://mail.openjdk.java.net/pipermail/net-dev/2014-December/008806.html

Also in order to setup dummy interface with test values you can use
these commands:

ip link add dummy0 type dummy

ip addr add 10.5.5.1/28  brd 10.5.5.15 dev dummy0
ip addr add 10.6.0.1/23  brd 10.6.1.255 dev dummy0
ip addr add 10.7.0.1/25  brd 10.7.0.127 dev dummy0

The output from NetworkInterface test
test/java/net/NetworkInterface/NetParamsTest.java for this interface is:

dummy0 :
 Status: DOWN
 Hardware Address: 56:ffd4:fffd:ffc2:ffec:ff82:
 Loopback: false
 Point to Point: false
 Virtual: false
 Multicast: false
 MTU: 1500
 Bindings:
 /10.7.0.1/25  [/10.7.0.127 ]
 /10.6.0.1/23  [/10.6.1.255 ]
 /10.5.5.1/28  [/10.5.5.15 ]

This is the output from Java 1.8.0_25. Same output is produced with
existing version of NetworkInterface.c in JDK 9

dummy0 :
 Status: DOWN
 Hardware Address: 56:ffd4:fffd:ffc2:ffec:ff82:
 Loopback: false
 Point to Point: false
 Virtual: false
 Multicast: false
 MTU: 1500
 Bindings:
 /10.7.0.1/28  [/10.5.5.15 ]
 /10.6.0.1/28  [/10.5.5.15 ]
 /10.5.5.1/28  [/10.5.5.15 ]





--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
PowerStor - Warehouse & POS
http://www.dsoft-bg.com/
Mobile: +359888243116
<>

smime.p7s
Description: S/MIME Cryptographic Signature