RFR : 8032808, 8047186, 8029607, 8048212 - SO_FLOW_SLA support for solaris, Set TOS in IPv6 header

2014-08-22 Thread Seán Coffey
I'd like to backport these fixes into the jdk7u-dev codeline. They're 
already in jdk8u-dev.


https://bugs.openjdk.java.net/browse/JDK-8032808 - SO_FLOW_SLA support 
for solaris
https://bugs.openjdk.java.net/browse/JDK-8047186 - Exception handling 
change linked to above


https://bugs.openjdk.java.net/browse/JDK-8029607 - Set TOS in IPv6 header
https://bugs.openjdk.java.net/browse/JDK-8048212 - Testcase failure with 
above fix


some of the changes are quite different from jdk8u in that the make 
system is different. I've put some of the main differences in bullet 
points :


* new makefiles to capture the jdk/net classes
* Different javadoc makefile layout for 7u
* static src/share/native/java/net/jdk_net_SocketFlow.h header file 
(dynamic in jdk8u)

* Alter src/share/classes/jdk/net/Sockets.java :
  - throw new Error(e); instead of throw new InternalError(e); (older API)
* removal of lambda use in testcase

webrev : http://cr.openjdk.java.net/~coffeys/webrev.sla_tos/webrev/
CCC for 7u has been submitted.

Regards,
Sean.



Re: RFR : 8032808, 8047186, 8029607, 8048212 - SO_FLOW_SLA support for solaris, Set TOS in IPv6 header

2014-08-22 Thread Michael McMahon
There doesn't seem to be any change to SocksProxy.java apart from the 
copyright date.
Otherwise, the change looks fine. It just occurred to me that an update 
to policytool
was made to know about the new NetworkPermission class. I don't think we 
backported it to
8 even. But, for completeness sake we might want to backport it to both 
of these releases

at some point in the future.

Michael

On 22/08/14 16:24, Seán Coffey wrote:
I'd like to backport these fixes into the jdk7u-dev codeline. They're 
already in jdk8u-dev.


https://bugs.openjdk.java.net/browse/JDK-8032808 - SO_FLOW_SLA support 
for solaris
https://bugs.openjdk.java.net/browse/JDK-8047186 - Exception handling 
change linked to above


https://bugs.openjdk.java.net/browse/JDK-8029607 - Set TOS in IPv6 header
https://bugs.openjdk.java.net/browse/JDK-8048212 - Testcase failure 
with above fix


some of the changes are quite different from jdk8u in that the make 
system is different. I've put some of the main differences in bullet 
points :


* new makefiles to capture the jdk/net classes
* Different javadoc makefile layout for 7u
* static src/share/native/java/net/jdk_net_SocketFlow.h header file 
(dynamic in jdk8u)

* Alter src/share/classes/jdk/net/Sockets.java :
  - throw new Error(e); instead of throw new InternalError(e); (older API)
* removal of lambda use in testcase

webrev : http://cr.openjdk.java.net/~coffeys/webrev.sla_tos/webrev/
CCC for 7u has been submitted.

Regards,
Sean.





Re: RFR : 8032808, 8047186, 8029607, 8048212 - SO_FLOW_SLA support for solaris, Set TOS in IPv6 header

2014-08-22 Thread Seán Coffey
Not sure how the SocksProxy.java change occurred. I'll fix that up 
before pushing. Thanks for catching.


Good point about the NetworkPermission changes for policytool - I don't 
see it in jdk 9 either (I see NetPermission being catered for) 
jdk/src/jdk.runtime/share/classes/sun/security/tools/policytool/PolicyTool.java


Will look into that as a follow up.

regards,
Sean.

On 22/08/14 17:05, Michael McMahon wrote:
There doesn't seem to be any change to SocksProxy.java apart from the 
copyright date.
Otherwise, the change looks fine. It just occurred to me that an 
update to policytool
was made to know about the new NetworkPermission class. I don't think 
we backported it to
8 even. But, for completeness sake we might want to backport it to 
both of these releases

at some point in the future.

Michael

On 22/08/14 16:24, Seán Coffey wrote:
I'd like to backport these fixes into the jdk7u-dev codeline. They're 
already in jdk8u-dev.


https://bugs.openjdk.java.net/browse/JDK-8032808 - SO_FLOW_SLA 
support for solaris
https://bugs.openjdk.java.net/browse/JDK-8047186 - Exception handling 
change linked to above


https://bugs.openjdk.java.net/browse/JDK-8029607 - Set TOS in IPv6 header
https://bugs.openjdk.java.net/browse/JDK-8048212 - Testcase failure 
with above fix


some of the changes are quite different from jdk8u in that the make 
system is different. I've put some of the main differences in bullet 
points :


* new makefiles to capture the jdk/net classes
* Different javadoc makefile layout for 7u
* static src/share/native/java/net/jdk_net_SocketFlow.h header file 
(dynamic in jdk8u)

* Alter src/share/classes/jdk/net/Sockets.java :
  - throw new Error(e); instead of throw new InternalError(e); (older 
API)

* removal of lambda use in testcase

webrev : http://cr.openjdk.java.net/~coffeys/webrev.sla_tos/webrev/
CCC for 7u has been submitted.

Regards,
Sean.