Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

[Paul Sandoz]

On May 12, 2014, at 1:00 PM, Ivan Gerasimov  wrote:

> src/share/classes/sun/misc/UUDecoder.java
> 126 StringBuilder x = new StringBuilder();
> Is only filled, but doesn't seem to be used anyhow.
> Maybe just delete it?
> 

Thanks, i will take a look at this and your other change once 
s/StringBuffer/StringBuilder/g is out of the way.

Paul.



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

[Paul Sandoz]

On May 12, 2014, at 4:07 PM, Daniel Fuchs  wrote:

> Hi Paul,
> 
> I looked at -management and the changes there look good.
> 
> There is just some two spaces vs four space formatting in
> 
> line 99.
> 

Thanks, updated.

Paul.


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

[Alan Bateman]

On 12/05/2014 11:55, Paul Sandoz wrote:

On May 12, 2014, at 12:42 PM, Alan Bateman  wrote:


On 12/05/2014 11:03, Paul Sandoz wrote:

It covers many areas and i have grouped the patches into such areas to aid 
reviewing. When commenting please including core-libs.

The groupings are a bit odd

Yeah, definitely idiosyncratic, i tried to lump 'em in terms of areas where 
people could focus their expertise without creating too few or too many webrevs.

I looked through the -tools and don't see anything escaping so looks 
good to me. Minor alignment issues in ExpressionParser and TokenMgrError.


I also didn't see any takers for -media so I looked through those 
changes too. A lot of toString methods and I don't see anything 
obviously leaking to other threads. The s/retBuffer/sb/ in 
TreeModelEvent.toString is another multi-line statement, no big deal of 
course. Minor alignment issue in DefaultTreeSelectionModel and 
StandardTextSource.


-Alan.