hg: jdk8/tl/jdk: 8027371: Add JDI tests for breakpointing and stepping in lambda code

2013-10-29 Thread staffan . larsen 
Changeset: ecba02f6be31
Author:sla
Date:  2013-10-29 08:10 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecba02f6be31

8027371: Add JDI tests for breakpointing and stepping in lambda code
Reviewed-by: mchung, sspitsyn

+ test/com/sun/jdi/LambdaBreakpointTest.java
+ test/com/sun/jdi/LambdaStepTest.java

hg: jdk8/tl/jdk: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-29 Thread sean . coffey 
Changeset: d34c5e860d5f
Author:aefimov
Date:  2013-10-24 17:23 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f

8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing
Reviewed-by: okutsu, mfang, alanb

! test/ProblemList.txt
! test/sun/util/resources/TimeZone/Bug6317929.java

RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Chris Hegarty 
This is a trivial change, good practice, to check return values from 
GetFieldID, and friends.


I've taken a quick look over the networking native code and see no other 
similar issues.


http://cr.openjdk.java.net/~chegar/8026880/webrev.00/

-Chris.

Re: RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Alan Bateman 

On 29/10/2013 16:56, Chris Hegarty wrote:
This is a trivial change, good practice, to check return values from 
GetFieldID, and friends.


I've taken a quick look over the networking native code and see no 
other similar issues.


http://cr.openjdk.java.net/~chegar/8026880/webrev.00/
This looks okay but doesn't the Windows implementation need to be 
updated too?


-Alan

Re: RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Chris Hegarty 

On 10/29/2013 05:00 PM, Alan Bateman wrote:

On 29/10/2013 16:56, Chris Hegarty wrote:

This is a trivial change, good practice, to check return values from
GetFieldID, and friends.

I've taken a quick look over the networking native code and see no
other similar issues.

http://cr.openjdk.java.net/~chegar/8026880/webrev.00/

This looks okay but doesn't the Windows implementation need to be
updated too?


D'oh, I spent too much time looking for other places where this was 
missing, and I forgot about src/windows!


Updated webrev:
  http://cr.openjdk.java.net/~chegar/8026880/webrev.01/

-Chris.



-Alan

hg: jdk8/tl/jdk: 8027466: Revert jdk/THIRD_PARTY_README to known good version

2013-10-29 Thread chris . hegarty 
Changeset: 121c34517841
Author:chegar
Date:  2013-10-29 17:21 +
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/121c34517841

8027466: Revert jdk/THIRD_PARTY_README to known good version
Reviewed-by: alanb

! THIRD_PARTY_README

Re: RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Alan Bateman 

On 29/10/2013 17:11, Chris Hegarty wrote:


D'oh, I spent too much time looking for other places where this was 
missing, and I forgot about src/windows!


Updated webrev:
  http://cr.openjdk.java.net/~chegar/8026880/webrev.01/

This looks okay to me.

-Alan