hg: jdk8/tl/jdk: 8025734: Use literal IP address where possible in SocketPermission generated by HttpURLPermission

[michael . x . mcmahon]

Changeset: 1b0dfa631b6f
Author:michaelm
Date:  2013-10-23 11:00 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b0dfa631b6f

8025734: Use literal IP address where possible in SocketPermission generated by 
HttpURLPermission
Reviewed-by: chegar

! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
+ test/java/net/URLPermission/nstest/LookupTest.java
+ 
test/java/net/URLPermission/nstest/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor
+ test/java/net/URLPermission/nstest/SimpleNameService.java
+ test/java/net/URLPermission/nstest/SimpleNameServiceDescriptor.java
+ test/java/net/URLPermission/nstest/policy

hg: jdk8/tl/langtools: 8026508: Invokedynamic instructions don't get line number table entries

[jan . lahoda]

Changeset: b05db8c815e8
Author:jlahoda
Date:  2013-10-23 07:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b05db8c815e8

8026508: Invokedynamic instructions don't get line number table entries
Summary: Setting or correcting positions for many trees produced by 
LambdaToMethod.
Reviewed-by: vromero, rfield

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/T8019486/WrongLNTForLambdaTest.java
- test/tools/javac/T8019486/WrongLVTForLambdaTest.java

RFR 8020758: HttpCookie constructor does not throw IAE when name contains a space

[Chris Hegarty]

Mark, Michael,

java.net.HttpCookie, rightly or wrongly, supports three different Cookie 
specifications. Some of these are conflicting, and there have been many 
many bugs reported against various "special" characters being accepted.


This one is hopefully straight forward. The issue is specifically 
complaining about a space in the cookie name. Looking at the Netscape 
cookie draft [1] and RFC 2965 [2], they both seem to restrict a space in 
the cookie name, so I see no conflict in specs here. It seems reasonable 
to add this restriction.


http://cr.openjdk.java.net/~chegar/8020758/webrev.00/

Additionally, since we are now adding a further restriction on the 
accepted characters in the cookie name, there is a slight compatibility 
risk. I believe this risk to be very small, and cannot find any evidence 
of cookies with spaces in there names.


Thanks,
-Chris.

[1] 
http://web.archive.org/web/20020803110822/http://wp.netscape.com/newsref/std/cookie_spec.html

[2] http://www.ietf.org/rfc/rfc2965.txt

Re: RFR 8020758: HttpCookie constructor does not throw IAE when name contains a space

[Michael McMahon]

I agree. The change looks fine to me.

Thanks
Michael

On 23/10/13 12:09, Chris Hegarty wrote:

Mark, Michael,

java.net.HttpCookie, rightly or wrongly, supports three different 
Cookie specifications. Some of these are conflicting, and there have 
been many many bugs reported against various "special" characters 
being accepted.


This one is hopefully straight forward. The issue is specifically 
complaining about a space in the cookie name. Looking at the Netscape 
cookie draft [1] and RFC 2965 [2], they both seem to restrict a space 
in the cookie name, so I see no conflict in specs here. It seems 
reasonable to add this restriction.


http://cr.openjdk.java.net/~chegar/8020758/webrev.00/

Additionally, since we are now adding a further restriction on the 
accepted characters in the cookie name, there is a slight 
compatibility risk. I believe this risk to be very small, and cannot 
find any evidence of cookies with spaces in there names.


Thanks,
-Chris.

[1] 
http://web.archive.org/web/20020803110822/http://wp.netscape.com/newsref/std/cookie_spec.html

[2] http://www.ietf.org/rfc/rfc2965.txt

Re: RFR 8020758: HttpCookie constructor does not throw IAE when name contains a space

[Mark Sheppard]

Hi Chris,
  yes, I concur, also

regards
Mark

On 23/10/2013 12:09, Michael McMahon wrote:

I agree. The change looks fine to me.

Thanks
Michael

On 23/10/13 12:09, Chris Hegarty wrote:

Mark, Michael,

java.net.HttpCookie, rightly or wrongly, supports three different 
Cookie specifications. Some of these are conflicting, and there have 
been many many bugs reported against various "special" characters 
being accepted.


This one is hopefully straight forward. The issue is specifically 
complaining about a space in the cookie name. Looking at the Netscape 
cookie draft [1] and RFC 2965 [2], they both seem to restrict a space 
in the cookie name, so I see no conflict in specs here. It seems 
reasonable to add this restriction.


http://cr.openjdk.java.net/~chegar/8020758/webrev.00/

Additionally, since we are now adding a further restriction on the 
accepted characters in the cookie name, there is a slight 
compatibility risk. I believe this risk to be very small, and cannot 
find any evidence of cookies with spaces in there names.


Thanks,
-Chris.

[1] 
http://web.archive.org/web/20020803110822/http://wp.netscape.com/newsref/std/cookie_spec.html

[2] http://www.ietf.org/rfc/rfc2965.txt

hg: jdk8/tl/jdk: 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection

[staffan . larsen]

Changeset: 8c20e9ef8709
Author:sla
Date:  2013-10-23 15:55 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c20e9ef8709

8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test 
to use NMT for memory leak detection
Reviewed-by: dcubed

! test/ProblemList.txt
+ test/java/lang/instrument/NMTHelper.java
! test/java/lang/instrument/RedefineBigClass.sh
! test/java/lang/instrument/RedefineBigClassApp.java
! test/java/lang/instrument/RetransformBigClass.sh
! test/java/lang/instrument/RetransformBigClassApp.java

hg: jdk8/tl/jdk: 8020758: HttpCookie constructor does not throw IAE when name contains a space

[chris . hegarty]

Changeset: f120672b91ef
Author:chegar
Date:  2013-10-23 14:38 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120672b91ef

8020758: HttpCookie constructor does not throw IAE when name contains a space
Reviewed-by: michaelm, msheppar

! src/share/classes/java/net/HttpCookie.java
! test/java/net/CookieHandler/TestHttpCookie.java

hg: jdk8/tl/jdk: 5036554: unmarshal error on CORBA alias type in CORBA any

[sean . coffey]

Changeset: 2af3f5a61322
Author:coffeys
Date:  2013-10-23 16:53 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2af3f5a61322

5036554: unmarshal error on CORBA alias type in CORBA any
Reviewed-by: chegar, smarks

+ test/com/sun/corba/5036554/JavaBug.java
+ test/com/sun/corba/5036554/README
+ test/com/sun/corba/5036554/TestCorbaBug.sh
+ test/com/sun/corba/5036554/bug.idl

hg: jdk8/tl/corba: 5036554: unmarshal error on CORBA alias type in CORBA any

[sean . coffey]

Changeset: a90e9efa4264
Author:coffeys
Date:  2013-10-23 16:45 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/corba/rev/a90e9efa4264

5036554: unmarshal error on CORBA alias type in CORBA any
Reviewed-by: chegar, smarks

! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

[Chris Hegarty]

Hi Dan,

Firstly, thank you for working on this. This is really useful, and I'm 
glad to see it going into JDK 8.


I grabed the patch and built it. All looks fine, and the updates you 
added to the manual test are really useful to verify the implementation.


All in all I'm happy with this change, just a small comment...

Why did you move initJavaClass to 
Java_sun_net_spi_DefaultProxySelector_getSystemProxy. I think it should 
be in Java_sun_net_spi_DefaultProxySelector_init, so it is executed just 
once.


-Chris.

On 10/22/2013 08:30 PM, Dan Xu wrote:


Hi All,

Please review the fix towards gnome proxy settings. In the recent Gnome
versions, it has phased out GConf and swithed to use GSettings to handle
all the system configurations. But in JDK, we are still use GConf-based
proxy resolution, which generates wrong results in the latest linux
distributions. In this change, I added a new way to resolve proxy
correctly, which makes use of GProxyResolver to handle newwork proxy
resolution. It is based on GSettings, so every time proxy changed in the
GSettings, it will catch that  and give the updated results. In
addition, it can also handle proxy ignore pattern correctly. For
example, it can handle not only plain domain name pattern, like
domain.com, but it can also handle more complex patterns, like
*.domain.com, IPv4/CIDR (like 127.0.0.1/8), IPv6/CIDR, etc.

The code changes have been tested manually. Here are the bug details and
webrev changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-7122887
webrev: http://cr.openjdk.java.net/~dxu/7122887/webrev.00/

Thanks,

-Dan

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

[Dan Xu]

You are right, Chris. The java class objects initialization should be in 
the init method. I will update it now. Thanks for the review!


-Dan


On 10/23/2013 11:21 AM, Chris Hegarty wrote:

Hi Dan,

Firstly, thank you for working on this. This is really useful, and I'm 
glad to see it going into JDK 8.


I grabed the patch and built it. All looks fine, and the updates you 
added to the manual test are really useful to verify the implementation.


All in all I'm happy with this change, just a small comment...

Why did you move initJavaClass to 
Java_sun_net_spi_DefaultProxySelector_getSystemProxy. I think it 
should be in Java_sun_net_spi_DefaultProxySelector_init, so it is 
executed just once.


-Chris.

On 10/22/2013 08:30 PM, Dan Xu wrote:


Hi All,

Please review the fix towards gnome proxy settings. In the recent Gnome
versions, it has phased out GConf and swithed to use GSettings to handle
all the system configurations. But in JDK, we are still use GConf-based
proxy resolution, which generates wrong results in the latest linux
distributions. In this change, I added a new way to resolve proxy
correctly, which makes use of GProxyResolver to handle newwork proxy
resolution. It is based on GSettings, so every time proxy changed in the
GSettings, it will catch that  and give the updated results. In
addition, it can also handle proxy ignore pattern correctly. For
example, it can handle not only plain domain name pattern, like
domain.com, but it can also handle more complex patterns, like
*.domain.com, IPv4/CIDR (like 127.0.0.1/8), IPv6/CIDR, etc.

The code changes have been tested manually. Here are the bug details and
webrev changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-7122887
webrev: http://cr.openjdk.java.net/~dxu/7122887/webrev.00/

Thanks,

-Dan

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

[Dan Xu]

Hi,

I have moved initJavaClass function into 
Java_sun_net_spi_DefaultProxySelector_init to only initialize the java 
objects once. The updated webrev can be reviewed at 
http://cr.openjdk.java.net/~dxu/7122887/webrev.01/ 
. Thanks!


-Dan

On 10/23/2013 11:28 AM, Dan Xu wrote:
You are right, Chris. The java class objects initialization should be 
in the init method. I will update it now. Thanks for the review!


-Dan


On 10/23/2013 11:21 AM, Chris Hegarty wrote:

Hi Dan,

Firstly, thank you for working on this. This is really useful, and 
I'm glad to see it going into JDK 8.


I grabed the patch and built it. All looks fine, and the updates you 
added to the manual test are really useful to verify the implementation.


All in all I'm happy with this change, just a small comment...

Why did you move initJavaClass to 
Java_sun_net_spi_DefaultProxySelector_getSystemProxy. I think it 
should be in Java_sun_net_spi_DefaultProxySelector_init, so it is 
executed just once.


-Chris.

On 10/22/2013 08:30 PM, Dan Xu wrote:


Hi All,

Please review the fix towards gnome proxy settings. In the recent Gnome
versions, it has phased out GConf and swithed to use GSettings to 
handle

all the system configurations. But in JDK, we are still use GConf-based
proxy resolution, which generates wrong results in the latest linux
distributions. In this change, I added a new way to resolve proxy
correctly, which makes use of GProxyResolver to handle newwork proxy
resolution. It is based on GSettings, so every time proxy changed in 
the

GSettings, it will catch that  and give the updated results. In
addition, it can also handle proxy ignore pattern correctly. For
example, it can handle not only plain domain name pattern, like
domain.com, but it can also handle more complex patterns, like
*.domain.com, IPv4/CIDR (like 127.0.0.1/8), IPv6/CIDR, etc.

The code changes have been tested manually. Here are the bug details 
and

webrev changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-7122887
webrev: http://cr.openjdk.java.net/~dxu/7122887/webrev.00/

Thanks,

-Dan

hg: jdk8/tl/jdk: 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs

[sean . coffey]

Changeset: ee7f1c78bec7
Author:coffeys
Date:  2013-10-23 20:51 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee7f1c78bec7

8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly 
aurora test runs
Reviewed-by: chegar

! test/javax/xml/ws/clientjar/TestWsImport.java

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

[Chris Hegarty]

On 10/23/2013 07:53 PM, Dan Xu wrote:

Hi,

I have moved initJavaClass function into
Java_sun_net_spi_DefaultProxySelector_init to only initialize the java
objects once. The updated webrev can be reviewed at
http://cr.openjdk.java.net/~dxu/7122887/webrev.01/
. Thanks!


Looks good to me Dan.

-Chris.



-Dan

On 10/23/2013 11:28 AM, Dan Xu wrote:

You are right, Chris. The java class objects initialization should be
in the init method. I will update it now. Thanks for the review!

-Dan


On 10/23/2013 11:21 AM, Chris Hegarty wrote:

Hi Dan,

Firstly, thank you for working on this. This is really useful, and
I'm glad to see it going into JDK 8.

I grabed the patch and built it. All looks fine, and the updates you
added to the manual test are really useful to verify the implementation.

All in all I'm happy with this change, just a small comment...

Why did you move initJavaClass to
Java_sun_net_spi_DefaultProxySelector_getSystemProxy. I think it
should be in Java_sun_net_spi_DefaultProxySelector_init, so it is
executed just once.

-Chris.

On 10/22/2013 08:30 PM, Dan Xu wrote:


Hi All,

Please review the fix towards gnome proxy settings. In the recent Gnome
versions, it has phased out GConf and swithed to use GSettings to
handle
all the system configurations. But in JDK, we are still use GConf-based
proxy resolution, which generates wrong results in the latest linux
distributions. In this change, I added a new way to resolve proxy
correctly, which makes use of GProxyResolver to handle newwork proxy
resolution. It is based on GSettings, so every time proxy changed in
the
GSettings, it will catch that  and give the updated results. In
addition, it can also handle proxy ignore pattern correctly. For
example, it can handle not only plain domain name pattern, like
domain.com, but it can also handle more complex patterns, like
*.domain.com, IPv4/CIDR (like 127.0.0.1/8), IPv6/CIDR, etc.

The code changes have been tested manually. Here are the bug details
and
webrev changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-7122887
webrev: http://cr.openjdk.java.net/~dxu/7122887/webrev.00/

Thanks,

-Dan

hg: jdk8/tl/langtools: 2 new changesets

[jan . lahoda]

Changeset: abc3eaccba73
Author:jlahoda
Date:  2013-10-23 23:02 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abc3eaccba73

8027191: Fix for JDK-8026861 refers to an incorrect bug number
Summary: Reverting changeset b05db8c815e8, so that it can be applied again with 
a correct bug number
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
- test/tools/javac/T8019486/WrongLNTForLambdaTest.java
+ test/tools/javac/T8019486/WrongLVTForLambdaTest.java

Changeset: 864dafc5ab7a
Author:jlahoda
Date:  2013-10-23 07:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/864dafc5ab7a

8026861: Wrong LineNumberTable for variable declarations in lambdas
Summary: Setting or correcting positions for many trees produced by 
LambdaToMethod.
Reviewed-by: vromero, rfield

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/T8019486/WrongLNTForLambdaTest.java
- test/tools/javac/T8019486/WrongLVTForLambdaTest.java

hg: jdk8/tl/jdk: 8024688: further split Map and ConcurrentMap defaults eliminating looping from Map defaults, Map.merge fixes and doc fixes.

[mike . duigou]

Changeset: f4129fcfacdc
Author:mduigou
Date:  2013-10-23 14:32 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4129fcfacdc

8024688: further split Map and ConcurrentMap defaults eliminating looping from 
Map defaults, Map.merge fixes and doc fixes.
Reviewed-by: psandoz, dholmes

! src/share/classes/java/util/HashMap.java
! src/share/classes/java/util/Map.java
! src/share/classes/java/util/concurrent/ConcurrentMap.java
! test/java/util/Map/Defaults.java

hg: jdk8/tl/langtools: 8026936: Initialize LamdbaToMethod lazily and as required

[kumar . x . srinivasan]

Changeset: 31fe30e2deac
Author:ksrini
Date:  2013-10-23 15:45 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31fe30e2deac

8026936: Initialize LamdbaToMethod lazily and as required
Reviewed-by: jjg, rfield
Contributed-by: jan.lah...@oracle.com

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

ProblemList updating request for JDK-7079145: java/net/ipv6tests/UdpTest.java

[Eric Wang]

Hi,

This is a review request to remove the test 
java/net/ipv6tests/UdpTest.java from ProblemList.txt. The test tracked 
by JDK-7079145  is 
hung if linux kernel is 2.6.18.

By upgrading the kernel to higher version 2.6.32, the problem doesn't exist.

Thanks,
Eric

ProblemList updating request for JDK-7079145: java/net/ipv6tests/UdpTest.java

[Eric Wang]

Hi,

This is a review request to remove the test 
java/net/ipv6tests/UdpTest.java from ProblemList.txt. The test tracked 
by JDK-7079145  is 
hung if linux kernel is 2.6.18.

By upgrading the kernel to higher version 2.6.32, the problem doesn't exist.
http://cr.openjdk.java.net/~ewang/7079145/webrev.00/ 



Thanks,
Eric

Re: ProblemList updating request for JDK-7079145: java/net/ipv6tests/UdpTest.java

[Eric Wang]

On 2013/10/24 10:57, Eric Wang wrote:

Hi,

This is a review request to remove the test 
java/net/ipv6tests/UdpTest.java from ProblemList.txt. The test tracked 
by JDK-7079145  is 
hung if linux kernel is 2.6.18.
By upgrading the kernel to higher version 2.6.32, the problem doesn't 
exist.


Thanks,
Eric

Sorry, forgot to update the webrev:
http://cr.openjdk.java.net/~ewang/7079145/webrev.00/ 



Thanks,
Eric

hg: jdk8/tl/jdk: 7122887: JDK ignores Gnome3 proxy settings

[dan . xu]

Changeset: c9562ac9b812
Author:dxu
Date:  2013-10-23 22:30 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9562ac9b812

7122887: JDK ignores Gnome3 proxy settings
Summary: Fix GConf and add to use GProxyResolver to handle network proxy 
resolution
Reviewed-by: chegar

! src/solaris/native/sun/net/spi/DefaultProxySelector.c
! test/java/net/ProxySelector/SystemProxies.java