hg: jdk8/tl/jdk: 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources.
Changeset: 9f8bfdd99129 Author:dfuchs Date: 2013-10-14 10:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f8bfdd99129 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources. Reviewed-by: alanb, psandoz, mchung ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/util/ServiceLoader.java
Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown
On 10/10/2013 21:24, Brian Burkhalter wrote:On 10/10/2013 21:24, Brian
Burkhalter wrote:
:
Assuming that the general idea is correct, there are a few possible
alternatives for a final version for Windows. I am not concerned in this
discussion about picky details including naming which can be fine tuned at the
end.
1) In net_util_mh.c/NET_ThrowUnknownHostExceptionWithGaiError replace
gai_strerror() with FormatMessage().
2) In Inet4AddressImpl.c and Inet6AddressImpl.c replace
NET_ThrowUnknownHostExceptionWithGaiError with NET_ThrowByNameWithLastError
(see net_md_util.c).
3) In net_md_util.c change (line 97 in
http://cr.openjdk.java.net/~bpb/8010371/webrev.3/ version)
{ WSATRY_AGAIN, 0, "Nonauthoritative host not found" },
to
{ WSATRY_AGAIN, "UnknownHostException", "Nonauthoritative host
not found" },
and in Inet4AddressImpl.c and Inet6AddressImpl.c replace
NET_ThrowUnknownHostExceptionWithGaiError with NET_ThrowNew().
4) In NET_ThrowUnknownHostExceptionWithGaiError instead of using gai_strerror() use the
hard-coded error message "Nonauthoritative host not found".
The pros and/or cons for each, respectively, are
1) Most closely matches the Unix version and avoids hard-coded messages.
2) Simple and obviates the need for
NET_ThrowUnknownHostExceptionWithGaiError(), but the exception message has a
different format from the Unix version and contains the error code instead of
an error string.
3) Simple and obviates the need for
NET_ThrowUnknownHostExceptionWithGaiError(), but the exception message format
is slightly different from the Unix version and the change could have the
undesirable (and unpredictable) side effect of an UnknownHostException being
thrown somewhere else where a SocketException used to be thrown.
4) Simplest option but has distasteful hard-coding (as do option 3 indirectly
and NET_ThrowNew() for that matter).
If the "con" of option 2 is acceptable then I think that would be the best way
to go, otherwise option 1.
Option #2 seems reasonable, the exception messages for similar network
conditions are rarely the same on Windows and Unix anyway. However I
think it's important to have verified it with one or two errors to be
confident that the errors translate as expected.
One other thing to add is that winsock_errors dates from early versions
of Windows whether there wasn't a means to translate Windows Sockets
errors. We should look at eliminating it (not for JDK 8 of course, it's
too late) so that all errors are handle translated consistently.
-Alan
hg: jdk8/tl/jaxp: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc
Changeset: de8c803d4958 Author:aefimov Date: 2013-10-13 13:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/de8c803d4958 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc Reviewed-by: alanb, shade ! src/com/sun/org/apache/xpath/internal/XPathContext.java
Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed
I'm really not sure that the effort this test is going to is really necessary here ( to verify such a minor leak ). I'd be happy to see the test simply removed. Other opinions? -Chris. On 11/10/2013 20:24, Ivan Gerasimov wrote: On 10.10.2013 15:52, Ivan Gerasimov wrote: Hi Chris! I've run the test on JPRT and it took 84, 99 and 146 seconds on three different machines. When I run it locally in the virtualbox, it takes approximately 300 seconds. Please note that even though the number of iterations was increased by 3.5 times, now only one NetworkInterface is accessed during one iteration. Not 3.5, but of course 14 times. Silly arithmetic mistake. However the rest remains true. So on systems with many network interfaces the total time should even be less than before. Nevertheless I doubled the timeout. Sincerely yours, Ivan On 09.10.2013 19:57, Chris Hegarty wrote: Do you have a sense of how long this test runs for, on an average machine, with the extra iterations? -Chris. On 09/10/2013 09:24, Ivan Gerasimov wrote: Hello all! The MemLeakTest had been added with the fix for 8022584. Since that, the test was reported to fail intermittently, even though the leak was eliminated. I couldn't ever reproduce the failure even on the machines where the failure was detected. Here are the changes I propose: - Increase number of both warm-up and measured iterations, - Number of iterations now indicates how many times a single interface is probed. It used to probe all the interfaces that many times. - Increase the memory consumption threshold - Increase the timeout These should add some confidence that the failure of the test really indicates a memory leak. In addition to that, in the case of a failure the list of all the network interfaces is displayed, so there will be some more information about the environment. Here is the webrev: http://cr.openjdk.java.net/~igerasim/8023390/0/webrev/ Sincerely yours, Ivan Gerasimov
hg: jdk8/tl/jdk: 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost
Changeset: 077237e4613f Author:tyan Date: 2013-10-14 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077237e4613f 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost Reviewed-by: chegar, alanb ! test/java/net/Socks/SocksProxyVersion.java
hg: jdk8/tl/jaxp: 4 new changesets
Changeset: d69f4ac43d64 Author:lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d69f4ac43d64 Merge Changeset: cdc3577cba0b Author:lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cdc3577cba0b Merge Changeset: 4712979714d1 Author:lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4712979714d1 Merge Changeset: 91ae0f2045bc Author:lana Date: 2013-10-14 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/91ae0f2045bc Merge
hg: jdk8/tl/nashorn: 3 new changesets
Changeset: 3551855c4f40 Author:lana Date: 2013-10-08 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3551855c4f40 Merge - make/java.security.override Changeset: b48b719c5efc Author:lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b48b719c5efc Merge - make/java.security.override Changeset: 1b0a71a9920a Author:lana Date: 2013-10-11 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1b0a71a9920a Merge
hg: jdk8/tl/langtools: 3 new changesets
Changeset: 4dfcf3a6902f Author:lana Date: 2013-10-08 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dfcf3a6902f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: 2f43529df42f Author:lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2f43529df42f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: f329c374da4b Author:lana Date: 2013-10-11 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f329c374da4b Merge
hg: jdk8/tl/jaxws: 3 new changesets
Changeset: 1d6c13d3b8de Author:lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1d6c13d3b8de Merge Changeset: 7c0a7937f6ef Author:lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7c0a7937f6ef Merge Changeset: 328b8b96773b Author:lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/328b8b96773b Merge
hg: jdk8/tl: 3 new changesets
Changeset: 7c0e2fd8be4d Author:lana Date: 2013-10-08 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7c0e2fd8be4d Merge Changeset: 3ece65f23ed2 Author:lana Date: 2013-10-11 00:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3ece65f23ed2 Merge Changeset: d35943431696 Author:lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d35943431696 Merge
hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly
Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out
Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown
On Oct 14, 2013, at 1:58 AM, Alan Bateman wrote: >> 2) In Inet4AddressImpl.c and Inet6AddressImpl.c replace >> NET_ThrowUnknownHostExceptionWithGaiError with NET_ThrowByNameWithLastError >> (see net_md_util.c). >> >> […] >> >> If the "con" of option 2 is acceptable then I think that would be the best >> way to go, otherwise option 1. >> > Option #2 seems reasonable, the exception messages for similar network > conditions are rarely the same on Windows and Unix anyway. Here's the patch updated for this option: http://cr.openjdk.java.net/~bpb/8010371/webrev.4/ > However I think it's important to have verified it with one or two errors to > be confident that the errors translate as expected. I can do this if we are actually going with this change for JDK 8. > One other thing to add is that winsock_errors dates from early versions of > Windows whether there wasn't a means to translate Windows Sockets errors. We > should look at eliminating it (not for JDK 8 of course, it's too late) so > that all errors are handle translated consistently. See https://bugs.openjdk.java.net/browse/JDK-4842142. Brian
hg: jdk8/tl/jdk: 63 new changesets
Changeset: 8a041011b6e6 Author:jgodinez Date: 2013-09-27 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a041011b6e6 6870661: Setting a custom PrintService on a PrinterJob leads to a PrinterException Reviewed-by: prr, jgodinez Contributed-by: patr...@reini.net ! src/windows/classes/sun/awt/windows/WPrinterJob.java + test/java/awt/print/PrinterJob/CustomPrintService/PrintDialog.java + test/java/awt/print/PrinterJob/CustomPrintService/PrintServiceStub.java + test/java/awt/print/PrinterJob/CustomPrintService/SetPrintServiceTest.java Changeset: 31b8d4931a09 Author:prr Date: 2013-09-27 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31b8d4931a09 8020190: Fatal: Bug in native code: jfieldID must match object Reviewed-by: jgodinez, vadim ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/native/sun/font/freetypeScaler.c Changeset: 6ef33b4553a4 Author:vadim Date: 2013-09-30 12:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ef33b4553a4 8001119: [fingbugs] Evaluate necessity to make some arrays package protected Reviewed-by: prr, bae + src/share/classes/com/sun/imageio/plugins/bmp/BMPCompressionTypes.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPConstants.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPMetadata.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFStreamMetadata.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/share/classes/javax/imageio/plugins/bmp/BMPImageWriteParam.java Changeset: e2604b873b36 Author:prr Date: 2013-10-01 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2604b873b36 8007386: On physical machine (video card is Intel Q45) the text is blank. Reviewed-by: prr, jchen ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 96ff58f4 Author:vadim Date: 2013-10-02 10:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/96ff58f4 8024343: Change different color with the "The XOR alternation color" combobox, the color of the image can not shown immediately. Reviewed-by: ceisserer, prr, bae ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java + test/sun/java2d/AcceleratedXORModeTest.java Changeset: 5f3d984d8207 Author:prr Date: 2013-10-02 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f3d984d8207 8025837: Extraneous changes in the fix for 8007386 Reviewed-by: jgodinez, jchen ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: f53aeb3c7eed Author:prr Date: 2013-10-02 11:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f53aeb3c7eed 7179526: xrender : closed/sun/java2d/volatileImage/LineClipTest.java failed since jdk8b36 Reviewed-by: prr, jchen ! src/solaris/classes/sun/java2d/xr/GrowableRectArray.java ! src/solaris/classes/sun/java2d/xr/MaskTile.java ! src/solaris/classes/sun/java2d/xr/MaskTileManager.java + src/solaris/classes/sun/java2d/xr/XRDrawLine.java ! src/solaris/classes/sun/java2d/xr/XRRenderer.java + test/java/awt/Graphics/LineClipTest.java Changeset: a15cad0e12d3 Author:bae Date: 2013-10-03 11:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a15cad0e12d3 8022632: Reading a PNG file fails because of WBMPImageReaderSpi.canDecodeInput() Reviewed-by: prr, jgodinez ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReaderSpi.java + test/javax/imageio/plugins/wbmp/StreamResetTest.java Changeset: 2f11a00279ec Author:jchen Date: 2013-10-03 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f11a00279ec 8025280: [parfait] warnings from b107 for jdk.src.share.native.sun.java2d.loops: JNI exception pending, JNI critical region violation Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/loops/Blit.c ! src/share/native/sun/java2d/loops/BlitBg.c ! src/share/native/sun/java2d/loops/DrawPath.c ! src/share/native/sun/java2d/loops/DrawPolygons.c ! src/share/native/sun/java2d/loops/FillPath.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.c ! src/share/native/sun/java2d/loops/MaskBlit.c ! src/share/native/sun/java2d/loops/MaskFill.c ! src/share/native/sun/java2d/loops/ScaledBlit.c ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: e88d39b110dd Author:jchen Date: 2013-10-03 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e88d39b110dd 8025480: [parfait] "JNI exception pending" warnings from b107 for jdk.src.share.native.sun.java2d Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/Disposer.c ! src/share/native/sun/java2d/SurfaceData.c Changeset: 3c1b13ad0677 Author:jchen Date: 2013-10-03 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1b13ad0677 8025309: [parfait] JNI-related w
hg: jdk8/tl/langtools: 8014016: javac is too late detecting invalid annotation usage
Changeset: 87b5bfef7edb Author:jlahoda Date: 2013-10-14 22:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87b5bfef7edb 8014016: javac is too late detecting invalid annotation usage Summary: Adding new queue to Annotate for validation tasks, performing annotation validation during enter Reviewed-by: jjg, emc, jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/GenerateFunctionalInterface.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/GenerateSuperInterfaceProcessor.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/Processor.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/Source.java
hg: jdk8/tl/jdk: 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI
Changeset: dd0deeb04933 Author:michaelm Date: 2013-10-14 22:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd0deeb04933 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI Reviewed-by: alanb, chegar + src/share/classes/java/net/HostPortrange.java ! src/share/classes/java/net/HttpURLConnection.java - src/share/classes/java/net/HttpURLPermission.java + src/share/classes/java/net/URLPermission.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 + test/java/net/URLPermission/URLPermissionTest.java + test/java/net/URLPermission/URLTest.java + test/java/net/URLPermission/policy.1 + test/java/net/URLPermission/policy.2 + test/java/net/URLPermission/policy.3
hg: jdk8/tl/langtools: 8026371: "tidy" issues in langtools/src/**/*.html files
Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/com/sun/javadoc/package.html + src/share/classes/com/sun/tools/classfile/package-info.java - src/share/classes/com/sun/tools/classfile/package.html + src/share/classes/com/sun/tools/doclets/formats/html/markup/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/markup/package.html + src/share/classes/com/sun/tools/doclets/formats/html/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package.html + src/share/classes/com/sun/tools/doclets/package-info.java - src/share/classes/com/sun/tools/doclets/package.html + src/share/classes/com/sun/tools/javap/package-info.java - src/share/classes/com/sun/tools/javap/package.html ! src/share/classes/javax/lang/model/overview.html ! src/share/classes/javax/tools/overview.html
hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail
Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java + test/tools/javadoc/8025693/Test.java
hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies
Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java
