RFR: JDK-8024675 - java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows
Hi please oblige and review the webrev below which addresses the issue problem: https://bugs.openjdk.java.net/browse/JDK-8024675 webrev: http://cr.openjdk.java.net/~msheppar/8024675/webrev/ The test has been amended to only consider NetworkInterfaces that are active (i.e. isUp() == true) and have a configured MAC address when building the test's NetworkInterface list. Previously, the test list was constructed from interface with a configured MAC address. It was found during testing that some Windows configuration have tunnel adapters configured with the same MAC address. These were found to be inactive. It is assumed that neither can be simultaneously active. regards Mark
Re: RFR: JDK-8024675 - java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows
On 13/09/2013 11:46, Mark Sheppard wrote: Hi please oblige and review the webrev below which addresses the issue problem: https://bugs.openjdk.java.net/browse/JDK-8024675 webrev: http://cr.openjdk.java.net/~msheppar/8024675/webrev/ The test has been amended to only consider NetworkInterfaces that are active (i.e. isUp() == true) and have a configured MAC address when building the test's NetworkInterface list. Previously, the test list was constructed from interface with a configured MAC address. It was found during testing that some Windows configuration have tunnel adapters configured with the same MAC address. These were found to be inactive. It is assumed that neither can be simultaneously active. Skipping the interfaces that aren't "up" seems right so looks okay to me. I'm not sure why the .println ended up on its own line, I wonder if that should be fixed while you are there. -Alan
Re: RFR: JDK-8024675 - java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows
On 13/09/2013 11:52, Alan Bateman wrote: On 13/09/2013 11:46, Mark Sheppard wrote: Hi please oblige and review the webrev below which addresses the issue problem: https://bugs.openjdk.java.net/browse/JDK-8024675 webrev: http://cr.openjdk.java.net/~msheppar/8024675/webrev/ The test has been amended to only consider NetworkInterfaces that are active (i.e. isUp() == true) and have a configured MAC address when building the test's NetworkInterface list. Previously, the test list was constructed from interface with a configured MAC address. It was found during testing that some Windows configuration have tunnel adapters configured with the same MAC address. These were found to be inactive. It is assumed that neither can be simultaneously active. Skipping the interfaces that aren't "up" seems right so looks okay to me. I'm not sure why the .println ended up on its own line, I wonder if that should be fixed while you are there. +1. Otherwise fine. I can sponsor this change for you Mark. -Chris. -Alan
hg: jdk8/tl/jdk: 8024009: Remove jdk.map.useRandomSeed system property
Changeset: cc2bae7f8fbb Author:bchristi Date: 2013-09-12 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc2bae7f8fbb 8024009: Remove jdk.map.useRandomSeed system property Summary: Removed usage of hashSeed in Hashtable & WeakHashMap, and removed tests Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/WeakHashMap.java - test/java/util/Map/CheckRandomHashSeed.java ! test/java/util/Map/Collisions.java
hg: jdk8/tl/jdk: 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows
Changeset: c53411f89b4c Author:msheppar Date: 2013-09-13 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c53411f89b4c 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows Summary: amended test to add active, i.e. isUp(), NetworkInterfaces to test list Reviewed-by: alanb, chegar ! test/java/net/NetworkInterface/UniqueMacAddressesTest.java
Re: RFR: 7180557 - InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX
Hi folks, updated webrev at: http://cr.openjdk.java.net/~robm/7180557/webrev.02/ Hopefully all of your concerns have been addressed. W.r.t. the use of AI_CANONNAME, this doesn't actually make a difference in the context of this fix, but is definitely something that should be looked at. I'll put it on the todo list. -Rob On 05/09/13 21:33, Dmitry Samersoff wrote: Rob, Did you try to remove hints.ai_flags = AI_CANONNAME this flag asks getaddreinfo to return FQDN, but the function behavior is not clearly defined for the case where FQDN is not available. -Dmitry On 2013-09-03 19:18, Rob McKenna wrote: Hi folks, Mac seems to have trouble looking up local hostnames using getaddrinfo unless a domain is set. The solution is to add a check with getifaddrs . This fix replaces a usage of _ALLBSD_SOURCE with MACOSX. I haven't seen a canonical answer on whether this is the way to go so I figured trial by fire might get the discussion going. http://cr.openjdk.java.net/~robm/7180557/webrev.01/ -Rob
Re: RFR: 7180557 - InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX
Am 13.09.2013, 19:32 Uhr, schrieb Rob McKenna : W.r.t. the use of AI_CANONNAME, this doesn't actually make a difference in the context of this fix, but is definitely something that should be looked at. I'll put it on the todo list. I think it does make a difference: If you remove the CANON flag getaddrinfo() will not do DNS lookups when the host is configured to prefer the hosts file (which it should do on Linux and OSX). And so the platform specific lookupIfLocalhost() can be put after the getaddrinfo() (again). I actually think the bug "exists" on all platforms. If getaddrinfo() fails because neighter hosts nor DNS file finds the name this can happen on all platforms. I dont think it helps to add a fallback only on MACOSX (and there is certainly no need to prefer the fallback then). Gruss Bernd
hg: jdk8/tl/jdk: 3 new changesets
Changeset: c65848f2b6a1 Author:mduigou Date: 2013-09-13 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c65848f2b6a1 8021591: Additional explicit null checks Reviewed-by: psandoz, alanb ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/javax/security/auth/Subject.java ! test/java/util/Collection/CollectionDefaults.java - test/java/util/Collection/ListDefaults.java ! test/java/util/Collection/MOAT.java ! test/java/util/Collection/testlibrary/CollectionAsserts.java ! test/java/util/Collection/testlibrary/CollectionSupplier.java + test/java/util/Collection/testlibrary/ExtendsAbstractCollection.java + test/java/util/Collection/testlibrary/ExtendsAbstractList.java + test/java/util/Collection/testlibrary/ExtendsAbstractSet.java + test/java/util/List/ListDefaults.java ! test/java/util/Map/Defaults.java Changeset: 973fdd9506b2 Author:mduigou Date: 2013-09-13 11:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/973fdd9506b2 8024014: TEST.groups - split sub-groups for jdk_collections, jdk_stream, jdk_concurrent, jdk_util_other from jdk_util Reviewed-by: mchung, dholmes, alanb ! test/TEST.groups Changeset: 5f81a12fed4d Author:bchristi Date: 2013-09-13 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f81a12fed4d 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] Summary: On MacOS X set user.home to value of NSHomeDirectory() Reviewed-by: alanb, ddehaven, mduigou ! make/common/Defs-macosx.gmk ! make/java/java/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/solaris/native/java/lang/java_props_macosx.c ! src/solaris/native/java/lang/java_props_macosx.h ! src/solaris/native/java/lang/java_props_md.c
hg: jdk8/tl: 8024201: Update bugdatabase url
Changeset: 67f64101616e Author:mduigou Date: 2013-09-13 12:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/67f64101616e 8024201: Update bugdatabase url Reviewed-by: wetmore ! make/scripts/webrev.ksh
Re: RFR: 7180557 - InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX
Hi Bernd, I should have said in the context of this bug. What I meant was removing AI_CANONNAME doesn't resolve the issue as far as Mac is concerned. I.e. I still see the UnknownHostException. In this particular case the hostname is not set via the hosts file. In the latest webrev the call to getifaddrs only occurs if getaddrinfo fails. -Rob On 13/09/13 20:28, Bernd Eckenfels wrote: Am 13.09.2013, 19:32 Uhr, schrieb Rob McKenna : W.r.t. the use of AI_CANONNAME, this doesn't actually make a difference in the context of this fix, but is definitely something that should be looked at. I'll put it on the todo list. I think it does make a difference: If you remove the CANON flag getaddrinfo() will not do DNS lookups when the host is configured to prefer the hosts file (which it should do on Linux and OSX). And so the platform specific lookupIfLocalhost() can be put after the getaddrinfo() (again). I actually think the bug "exists" on all platforms. If getaddrinfo() fails because neighter hosts nor DNS file finds the name this can happen on all platforms. I dont think it helps to add a fallback only on MACOSX (and there is certainly no need to prefer the fallback then). Gruss Bernd
hg: jdk8/tl/jdk: 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null
Changeset: 5c7690923663 Author:lancea Date: 2013-09-13 19:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java
