hg: jdk8/tl/jdk: 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X
Changeset: 779ff9f3b2e3 Author:sla Date: 2013-08-29 11:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/779ff9f3b2e3 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes ! src/share/back/SDE.c ! src/share/native/common/check_code.c
[JDK 8] Code review request JDK-8023881, IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII
Hi,
Please review the fix of JDK-8023881.
webrev: http://cr.openjdk.java.net/~xuelei/8023881/webrev.00/
This bug has not been ported to bugs.sun.com. The following is the
descirption of the issue.
IDN.toASCII("示例.com", IDN.USE_STD3_ASCII_RULES) throws:
Exception ... java.lang.IllegalArgumentException: Contains non-LDH
characters
at java.net.IDN.toASCIIInternal(IDN.java:275)
at java.net.IDN.toASCII(IDN.java:118)
However, the "idn" tool is able to handle above IDN properly:
$ idn --usestd3asciirules www.示例.com
www.xn--fsq092h.com
Per step 3, section 4.1, RFC 3490:
3. If the UseSTD3ASCIIRules flag is set, then perform these checks:
(a) Verify the absence of non-LDH ASCII code points; that is, the
absence of 0..2C, 2E..2F, 3A..40, 5B..60, and 7B..7F.
(b) Verify the absence of leading and trailing hyphen-minus; that
is, the absence of U+002D at the beginning and end of the
sequence.
However, in the impl of IDN is checking far more strictly than above.
Unicode point bigger than 0x007A is not acceptable. It is too strict to
convert Unicode with IDN.toASCII() if IDN.USE_STD3_ASCII_RULES option is
set.
Thanks,
Xuelei
Re: [JDK 8] Code review request JDK-8023881, IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII
Xuelei,
This looks fine.
I would add a comment to line 408-409 that says something like:
Non LDH refers to characters in the ASCII range, but which
are not letters, digits or the hypen.
That explains what exactly was fixed here.
Michael
On 29/08/13 13:46, Xuelei Fan wrote:
Hi,
Please review the fix of JDK-8023881.
webrev: http://cr.openjdk.java.net/~xuelei/8023881/webrev.00/
This bug has not been ported to bugs.sun.com. The following is the
descirption of the issue.
IDN.toASCII("示例.com", IDN.USE_STD3_ASCII_RULES) throws:
Exception ... java.lang.IllegalArgumentException: Contains non-LDH
characters
at java.net.IDN.toASCIIInternal(IDN.java:275)
at java.net.IDN.toASCII(IDN.java:118)
However, the "idn" tool is able to handle above IDN properly:
$ idn --usestd3asciirules www.示例.com
www.xn--fsq092h.com
Per step 3, section 4.1, RFC 3490:
3. If the UseSTD3ASCIIRules flag is set, then perform these checks:
(a) Verify the absence of non-LDH ASCII code points; that is, the
absence of 0..2C, 2E..2F, 3A..40, 5B..60, and 7B..7F.
(b) Verify the absence of leading and trailing hyphen-minus; that
is, the absence of U+002D at the beginning and end of the
sequence.
However, in the impl of IDN is checking far more strictly than above.
Unicode point bigger than 0x007A is not acceptable. It is too strict to
convert Unicode with IDN.toASCII() if IDN.USE_STD3_ASCII_RULES option is
set.
Thanks,
Xuelei
Re: [JDK 8] Code review request JDK-8023881, IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII
On 8/29/2013 10:57 PM, Michael McMahon wrote:
> Xuelei,
>
> This looks fine.
>
> I would add a comment to line 408-409 that says something like:
>
> Non LDH refers to characters in the ASCII range, but which
> are not letters, digits or the hypen.
>
I will add the comment. Thanks for the quick code review.
Xuelei
> That explains what exactly was fixed here.
>
> Michael
>
> On 29/08/13 13:46, Xuelei Fan wrote:
>> Hi,
>>
>> Please review the fix of JDK-8023881.
>>
>> webrev: http://cr.openjdk.java.net/~xuelei/8023881/webrev.00/
>>
>> This bug has not been ported to bugs.sun.com. The following is the
>> descirption of the issue.
>>
>>
>> IDN.toASCII("示例.com", IDN.USE_STD3_ASCII_RULES) throws:
>>
>> Exception ... java.lang.IllegalArgumentException: Contains non-LDH
>> characters
>> at java.net.IDN.toASCIIInternal(IDN.java:275)
>> at java.net.IDN.toASCII(IDN.java:118)
>>
>> However, the "idn" tool is able to handle above IDN properly:
>> $ idn --usestd3asciirules www.示例.com
>> www.xn--fsq092h.com
>>
>> Per step 3, section 4.1, RFC 3490:
>>
>> 3. If the UseSTD3ASCIIRules flag is set, then perform these checks:
>>
>> (a) Verify the absence of non-LDH ASCII code points; that is, the
>> absence of 0..2C, 2E..2F, 3A..40, 5B..60, and 7B..7F.
>>
>> (b) Verify the absence of leading and trailing hyphen-minus; that
>> is, the absence of U+002D at the beginning and end of the
>> sequence.
>>
>> However, in the impl of IDN is checking far more strictly than above.
>> Unicode point bigger than 0x007A is not acceptable. It is too strict to
>> convert Unicode with IDN.toASCII() if IDN.USE_STD3_ASCII_RULES option is
>> set.
>>
>>
>> Thanks,
>> Xuelei
>
hg: jdk8/tl/jdk: 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links
Changeset: 5bf4f285 Author:dxu Date: 2013-08-29 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf4f285 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links Summary: Exclude the possible usage of linked files or directories in the test Reviewed-by: alanb ! test/java/io/pathNames/General.java
hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate
Changeset: 0e6577980181 Author:jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SimpleDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java
hg: jdk8/tl/langtools: 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only
Changeset: b0b25c1f6cbd Author:jjg Date: 2013-08-29 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0b25c1f6cbd 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Reviewed-by: darcy ! test/tools/javac/tree/TypeAnnotationsPretty.java
hg: jdk8/tl/langtools: 8013384: Potential infinite loop in javadoc
Changeset: 9c0e192c0926 Author:jjg Date: 2013-08-29 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c0e192c0926 8013384: Potential infinite loop in javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java
hg: jdk8/tl/langtools: 8022744: javac -Xpkginfo command's documentation is sparse
Changeset: 96b6865eda94 Author:jjg Date: 2013-08-29 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96b6865eda94 8022744: javac -Xpkginfo command's documentation is sparse Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java
hg: jdk8/tl: 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output.
Changeset: 51a61778a99d Author:mduigou Date: 2013-08-29 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/51a61778a99d 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output. Reviewed-by: erikj, vromero, henryjen ! test/Makefile
hg: jdk8/tl/langtools: 8023833: Replace direct use of AnnotatedType in javadoc code
Changeset: 23f0f3c9c44a Author:jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java
hg: jdk8/tl/jdk: 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII
Changeset: cdf68747b0fb Author:xuelei Date: 2013-08-29 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf68747b0fb 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII Reviewed-by: michaelm ! src/share/classes/java/net/IDN.java + test/java/net/IDN/UseSTD3ASCIIRules.java
