hg: jdk8/tl/jdk: 8021108: Clean up doclint warnings and errors in java.text package
Changeset: 6cc15a808b93 Author:peytoia Date: 2013-07-26 17:22 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc15a808b93 8021108: Clean up doclint warnings and errors in java.text package Reviewed-by: darcy, okutsu ! src/share/classes/java/text/Annotation.java ! src/share/classes/java/text/AttributedCharacterIterator.java ! src/share/classes/java/text/Bidi.java ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/CollationKey.java ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/FieldPosition.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/Normalizer.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/ParseException.java ! src/share/classes/java/text/ParsePosition.java ! src/share/classes/java/text/RuleBasedCollator.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/text/StringCharacterIterator.java
Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails
Hi Kurchi,
i looked into the change. Today i did run it a few time and it allays
worked. The logic looks straight forward to me.
I would only improve indenting and the try - autoclose for the Server.
The startServer() can be implemented in the constructor. The
server.close() in the exept() method is not required due to the
autoclose and this saves a few parameters here and there.
cheers
Andreas
Here my diff on your patch change:
diff --git a/test/java/net/Authenticator/B4769350.java
b/test/java/net/Authenticator/B4769350.java
--- a/test/java/net/Authenticator/B4769350.java
+++ b/test/java/net/Authenticator/B4769350.java
@@ -55,7 +55,7 @@
}
}
- static class Client extends Thread {
+static class Client extends Thread {
String authority, path;
boolean allowerror;
@@ -74,7 +74,7 @@
InputStream is = urlc.getInputStream();
read (is);
is.close();
-} catch (URISyntaxException e) {
+} catch (URISyntaxException e) {
System.out.println (e);
error = true;
} catch (IOException e) {
@@ -94,11 +94,7 @@
CyclicBarrier t1Cond1;
CyclicBarrier t1Cond2;
-public String getAddress() {
-return server.getAddress().getHostName();
-}
-
-public void startServer() {
+public Server() {
InetSocketAddress addr = new InetSocketAddress(0);
try {
@@ -131,6 +127,10 @@
server.start();
}
+public String getAddress() {
+return server.getAddress().getHostName();
+}
+
public int getPort() {
return server.getAddress().getPort();
}
@@ -143,9 +143,10 @@
}
/* T1 tests the client by sending 4 requests to 2 different realms
- * in parallel. The client should recognise two pairs of
dependent requests
- * and execute the first of each pair in parallel. When they
both succeed
- * the second requests should be executed without calling the
authenticator.
+ * in parallel. The client should recognise two pairs of dependent
+ * requests and execute the first of each pair in parallel.
When they
+ * both succeed the second requests should be executed without
calling
+ * the authenticator.
* The test succeeds if the authenticator was only called twice.
*/
class AuthenticationHandlerT1a implements HttpHandler
@@ -171,11 +172,9 @@
default:
System.out.println ("Unexpected request");
}
-} catch (InterruptedException |
- BrokenBarrierException e)
-{
-throw new RuntimeException(e);
-}
+} catch (InterruptedException | BrokenBarrierException e) {
+throw new RuntimeException(e);
+}
}
}
@@ -270,10 +269,9 @@
}
}
-/* T2 tests to check that if initial authentication fails, the
second will
- * succeed, and the authenticator is called twice
+/* T2 tests to check that if initial authentication fails, the
second
+ * will succeed, and the authenticator is called twice
*/
-
class AuthenticationHandlerT2a implements HttpHandler
{
volatile int count = -1;
@@ -287,11 +285,10 @@
}
AuthenticationHandler.errorReply(exchange,
"Basic realm=\"realm3\"");
-
}
}
- class AuthenticationHandlerT2b implements HttpHandler
+class AuthenticationHandlerT2b implements HttpHandler
{
volatile int count = -1;
@@ -316,7 +313,6 @@
* resource at same time. Authenticator should be called once
for server
* and once for proxy
*/
-
class AuthenticationHandlerT3a implements HttpHandler
{
volatile int count = -1;
@@ -423,11 +419,10 @@
int f = auth.getCount();
if (f != 2) {
-except ("Authenticator was called "+f+" times. Should be 2",
-server);
+except ("Authenticator was called "+f+" times. Should be 2");
}
if (error) {
-except ("error occurred", server);
+except ("error occurred");
}
auth.resetCount();
@@ -444,10 +439,10 @@
f = auth.getCount();
if (f != redirects+1) {
except ("Authenticator was called "+f+" times. Should be: "
-+ redirects+1, server);
++ redirects+1);
}
if (error) {
-except ("error occurred", server);
+except ("error occurred");
}
}
@@ -466,11 +461,
hg: jdk8/tl/nashorn: 4 new changesets
Changeset: 10503ced6cc2 Author:cl Date: 2013-07-18 03:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10503ced6cc2 Added tag jdk8-b99 for changeset 10a1ab9e20a4 ! .hgtags Changeset: 598321c438b5 Author:lana Date: 2013-07-22 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/598321c438b5 Merge - src/jdk/nashorn/internal/ir/ExecuteNode.java - test/script/currently-failing/JDK-8006529.js Changeset: a302b05d0ee4 Author:cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a302b05d0ee4 Added tag jdk8-b100 for changeset 598321c438b5 ! .hgtags Changeset: d55856f82352 Author:lana Date: 2013-07-26 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d55856f82352 Merge
hg: jdk8/tl/langtools: 5 new changesets
Changeset: 6d85acab769e Author:mcimadamore Date: 2013-07-17 19:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d85acab769e 8013638: Few policy tests are failing in Lambda nightly Summary: BridgeHarness test is leaving files open Reviewed-by: ksrini ! test/tools/javac/generics/bridges/BridgeHarness.java Changeset: e73f00139fb5 Author:cl Date: 2013-07-18 03:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e73f00139fb5 Added tag jdk8-b99 for changeset 6d85acab769e ! .hgtags Changeset: 82f68da70e47 Author:lana Date: 2013-07-22 17:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82f68da70e47 Merge - test/tools/javac/generics/6723444/T6723444.out - test/tools/javac/generics/7015430/T7015430.out Changeset: 0324dbf07b0f Author:cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0324dbf07b0f Added tag jdk8-b100 for changeset 82f68da70e47 ! .hgtags Changeset: 37048aa3ac19 Author:lana Date: 2013-07-26 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37048aa3ac19 Merge
hg: jdk8/tl/hotspot: 15 new changesets
Changeset: dc8afa03e5c9 Author:katleman Date: 2013-07-11 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc8afa03e5c9 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/runtime/8001071/Test8001071.sh Changeset: 1c474723a324 Author:katleman Date: 2013-07-11 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1c474723a324 Merge Changeset: 81b6cb70717c Author:katleman Date: 2013-07-16 15:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81b6cb70717c Merge Changeset: bb416ee2a79b Author:cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bb416ee2a79b Added tag jdk8-b99 for changeset 81b6cb70717c ! .hgtags Changeset: bd1dc81da579 Author:amurillo Date: 2013-07-12 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd1dc81da579 8020382: new hotspot build - hs25-b42 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f4311079200c Author:brutisso Date: 2013-07-11 11:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f4311079200c 8020155: PSR:PERF G1 not collecting old regions when humongous allocations interfer Summary: Take _last_young_gc into account when deciding on starting a concurrent mark. Also reviewed-by: per.li...@oracle.com. Reviewed-by: tschatzl, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: e7a47f226600 Author:tamao Date: 2013-07-15 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e7a47f226600 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: 980532a806a5 Author:goetz Date: 2013-06-20 15:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/980532a806a5 8016697: Use stubs to implement safefetch Summary: Implement Safefetch as stub routines. This reduces compiler and os dependencies. Reviewed-by: twisti, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/bsd_x86_32.s ! src/os_cpu/bsd_x86/vm/bsd_x86_64.s ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/linux_sparc.s ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/linux_x86/vm/linux_x86_64.s ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_64.s ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: a74ec8831c7b Author:clucasius Date: 2013-07-15 12:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a74ec8831c7b Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp Changeset: 16b10327b00d Author:jprovino Date: 2013-07-16 10:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/16b10327b00d 8011569: ARM -- avoid native stack walking Summary: ARM compilers do not emit FramePointer on each native frame by default Reviewed-by: dholmes, zgu ! make/linux/makefiles/vm.make ! src/share/vm/services/memTracker.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 90d6c221d4e5 Author:jprovino Date: 2013-07-16 12:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/90d6c221d4e5 Merge ! make/linux/makefiles/vm.make - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp ! src/share/vm/services/memTracker.cpp - src/share/vm/trace/traceEventTypes.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9d18d92e54b5 Author:clucasius Date: 2013-07-18 00:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d18d92e54b5 Merge Changeset: 9f71e36a471a Author:amurillo Date: 2013-07-18 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f71e36a471a Merge Changeset: 5787fac72e76 Author:amurillo Date: 2013-07-18 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5787fac72e76 Added tag hs25-b42 for changeset 9f71e36a471a ! .hgtags Changeset: 9d7b55c8a0c4 Author:cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d7b55c8a0c4 Added tag jdk8-b100 for changeset 5787fac72e76 ! .hgtags
hg: jdk8/tl/jaxp: 4 new changesets
Changeset: 043da456d316 Author:cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/043da456d316 Added tag jdk8-b99 for changeset adf49c3ef83c ! .hgtags Changeset: 5d1974c1d7b9 Author:lana Date: 2013-07-22 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5d1974c1d7b9 Merge Changeset: 0a7432f898e5 Author:cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0a7432f898e5 Added tag jdk8-b100 for changeset 5d1974c1d7b9 ! .hgtags Changeset: 467e1948612d Author:lana Date: 2013-07-26 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/467e1948612d Merge
hg: jdk8/tl/jaxws: 2 new changesets
Changeset: 4fd722afae5c Author:cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/4fd722afae5c Added tag jdk8-b99 for changeset 8ef83d4b23c9 ! .hgtags Changeset: 60b623a36164 Author:cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/60b623a36164 Added tag jdk8-b100 for changeset 4fd722afae5c ! .hgtags
hg: jdk8/tl/corba: 2 new changesets
Changeset: 8d492f1dfd1b Author:cl Date: 2013-07-18 03:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8d492f1dfd1b Added tag jdk8-b99 for changeset 3f67804ab613 ! .hgtags Changeset: a013024b0747 Author:cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a013024b0747 Added tag jdk8-b100 for changeset 8d492f1dfd1b ! .hgtags
hg: jdk8/tl: 2 new changesets
Changeset: d2dcb110e9db Author:cl Date: 2013-07-18 03:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d2dcb110e9db Added tag jdk8-b99 for changeset 59dc9da81379 ! .hgtags Changeset: 9f74a220677d Author:cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9f74a220677d Added tag jdk8-b100 for changeset d2dcb110e9db ! .hgtags
hg: jdk8/tl/jdk: 26 new changesets
Changeset: 56bc019a0525 Author:katleman Date: 2013-07-11 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56bc019a0525 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/sun/security/krb5/auto/NoneReplayCacheTest.java Changeset: 030d1ca7432f Author:katleman Date: 2013-07-11 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/030d1ca7432f Merge Changeset: 6a099a36589b Author:katleman Date: 2013-07-16 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a099a36589b Merge Changeset: 9b6070690e50 Author:cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b6070690e50 Added tag jdk8-b99 for changeset 6a099a36589b ! .hgtags Changeset: cacfc77655c8 Author:serb Date: 2013-07-03 19:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cacfc77655c8 8004859: Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform Reviewed-by: prr, flar ! src/share/classes/sun/java2d/SunGraphics2D.java + test/java/awt/Graphics2D/Test8004859/Test8004859.java Changeset: 75844b444879 Author:jchen Date: 2013-07-03 10:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75844b444879 8014497: [parfait] Potential null pointer dereference in jdk/src/share/native/sun/java2d/cmm/lcms/cmsgamma.c Reviewed-by: bae, prr ! src/share/native/sun/java2d/cmm/lcms/cmsopt.c Changeset: d32757b7060c Author:lana Date: 2013-07-05 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d32757b7060c Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: dead66347eca Author:jgodinez Date: 2013-07-10 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dead66347eca 8016737: After clicking on "Print UNCOLLATED" button, the print out come in order 'Page 1', 'Page 2', 'Page 1' Reviewed-by: jchen, prr ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: fab003d2 Author:lana Date: 2013-07-17 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fab003d2 Merge Changeset: f41758d12409 Author:alitvinov Date: 2013-07-04 16:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f41758d12409 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java ! src/solaris/native/sun/awt/awt_util.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c Changeset: 523815540788 Author:lana Date: 2013-07-05 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/523815540788 Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: b7cbad879d63 Author:leonidr Date: 2013-07-08 19:47 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7cbad879d63 8019265: [macosx] apple.laf.useScreenMenuBar regression comparing with jdk6 Reviewed-by: anthony ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 7e291fc61cad Author:malenkov Date: 2013-07-09 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e291fc61cad 6707231: Wrong read Method returned for boolen properties Reviewed-by: alexsch ! src/share/classes/java/beans/Introspector.java + test/java/beans/Introspector/Test6707231.java Changeset: e7ca6e259dc2 Author:serb Date: 2013-07-09 21:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7ca6e259dc2 8019587: [macosx] Possibility to set the same frame for the different screens Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java + test/java/awt/GraphicsDevice/IncorrectDisplayModeExitFullscreen.java Changeset: 46826d248616 Author:pchelko Date: 2013-07-11 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46826d248616 8020210: [macosx] JVM crashes in CWrapper$NSWi
hg: jdk8/tl/jdk: 8021601: Add unit test for PriorityQueue(Comparator) constructor
Changeset: f056728871f8 Author:mduigou Date: 2013-07-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f056728871f8 8021601: Add unit test for PriorityQueue(Comparator) constructor Reviewed-by: darcy, alanb ! src/share/classes/java/util/PriorityQueue.java ! test/java/util/PriorityQueue/RemoveContains.java
