hg: jdk8/tl/langtools: 8012723: strictfp interface misses strictfp modifer on default method
Changeset: 3c02d2f1a421 Author:vromero Date: 2013-04-26 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c02d2f1a421 8012723: strictfp interface misses strictfp modifer on default method Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/defaultMethods/CheckACC_STRICTFlagOnDefaultMethodTest.java
hg: jdk8/tl/langtools: 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
Changeset: 2ca9e7d50136 Author:vromero Date: 2013-04-26 10:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2ca9e7d50136 8008562: javac, a refactoring to Bits is necessary in order to provide a change history Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/util/Bits.java
Re: RFR-JDK8012108
Looks fine, just a few minor nits 1) unnecessary else L102 of the new file. 2) commented else L145 of the new file. 3) strange indentation L368 - 171 ( new file ) -Chris. On 19/04/2013 22:33, John Zavgren wrote: Greetings: I fixed the bad realloc pattern. Please let me know what you think. http://cr.openjdk.java.net/~jzavgren/8012108/webrev.02/ Thanks! John Z - Original Message - From: chris.hega...@oracle.com To: net-dev@openjdk.java.net, john.zavg...@oracle.com Cc: dmitry.samers...@oracle.com Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR-JDK8012108 On 18/04/2013 22:11, Dmitry Samersoff wrote: John, I see bad realloc pattern here. Could you fix it as well? Yes, please. Otherwise the changes look fine. -Chris. e.g. 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len); -Dmitry On 2013-04-19 00:56, John Zavgren wrote: Greetings: I fixed a case in the windows native code where calloc() was being used without checking it's returned value. http://cr.openjdk.java.net/~jzavgren/8012108/webrev.01/ Thanks! John Zavgren
API change for 8010464: Evolve java networking same origin policy
Hi, The is the suggested API for one of the two new JEPs recently submitted. This is for JEP 184: HTTP URL Permissions The idea here is to define a higher level http permission class which "knows about" URLs, HTTP request methods and headers. So, it is no longer necessary to grant blanket permission for any kind of TCP connection to a host/port. Instead a HttpURLPermission restricts access to only the Http protocol itself. Restrictions can also be imposed based on URL paths, specific request methods and request headers. The API change can be seen at the URL below: http://cr.openjdk.java.net/~michaelm/8010464/api/ In addition to defining a new permission class, HttpURLConnection is modified to make use of it and the documentation change describing this can be seen at the link below: http://cr.openjdk.java.net/~michaelm/8010464/api/blender.html All comments welcome. Thanks Michael.
hg: jdk8/tl/langtools: 8010304: javac should detect all mutable implicit static fields in langtools using a plugin
Changeset: f3f3ac1273e8 Author:vromero Date: 2013-04-26 15:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3f3ac1273e8 8010304: javac should detect all mutable implicit static fields in langtools using a plugin Reviewed-by: jjg ! make/build.xml + make/tools/crules/AbstractCodingRulesAnalyzer.java + make/tools/crules/MutableFieldsAnalyzer.java + make/tools/crules/resources/crules.properties
Re: API change for 8010464: Evolve java networking same origin policy
On 26/04/2013 15:36, Michael McMahon wrote: : The API change can be seen at the URL below: http://cr.openjdk.java.net/~michaelm/8010464/api/ One comment on the "Security permissions" section of HttpURLConnection is that it "caller must have permission" isn't clear. I think it is trying to say that calling any method defined by this class that results in an attempt to establish a connection will require at least one of the permissions listed. Does exiting HTTP protocol handlers (meaning those that aren't included in the JDK) require any consideration? -Alan.
Re: API change for 8010464: Evolve java networking same origin policy
On 26/04/13 16:47, Alan Bateman wrote: On 26/04/2013 15:36, Michael McMahon wrote: : The API change can be seen at the URL below: http://cr.openjdk.java.net/~michaelm/8010464/api/ One comment on the "Security permissions" section of HttpURLConnection is that it "caller must have permission" isn't clear. I think it is trying to say that calling any method defined by this class that results in an attempt to establish a connection will require at least one of the permissions listed. Okay. I'll try to make that more explicit. Does exiting HTTP protocol handlers (meaning those that aren't included in the JDK) require any consideration? Are you referring to handlers that did no security checking previously, or handlers that did check for SocketPermission, but won't know about HttpURLPermission and now won't be compatible? Either way, my preference would be still for it to be mandatory in JDK 8. Thanks Michael. -Alan.
Re: API change for 8010464: Evolve java networking same origin policy
On 26/04/2013 17:02, Michael McMahon wrote: Are you referring to handlers that did no security checking previously, or handlers that did check for SocketPermission, but won't know about HttpURLPermission and now won't be compatible? Either way, my preference would be still for it to be mandatory in JDK 8. I don't know how common it is to set java.protocol.handler.pkgs and deploy your own HTTP protocol handler. It's possible that it is very rare to do this and also run with a security manager. So it's hard to know whether other HTTP protocol handlers work with a security manager or not. My question was just wondering whether we need to account for existing HTTP protocol handler that would be deployed without any knowledge of HttpURLPermission. -Alan.
hg: jdk8/tl/jdk: 8007395: StringIndexOutofBoundsException in Match.find() when input String contains surrogate UTF-16 characters
Changeset: 5144db7f0f88 Author:sherman Date: 2013-04-26 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5144db7f0f88 8007395: StringIndexOutofBoundsException in Match.find() when input String contains surrogate UTF-16 characters Summary: updated GroupCurly.match0() to backtrack correctly Reviewed-by: mchung ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java
hg: jdk8/tl/jdk: 7123493: (proxy) Proxy.getProxyClass doesn't scale under high load
Changeset: 5e7ae178b24d Author:plevart Date: 2013-04-26 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e7ae178b24d 7123493: (proxy) Proxy.getProxyClass doesn't scale under high load Reviewed-by: mchung ! src/share/classes/java/lang/reflect/Proxy.java + src/share/classes/java/lang/reflect/WeakCache.java
