Re: RFR-JDK8012108

[Dmitry Samersoff]

John,

Looks good for me besides some nits:

NetworkInterface.c:

132,208,405: better rearrange if and get rid of extra else
151: occasional space changes
162: //else comment seems redundant for me
408: missed free(tableP)


NetworkInterface_winXP.c:

103: else is redundant
141: { bracket misplaced
146: //else comment seems redundant for me

ResolverConfigurationImpl.c:

130: better rearrange if and get rid of extra else
 free(adapterP) missed

-Dmitry

On 2013-04-25 05:10, John Zavgren wrote:
> All:
> 
> I expanded the scope of the work for this bug and cleaned up other
> realloc() errors in the windows native code. I believe I've identified
> all unsafe calls to realloc() in this corner of the native code.
> 
> Two additional files were affected.
> 
> Please let me know what you think:
> http://cr.openjdk.java.net/~jzavgren/8012108/webrev.03/
> 
> 
> Thanks!
> John
> 
> On 04/20/2013 10:36 AM, Kurchi Subhra Hazra wrote:
>> On Apr 20, 2013, at 4:40 AM, Dmitry Samersoff  
>> wrote:
>>
>>> Kurchi,
>>>
>>> if  *netaddrPP == NULL at 367 and calloc fails at 391 we would jump
>>> to freeAllocatedMemory with start == NULL
>>>
>> True, but then we skip to line 444 since *netaddrPP == NULL, so we don't get 
>> to line 438.
>>
>> I am just saying it is not strictly necessary to check if start is null 
>> before entering the first if block. We might want to guard against how the 
>> code changes in future and put in the check though.
>>
>>
>>> I have no ideas whether this code path is possible in reality or not,
>>> but it stops my eyes.
>>>
>>> -Dmitry
>>>
>>>
>>> On 2013-04-20 14:55, Kurchi Subhra Hazra wrote:
 On Apr 20, 2013, at 3:16 AM, Dmitry Samersoff 
  wrote:

> John,
>
> 102, 145 else is redundant.
>
> 438  - we will crash here if start is null
 Maybe it is good to have an additional check for start != null, but from 
 what I see, start will not be null if *netaddrPP is not null.





> -Dmitry
>
>
> On 2013-04-20 01:33, John Zavgren wrote:
>> Greetings:
>>
>> I fixed the bad realloc pattern. Please let me know what you think.
>> http://cr.openjdk.java.net/~jzavgren/8012108/webrev.02/
>>
>> Thanks!
>> John Z
>>
>>
>> - Original Message -
>> From: chris.hega...@oracle.com
>> To: net-dev@openjdk.java.net, john.zavg...@oracle.com
>> Cc: dmitry.samers...@oracle.com
>> Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern
>> Subject: Re: RFR-JDK8012108
>>
>> On 18/04/2013 22:11, Dmitry Samersoff wrote:
>>> John,
>>>
>>> I see bad realloc pattern here. Could you fix it as well?
>> Yes, please. Otherwise the changes look fine.
>>
>> -Chris.
>>
>>> e.g.
>>>
>>> 93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, 
>>> len);
>>>
>>> -Dmitry
>>>
>>> On 2013-04-19 00:56, John Zavgren wrote:
 Greetings:

 I fixed a case in the windows native code where calloc() was being used
 without checking it's returned value.

 http://cr.openjdk.java.net/~jzavgren/8012108/webrev.01/

 Thanks!
 John Zavgren
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * Give Rabbit time, and he'll always get the answer
>>> -- 
>>> Dmitry Samersoff
>>> Oracle Java development team, Saint Petersburg, Russia
>>> * Give Rabbit time, and he'll always get the answer
> 
> 
> -- 
> John Zavgren
> john.zavg...@oracle.com
> 603-821-0904
> US-Burlington-MA
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

hg: jdk8/tl/jdk: 8012044: Give more information about self-suppression from Throwable.addSuppressed

[joe . darcy]

Changeset: 4da1d43f5843
Author:darcy
Date:  2013-04-25 09:37 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4da1d43f5843

8012044: Give more information about self-suppression from 
Throwable.addSuppressed
Reviewed-by: alanb, dholmes

! src/share/classes/java/lang/Throwable.java
! test/java/lang/Throwable/SuppressedExceptions.java

Re: RFR-JDK8012108

[John Zavgren]

Greetings:
I've cleaned up some formatting nits and a leak that I created in my 
realloc() "repairs" and created a revised webrev image:


http://cr.openjdk.java.net/~jzavgren/8012108/webrev.04

John



On 04/24/2013 09:10 PM, John Zavgren wrote:

All:

I expanded the scope of the work for this bug and cleaned up other 
realloc() errors in the windows native code. I believe I've identified 
all unsafe calls to realloc() in this corner of the native code.


Two additional files were affected.

Please let me know what you think:
http://cr.openjdk.java.net/~jzavgren/8012108/webrev.03/ 



Thanks!
John

On 04/20/2013 10:36 AM, Kurchi Subhra Hazra wrote:

On Apr 20, 2013, at 4:40 AM, Dmitry Samersoff  
wrote:


Kurchi,

if  *netaddrPP == NULL at 367 and calloc fails at 391 we would jump
to freeAllocatedMemory with start == NULL


True, but then we skip to line 444 since *netaddrPP == NULL, so we don't get to 
line 438.

I am just saying it is not strictly necessary to check if start is null before 
entering the first if block. We might want to guard against how the code 
changes in future and put in the check though.



I have no ideas whether this code path is possible in reality or not,
but it stops my eyes.

-Dmitry


On 2013-04-20 14:55, Kurchi Subhra Hazra wrote:

On Apr 20, 2013, at 3:16 AM, Dmitry Samersoff  
wrote:


John,

102, 145 else is redundant.

438  - we will crash here if start is null

Maybe it is good to have an additional check for start != null, but from what I 
see, start will not be null if *netaddrPP is not null.






-Dmitry


On 2013-04-20 01:33, John Zavgren wrote:

Greetings:

I fixed the bad realloc pattern. Please let me know what you think.
http://cr.openjdk.java.net/~jzavgren/8012108/webrev.02/

Thanks!
John Z


- Original Message -
From:chris.hega...@oracle.com
To:net-dev@openjdk.java.net,john.zavg...@oracle.com
Cc:dmitry.samers...@oracle.com
Sent: Friday, April 19, 2013 8:59:25 AM GMT -05:00 US/Canada Eastern
Subject: Re: RFR-JDK8012108

On 18/04/2013 22:11, Dmitry Samersoff wrote:

John,

I see bad realloc pattern here. Could you fix it as well?

Yes, please. Otherwise the changes look fine.

-Chris.


e.g.

93 adapterInfo = (IP_ADAPTER_ADDRESSES *) realloc (adapterInfo, len);

-Dmitry

On 2013-04-19 00:56, John Zavgren wrote:

Greetings:

I fixed a case in the windows native code where calloc() was being used
without checking it's returned value.

http://cr.openjdk.java.net/~jzavgren/8012108/webrev.01/

Thanks!
John Zavgren

--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer



--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA



--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA

hg: jdk8/tl/jdk: 8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters

[sean . coffey]

Changeset: 5871d7b1673c
Author:coffeys
Date:  2013-04-25 21:12 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5871d7b1673c

8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z 
and z pattern letters
Reviewed-by: okutsu

! src/share/classes/java/text/CalendarBuilder.java
! src/share/classes/java/text/SimpleDateFormat.java
! test/java/text/Format/DateFormat/Bug7130335.java

hg: jdk8/tl/jdk: 8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing

[bradford . wetmore]

Changeset: b600d637ef77
Author:wetmore
Date:  2013-04-25 17:10 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d637ef77

8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing
Reviewed-by: wetmore
Contributed-by: alan.bate...@oracle.com

! test/sun/security/provider/SecureRandom/StrongSeedReader.java

hg: jdk8/tl/langtools: 8013256: javac test failing after Lambda changes to java.util.List

[jonathan . gibbons]

Changeset: 4b0038f66d66
Author:jjg
Date:  2013-04-25 17:45 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4b0038f66d66

8013256: javac test failing after Lambda changes to java.util.List
Reviewed-by: mduigou

! test/tools/javac/api/TestJavacTaskScanner.java

hg: jdk8/tl/jdk: 3 new changesets

[mike . duigou]

Changeset: a8da4e516bc3
Author:akhil
Date:  2013-04-23 11:54 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8da4e516bc3

8005051: optimized defaults for Iterator.forEachRemaining
Reviewed-by: alanb, mduigou, psandoz, ulfzibis
Contributed-by: Akhil Arora 

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/LinkedList.java
! src/share/classes/java/util/Vector.java
! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java

Changeset: ceeed0fcb371
Author:jgish
Date:  2013-04-02 18:41 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ceeed0fcb371

5015163: (str) String merge/join that is the inverse of String.split()
7172553: A utility class that forms the basis of a String.join() operation
Summary: Integrate StringJoiner changes from lambda
Reviewed-by: alanb, mduigou

! make/java/java/FILES_java.gmk
! src/share/classes/java/lang/String.java
+ src/share/classes/java/util/StringJoiner.java
+ test/java/lang/String/StringJoinTest.java
+ test/java/util/StringJoiner/StringJoinerTest.java

Changeset: 2cb55846c9bb
Author:mduigou
Date:  2013-04-24 16:15 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cb55846c9bb

8011920: Main streams implementation
8012542: Stream methods on Collection
Reviewed-by: dholmes, mduigou
Contributed-by: Brian Goetz , Mike Duigou 
, Paul Sandoz 

! make/docs/CORE_PKGS.gmk
! src/share/classes/java/util/Collection.java
+ src/share/classes/java/util/stream/AbstractPipeline.java
+ src/share/classes/java/util/stream/AbstractSpinedBuffer.java
+ src/share/classes/java/util/stream/DistinctOps.java
+ src/share/classes/java/util/stream/DoublePipeline.java
+ src/share/classes/java/util/stream/IntPipeline.java
+ src/share/classes/java/util/stream/LongPipeline.java
+ src/share/classes/java/util/stream/Nodes.java
+ src/share/classes/java/util/stream/ReduceOps.java
+ src/share/classes/java/util/stream/ReferencePipeline.java
+ src/share/classes/java/util/stream/SliceOps.java
+ src/share/classes/java/util/stream/SortedOps.java
+ src/share/classes/java/util/stream/SpinedBuffer.java
+ src/share/classes/java/util/stream/StreamSpliterators.java
+ src/share/classes/java/util/stream/StreamSupport.java