Re: hg: jdk8/tl/langtools: 8006212: javac, convert jtreg tests from shell script to java

2013-02-20 Thread Vicente-Arturo Romero-Zaldivar 

On 19/02/13 18:50, Jonathan Gibbons wrote:
Woohoo -- 23 shell tests replaced with equivalent Java code: that's 
over 2/3 of the shell tests in langtools/test.


And lots of files removed, "less is more" :)

Vicente



-- Jon

On 02/19/2013 09:54 AM, vicente.rom...@oracle.com wrote:

Changeset: dc8b7aa7cef3
Author:vromero
Date:  2013-02-19 17:53 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dc8b7aa7cef3

8006212: javac, convert jtreg tests from shell script to java
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java
! src/share/classes/com/sun/tools/javac/util/ArrayUtils.java
+ test/tools/apt/Basics/CheckAptIsRemovedTest.java
- test/tools/apt/Basics/NullAPF.java
- test/tools/apt/Basics/apt.sh
- test/tools/apt/verifyVariables.sh
+ test/tools/javac/4846262/CheckEBCDICLocaleTest.java
- test/tools/javac/4846262/Test.java
- test/tools/javac/4846262/Test.out
- test/tools/javac/4846262/Test.sh
+ test/tools/javac/6302184/HiddenOptionsShouldUseGivenEncodingTest.java
- test/tools/javac/6302184/T6302184.sh
+ test/tools/javac/ClassPathTest/ClassPathTest.java
- test/tools/javac/ClassPathTest/ClassPathTest.sh
- test/tools/javac/ClassPathTest/ClassPathTest1.java
- test/tools/javac/ClassPathTest/ClassPathTest2.java
- test/tools/javac/ClassPathTest/ClassPathTest3.java
- test/tools/javac/ClassPathTest/bar/pkg/ClassPathTestAux2.java
- test/tools/javac/ClassPathTest/foo/pkg/ClassPathTestAux1.java
- test/tools/javac/ClassPathTest/pkg/ClassPathTestAux3.java
+ test/tools/javac/ExtDirs/ExtDirTest.java
- test/tools/javac/ExtDirs/ExtDirTest_1.java
- test/tools/javac/ExtDirs/ExtDirTest_2.java
- test/tools/javac/ExtDirs/ExtDirTest_3.java
- test/tools/javac/ExtDirs/ExtDirs.sh
- test/tools/javac/MissingInclude.java
- test/tools/javac/MissingInclude.sh
+ test/tools/javac/MissingInclude/MissingIncludeTest.java
- test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh
- test/tools/javac/ProtectedInnerClass/ProtectedInnerClass_2.java
+ test/tools/javac/ProtectedInnerClass/ProtectedInnerClassesTest.java
- test/tools/javac/ProtectedInnerClass/p1/ProtectedInnerClass1.java
- test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass2.java
- test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass3.java
+ test/tools/javac/T5090006/AssertionFailureTest.java
- test/tools/javac/T5090006/T5090006.java
- test/tools/javac/T5090006/compiler.sh
- test/tools/javac/constDebug/ConstDebug.java
- test/tools/javac/constDebug/ConstDebug.sh
+ test/tools/javac/constDebug/ConstDebugTest.java
- test/tools/javac/fatalErrors/NoJavaLang.java
- test/tools/javac/fatalErrors/NoJavaLang.out
- test/tools/javac/fatalErrors/NoJavaLang.sh
+ test/tools/javac/fatalErrors/NoJavaLangTest.java
- test/tools/javac/innerClassFile/Driver.sh
+ test/tools/javac/innerClassFile/InnerClassFileTest.java
- test/tools/javac/innerClassFile/x/B.java
- test/tools/javac/innerClassFile/x/C.java
- test/tools/javac/innerClassFile/y/Main.java
- test/tools/javac/innerClassFile/y/R1.java
- test/tools/javac/innerClassFile/y/R2.java
- test/tools/javac/innerClassFile/y/R3.java
- test/tools/javac/javazip/A.java
+ test/tools/javac/javazip/JavaZipTest.java
- test/tools/javac/javazip/Test.sh
- test/tools/javac/javazip/bad/B.java
- test/tools/javac/javazip/good/B.java
+ test/tools/javac/lib/ToolBox.java
+ test/tools/javac/links/LinksTest.java
- test/tools/javac/links/T.java
- test/tools/javac/links/b/B.java
- test/tools/javac/links/links.sh
+ test/tools/javac/newlines/NewLineTest.java
- test/tools/javac/newlines/Newlines.sh
+ test/tools/javac/stackmap/StackMapTest.java
- test/tools/javac/stackmap/T4955930.java
- test/tools/javac/stackmap/T4955930.sh
! test/tools/javac/unicode/SupplementaryJavaID6.java
- test/tools/javac/unicode/SupplementaryJavaID6.sh
+ test/tools/javah/6257087/T6257087.java
- test/tools/javah/6257087/foo.java
- test/tools/javah/6257087/foo.sh
- test/tools/javah/6257087/foo_bar.h
- test/tools/javah/ConstMacroTest.sh
- test/tools/javah/MissingParamClassException.java
- test/tools/javah/MissingParamClassTest.sh
- test/tools/javah/ParamClassTest.java
- test/tools/javah/SubClassConsts.java
- test/tools/javah/SubClassConsts.out
- test/tools/javah/SubClassConsts.win
- test/tools/javah/SuperClassConsts.java
+ test/tools/javah/T4942232/MissingParamClassTest.java
+ test/tools/javah/constMacroTest/ConstMacroTest.java
+ test/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java
+ test/tools/javap/4866831/PublicInterfaceTest.java
- test/tools/javap/NotPackagePrivateInterface.java
- test/tools/javap/PublicInterfaceTest.sh
- test/tools/javap/pathsep.sh
+ test/tools/javap/stackmap/StackmapTest.java
- test/tools/javap/stackmap/T6271292.java
- test/tools/javap/stackmap/T6271292.out
- test/tools/javap/stackmap/T6271292.sh

hg: jdk8/tl/jdk: 8008089: Delete OS dependent check in JdkFinder.getExecutable()

2013-02-20 Thread staffan . larsen 
Changeset: ca43e2761a1d
Author:ykantser
Date:  2013-02-13 10:24 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca43e2761a1d

8008089: Delete OS dependent check in JdkFinder.getExecutable()
Reviewed-by: egahlin, alanb

! test/lib/testlibrary/jdk/testlibrary/JdkFinder.java

hg: jdk8/tl/jdk: 8008352: java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh fails on MKS

2013-02-20 Thread daniel . daugherty 
Changeset: 5772e9edbc4c
Author:dcubed
Date:  2013-02-20 13:23 -0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5772e9edbc4c

8008352: java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh fails on MKS
Summary: Use more portable pattern counting constructs in test driver.
Reviewed-by: sspitsyn, sla, coleenp

! test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh

hg: jdk8/tl/langtools: 8006582: Test for parameter names feature

2013-02-20 Thread jonathan . gibbons 
Changeset: 267225edc1fe
Author:strarup
Date:  2013-02-20 15:47 -0800
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/267225edc1fe

8006582: Test for parameter names feature
Reviewed-by: jjg, darcy, emc

- test/tools/javac/MethodParameters.java
+ test/tools/javac/MethodParameters/AnnotationTest.java
+ test/tools/javac/MethodParameters/AnonymousClass.java
+ test/tools/javac/MethodParameters/AttributeVisitor.java
+ test/tools/javac/MethodParameters/ClassFileVisitor.java
+ test/tools/javac/MethodParameters/Constructors.java
+ test/tools/javac/MethodParameters/EnumTest.java
+ test/tools/javac/MethodParameters/InstanceMethods.java
+ test/tools/javac/MethodParameters/LambdaTest.java
+ test/tools/javac/MethodParameters/LocalClassTest.java
+ test/tools/javac/MethodParameters/MemberClassTest.java
+ test/tools/javac/MethodParameters/ReflectionVisitor.java
+ test/tools/javac/MethodParameters/StaticMethods.java
+ test/tools/javac/MethodParameters/Tester.java
+ test/tools/javac/MethodParameters/UncommonParamNames.java
+ test/tools/javac/MethodParametersTest.java

hg: jdk8/tl: 8008629: webrev.ksh needs to quote bug title it gets back from scraping bugs.sun.com

2013-02-20 Thread mike . duigou 
Changeset: c641268c4532
Author:mduigou
Date:  2013-02-20 17:56 -0800
URL:   http://hg.openjdk.java.net/jdk8/tl/rev/c641268c4532

8008629: webrev.ksh needs to quote bug title it gets back from scraping 
bugs.sun.com
Reviewed-by: darcy

! make/scripts/webrev.ksh