hg: jdk8/tl/jdk: 7196533: TimeZone.getDefault() slow due to synchronization bottleneck

[sean . coffey]

Changeset: fecba6a8b78e
Author:coffeys
Date:  2012-10-09 12:50 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e

7196533: TimeZone.getDefault() slow due to synchronization bottleneck
Reviewed-by: okutsu

! src/share/classes/java/util/TimeZone.java

hg: jdk8/tl: 7173494: some jdk tests are not run in test/Makefile

[alan . bateman]

Changeset: 4bde5640fb36
Author:alanb
Date:  2012-10-09 13:25 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/rev/4bde5640fb36

7173494: some jdk tests are not run in test/Makefile
Reviewed-by: chegar, mchung, mduigou, iris

! make/jprt.properties
! test/Makefile

hg: jdk8/tl/jdk: 7173494: some jdk tests are not run in test/Makefile

[alan . bateman]

Changeset: 3b79177ebfef
Author:alanb
Date:  2012-10-09 13:28 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b79177ebfef

7173494: some jdk tests are not run in test/Makefile
Reviewed-by: chegar, mchung, mduigou, iris

! make/jprt.properties
! test/Makefile
! test/ProblemList.txt

hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC

[lance . andersen]

Changeset: 036c55976cef
Author:lancea
Date:  2012-10-09 08:58 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef

7197395: Add @Deprecated to all deprecated methods to eliminate compiler 
warnings in JDBC
Reviewed-by: alanb, smarks

! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
! src/share/classes/com/sun/rowset/JoinRowSetImpl.java
! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java
! src/share/classes/java/sql/CallableStatement.java
! src/share/classes/java/sql/Date.java
! src/share/classes/java/sql/DriverManager.java
! src/share/classes/java/sql/PreparedStatement.java
! src/share/classes/java/sql/ResultSet.java
! src/share/classes/javax/sql/rowset/BaseRowSet.java

RFR: 7181793: Socket getInputStream/getOutputStream create streams that cannot be GC'ed until Socket is closed

[Seán Coffey]

Requesting a review for this bug which cropped up whilst cleaning up the 
FileDescriptor & associated streams some time back (7105952)


Turns out that each call to a socket.getOutputStream() creates a new 
instance of SocketOutputStream. I'm not seeing any reason to why that 
code exists. One instance should be ok here. The getInputStream() method 
doesn't have this issue.


bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181793
webrev : http://cr.openjdk.java.net/~coffeys/webrev.7181793.jdk8/ 



Regards,
Sean.

Re: RFR: 7181793: Socket getInputStream/getOutputStream create streams that cannot be GC'ed until Socket is closed

[Alan Bateman]

On 09/10/2012 14:34, Seán Coffey wrote:
Requesting a review for this bug which cropped up whilst cleaning up 
the FileDescriptor & associated streams some time back (7105952)


Turns out that each call to a socket.getOutputStream() creates a new 
instance of SocketOutputStream. I'm not seeing any reason to why that 
code exists. One instance should be ok here. The getInputStream() 
method doesn't have this issue.


bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181793
webrev : http://cr.openjdk.java.net/~coffeys/webrev.7181793.jdk8/ 

I think the change is okay. I can't think of why someone would expect a 
new output stream each time.


For the test then I don't think you need a background thread to accept 
the connection, you could do this:


try (ServerSocket ss = new ServerSocket(0)) {
try (Socket s = new Socket(...);  Socket peer = ss.accept()) {
for (int i=0; i<10; i++) { ...}
}
}

That will also ensure that all sockets are closed (although it probably 
doesn't matter here because the tests runs in its own VM).


-Alan.

Re: RFR: 7181793: Socket getInputStream/getOutputStream create streams that cannot be GC'ed until Socket is closed

[Seán Coffey]

Neater approach to testcase alright. Updated : 
http://cr.openjdk.java.net/~coffeys/webrev.7181793.jdk8.02/


I'll leave the push for another few hours just in case others want to 
review. (BTW, I've run the relevant regression tests & JCK tests on this 
change. No issues spotted)


regards,
Sean.

On 09/10/2012 14:48, Alan Bateman wrote:

On 09/10/2012 14:34, Seán Coffey wrote:
Requesting a review for this bug which cropped up whilst cleaning up 
the FileDescriptor & associated streams some time back (7105952)


Turns out that each call to a socket.getOutputStream() creates a new 
instance of SocketOutputStream. I'm not seeing any reason to why that 
code exists. One instance should be ok here. The getInputStream() 
method doesn't have this issue.


bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181793
webrev : http://cr.openjdk.java.net/~coffeys/webrev.7181793.jdk8/ 

I think the change is okay. I can't think of why someone would expect 
a new output stream each time.


For the test then I don't think you need a background thread to accept 
the connection, you could do this:


try (ServerSocket ss = new ServerSocket(0)) {
try (Socket s = new Socket(...);  Socket peer = ss.accept()) {
for (int i=0; i<10; i++) { ...}
}
}

That will also ensure that all sockets are closed (although it 
probably doesn't matter here because the tests runs in its own VM).


-Alan.

Re: RFR: 7181793: Socket getInputStream/getOutputStream create streams that cannot be GC'ed until Socket is closed

[Chris Hegarty]

Thanks Sean. Looks fine to me.

-Chris.

On 09/10/2012 15:47, Seán Coffey wrote:

Neater approach to testcase alright. Updated :
http://cr.openjdk.java.net/~coffeys/webrev.7181793.jdk8.02/

I'll leave the push for another few hours just in case others want to
review. (BTW, I've run the relevant regression tests & JCK tests on this
change. No issues spotted)

regards,
Sean.

On 09/10/2012 14:48, Alan Bateman wrote:

On 09/10/2012 14:34, Seán Coffey wrote:

Requesting a review for this bug which cropped up whilst cleaning up
the FileDescriptor & associated streams some time back (7105952)

Turns out that each call to a socket.getOutputStream() creates a new
instance of SocketOutputStream. I'm not seeing any reason to why that
code exists. One instance should be ok here. The getInputStream()
method doesn't have this issue.

bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181793
webrev : http://cr.openjdk.java.net/~coffeys/webrev.7181793.jdk8/


I think the change is okay. I can't think of why someone would expect
a new output stream each time.

For the test then I don't think you need a background thread to accept
the connection, you could do this:

try (ServerSocket ss = new ServerSocket(0)) {
try (Socket s = new Socket(...); Socket peer = ss.accept()) {
for (int i=0; i<10; i++) { ...}
}
}

That will also ensure that all sockets are closed (although it
probably doesn't matter here because the tests runs in its own VM).

-Alan.

hg: jdk8/tl/jdk: 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances

[naoto . sato]

Changeset: c725ce4bbf12
Author:naoto
Date:  2012-10-09 09:59 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c725ce4bbf12

7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in 
some circumstances
Reviewed-by: okutsu

! src/share/classes/java/text/DateFormatSymbols.java
! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java
! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.sh
! test/java/util/PluggableLocale/fooprovider.jar
! test/java/util/PluggableLocale/providersrc/DateFormatSymbolsProviderImpl.java

hg: jdk8/tl/jdk: 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed

[sean . coffey]

Changeset: 71de5e31d497
Author:coffeys
Date:  2012-10-09 19:45 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497

7181793: Socket getOutputStream create streams that cannot be GC'ed until 
Socket is closed
Reviewed-by: alanb, chegar

! src/share/classes/java/net/AbstractPlainSocketImpl.java
+ test/java/net/Socket/SocketGrowth.java

hg: jdk8/tl/corba: 7196086: update copyright years for files in corba repository (JDK 8)

[sean . coffey]

Changeset: 679e8ad9874f
Author:coffeys
Date:  2012-10-09 20:14 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f

7196086: update copyright years for files in corba repository (JDK 8)
Reviewed-by: lancea

! make/common/Defs-bsd.gmk
! make/common/internal/Resources.gmk
! make/common/shared/Defs-bsd.gmk
! make/common/shared/Defs-utils.gmk
! make/tools/src/build/tools/stripproperties/StripPropertiesCorba.java
! make/tools/strip_properties/Makefile

hg: jdk8/tl/langtools: 8000663: clean up langtools imports

[jonathan . gibbons]

Changeset: c75be5bc5283
Author:jjg
Date:  2012-10-09 19:10 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c75be5bc5283

8000663: clean up langtools imports
Reviewed-by: darcy

! src/share/classes/com/sun/source/tree/CompilationUnitTree.java
! src/share/classes/com/sun/source/tree/Scope.java
! src/share/classes/com/sun/source/util/TaskEvent.java
! src/share/classes/com/sun/source/util/TreePath.java
! src/share/classes/com/sun/tools/classfile/ClassTranslator.java
! src/share/classes/com/sun/tools/classfile/Dependencies.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java
! 
src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java
! 
src/share/classes/com/sun/tools/doclets/internal/toolki