Review: 7146564: DefaultProxySelector should filter 0.0.0.0 and ::0 [macosx]

2012-06-20 Thread Michael McMahon 

Could I get the following small change reviewed for 7u6?

http://cr.openjdk.java.net/~michaelm/7146564/webrev.1/

The change has been in 8 already for some time.

Thanks
Michael.

Re: Review: 7146564: DefaultProxySelector should filter 0.0.0.0 and ::0 [macosx]

2012-06-20 Thread Chris Hegarty 

Looks fine to me.

-Chris.

On 20/06/2012 15:59, Michael McMahon wrote:

Could I get the following small change reviewed for 7u6?

http://cr.openjdk.java.net/~michaelm/7146564/webrev.1/

The change has been in 8 already for some time.

Thanks
Michael.

hg: jdk8/tl/langtools: 7174143: encapsulate doc comment table

2012-06-20 Thread jonathan . gibbons 
Changeset: 5c0b3faeb0b0
Author:jjg
Date:  2012-06-20 13:23 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c0b3faeb0b0

7174143: encapsulate doc comment table
Reviewed-by: ksrini, mcimadamore

! src/share/classes/com/sun/tools/javac/api/JavacTrees.java
! src/share/classes/com/sun/tools/javac/comp/Enter.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/jvm/CRTable.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/model/JavacElements.java
- src/share/classes/com/sun/tools/javac/parser/EndPosTable.java
! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
+ src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java
! src/share/classes/com/sun/tools/javac/parser/Tokens.java
+ src/share/classes/com/sun/tools/javac/tree/DocCommentTable.java
+ src/share/classes/com/sun/tools/javac/tree/EndPosTable.java
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/share/classes/com/sun/tools/javac/tree/Pretty.java
! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java
! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java
! src/share/classes/com/sun/tools/javac/util/Log.java
! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java
! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java
! test/tools/javac/6304921/TestLog.java
! test/tools/javac/failover/CheckAttributedTree.java
! test/tools/javac/tree/DocCommentToplevelTest.java
! test/tools/javac/tree/TreePosTest.java

hg: jdk8/tl/jdk: 7178483: Change version string for Embedded releases

2012-06-20 Thread david . holmes 
Changeset: dfe5617c18b4
Author:dholmes
Date:  2012-06-20 22:40 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfe5617c18b4

7178483: Change version string for Embedded releases
Reviewed-by: dholmes, lancea
Contributed-by: Gary Collins 

! make/common/Defs-embedded.gmk

A little modification to error message

2012-06-20 Thread Sean Chou 
Hi all,

We did some modification in these error messages because of some user
feedback “It is confusing to realize if the OOM is from java heap or native
heap”. So these error messages are modified from "heap allocation failed"
to "Native heap allocation failed". And in some places a little more to
help locate to functions like "send buffer heap allocation failed".
Would any one like to take a look?

webrev: http://cr.openjdk.java.net/~zhouyx/OJDK-528/webrev.00/  .


-- 
Best Regards,
Sean Chou