Re: Code Review Request: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread Chris Hegarty 

Thanks Kurchi, the change look good to me.

This is a corner case and already covered by JCK, but it may be useful 
to amend an existing test to check for this. Maybe 
test/java/net/CookieHandler/NullUriCookieTest.java


CookieStore cookieStore = (new CookieManager()).getCookieStore();
+if (cookieStore.removeAll())
+fail = true;
+checkFail("removeAll on an empty store should return false");
+

-Chris.

On 14/03/12 22:36, Kurchi Hazra wrote:

The CookieStore.removeAll() is supposed to return true according to its
spec, only if the CookieStore changes as a
result of the call.

InMemoryCookieStore:removeAll() was returning true by default, even if
the CookieStore object was already empty,
and no changes were being done by the call. This fix is to simply return
false in case the CookieStore is empty.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7045655
Webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.01/


Thanks,
Kurchi

hg: jdk8/tl/jdk: 2 new changesets

2012-03-15 Thread michael . x . mcmahon 
Changeset: ac5024504439
Author:michaelm
Date:  2012-03-15 16:45 +
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac5024504439

7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]
Reviewed-by: ohair, smarks

! make/common/shared/Sanity.gmk

Changeset: cfe2328912b3
Author:michaelm
Date:  2012-03-15 16:46 +
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfe2328912b3

Merge

- test/java/io/File/isDirectory/Applet.html
- test/sun/nio/cs/OLD/TestX11CS.java

Re: Code Review Request: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread Kurchi Hazra 

Hi Chris,

Updated webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.02/

- Kurchi


On 3/15/2012 2:49 AM, Chris Hegarty wrote:

Thanks Kurchi, the change look good to me.

This is a corner case and already covered by JCK, but it may be useful 
to amend an existing test to check for this. Maybe 
test/java/net/CookieHandler/NullUriCookieTest.java


CookieStore cookieStore = (new CookieManager()).getCookieStore();
+if (cookieStore.removeAll())
+fail = true;
+checkFail("removeAll on an empty store should return false");
+

-Chris.

On 14/03/12 22:36, Kurchi Hazra wrote:

The CookieStore.removeAll() is supposed to return true according to its
spec, only if the CookieStore changes as a
result of the call.

InMemoryCookieStore:removeAll() was returning true by default, even if
the CookieStore object was already empty,
and no changes were being done by the call. This fix is to simply return
false in case the CookieStore is empty.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7045655
Webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.01/


Thanks,
Kurchi



--
-Kurchi

Re: Code Review Request: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread Chris Hegarty 
Thanks Kurchi, looks good.

-Chris.

Kurchi Hazra  wrote:

>Hi Chris,
>
> Updated webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.02/
>
>- Kurchi
>
>
>On 3/15/2012 2:49 AM, Chris Hegarty wrote:
>> Thanks Kurchi, the change look good to me.
>>
>> This is a corner case and already covered by JCK, but it may be useful 
>> to amend an existing test to check for this. Maybe 
>> test/java/net/CookieHandler/NullUriCookieTest.java
>>
>> CookieStore cookieStore = (new CookieManager()).getCookieStore();
>> +if (cookieStore.removeAll())
>> +fail = true;
>> +checkFail("removeAll on an empty store should return false");
>> +
>>
>> -Chris.
>>
>> On 14/03/12 22:36, Kurchi Hazra wrote:
>>> The CookieStore.removeAll() is supposed to return true according to its
>>> spec, only if the CookieStore changes as a
>>> result of the call.
>>>
>>> InMemoryCookieStore:removeAll() was returning true by default, even if
>>> the CookieStore object was already empty,
>>> and no changes were being done by the call. This fix is to simply return
>>> false in case the CookieStore is empty.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7045655
>>> Webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.01/
>>>
>>>
>>> Thanks,
>>> Kurchi
>>>
>
>-- 
>-Kurchi
>

hg: jdk8/tl/jdk: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread kurchi . subhra . hazra 
Changeset: 3bfebedb549f
Author:khazra
Date:  2012-03-15 13:21 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bfebedb549f

7045655: An empty InMemoryCookieStore should not return true for removeAll
Summary: CookieStore.removeAll() should return false for an empty CookieStore
Reviewed-by: chegar

! src/share/classes/java/net/InMemoryCookieStore.java
! test/java/net/CookieHandler/NullUriCookieTest.java

hg: jdk8/tl/jdk: 2 new changesets

2012-03-15 Thread valerie . peng 
Changeset: bdbc32b2f920
Author:valeriep
Date:  2012-03-15 14:28 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdbc32b2f920

7130959: Tweak 7058133 fix for JDK 8 (javah makefile changes)
Summary: Fixed JAVAHFLAGS setting to use -bootclasspath.
Reviewed-by: wetmore

! make/sun/security/ec/Makefile
! make/sun/security/mscapi/Makefile
! make/sun/security/pkcs11/Makefile

Changeset: e48136bb8fdd
Author:valeriep
Date:  2012-03-15 14:40 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e48136bb8fdd

Merge

hg: jdk8/tl/jdk: 7153343: Dependency on non-POSIX header file causes portability problem

2012-03-15 Thread littlee 
Changeset: c4e66dc3222d
Author:littlee
Date:  2012-03-16 10:47 +0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4e66dc3222d

7153343: Dependency on non-POSIX header file  causes portability problem
Summary: Remove the unneccessary link.h
Reviewed-by: alanb, chegar
Contributed-by: Jonathan Lu 

! src/solaris/native/sun/nio/fs/GnomeFileTypeDetector.c
! src/solaris/native/sun/security/jgss/wrapper/NativeFunc.c
! src/solaris/native/sun/security/pkcs11/j2secmod_md.c
! src/solaris/native/sun/security/pkcs11/wrapper/p11_md.c
! src/solaris/native/sun/security/smartcardio/pcsc_md.c
! src/solaris/npt/npt_md.h