Re: Easy-to-fix javadoc warning
Thanks for reporting this Jon.
I filed CR 7145043: "HttpServerProvider.java:81: warning -
@code("httpServerProvider") is an unknown tag"
You see quite a few of these type of RuntimePermission links through out
the core area. The intent is to link to RuntimePermission and show the
appropriate String arg "target name".
The simplest fix is to add a space after the @code tag. This generates
the required javadoc, "RuntimePermission("httpServerProvider")", similar
to how it appears in System.getenv [1].
src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java
@@ -76,7 +76,7 @@ public abstract class HttpServerProvider
*
* @throws SecurityException
* If a security manager has been installed and it denies
- * {@link RuntimePermission}{@code("httpServerProvider")}
+ * {@link RuntimePermission}{@code ("httpServerProvider")}
*/
protected HttpServerProvider() {
SecurityManager sm = System.getSecurityManager();
Thanks,
-Chris.
[1]
http://download.java.net/jdk8/docs/api/java/lang/System.html#getenv%28java.lang.String%29
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 3554f175341a Author:vinnie Date: 2012-02-13 14:26 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3554f175341a 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done Reviewed-by: xuelei, wetmore ! src/share/classes/sun/security/pkcs/PKCS7.java Changeset: 59bd472746d6 Author:vinnie Date: 2012-02-13 14:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59bd472746d6 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java
hg: jdk8/tl/jaxws: 7140918: Remove dependency on apt and com.sun.mirror API
Changeset: 6a8f54fb5f15 Author:alanb Date: 2012-02-05 12:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6a8f54fb5f15 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav@oracle.com, martin.gre...@oracle.com ! build-defs.xml ! jaxws.properties
hg: jdk8/tl/jdk: 7142847: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java has incorrect @run tag, runs Basic
Changeset: c6d6ef8ec2bf Author:alanb Date: 2012-02-07 13:28 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6d6ef8ec2bf 7142847: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java has incorrect @run tag, runs Basic Reviewed-by: chegar ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/SensitivityModifier.java
hg: jdk8/tl/jdk: 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently
Changeset: 8326d434681d Author:alanb Date: 2012-02-09 16:38 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8326d434681d 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently Reviewed-by: chegar ! test/java/nio/file/WatchService/SensitivityModifier.java
Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()
Hi, Before joining multicast groups with IPv6 addresses on Mac OS, the network interface to be used should also be set correctly. This change enables using a default network interface on Mac OS X if no interface has been specified. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274 Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/ Thanks, Kurchi
hg: jdk8/tl/langtools: 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...)
Changeset: 237198ef45f5 Author:jjh Date: 2012-02-13 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/237198ef45f5 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/T7142672/AnnoProcessor.java + test/tools/javac/T7142672/Bug.java + test/tools/javac/T7142672/Test2.java + test/tools/javac/T7142672/Test3.java
Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()
On 13/02/2012 22:03, Kurchi Hazra wrote: Hi, Before joining multicast groups with IPv6 addresses on Mac OS, the network interface to be used should also be set correctly. This change enables using a default network interface on Mac OS X if no interface has been specified. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274 Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/ Kurchi - I think you should include an #else return 0; in getDefaultScopeID as otherwise I will guess you will get warnings when this code is compiled on other platforms. -Alan.
