Re: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X
Looks fine. - Michael. On 17/01/12 19:01, Kurchi Hazra wrote: I updated the comment: http://cr.openjdk.java.net/~khazra/7127771/webrev.02/ - Kurchi On 1/16/2012 2:43 AM, Michael McMahon wrote: Yes, looks fine to me too. I would just update the comment above this code to add Mac OS to the Solaris case. Thanks Michael On 13/01/12 21:02, Kurchi Hazra wrote: How does this look: http://cr.openjdk.java.net/~khazra/7127771/webrev.01/ - Kurchi On 1/13/2012 12:14 PM, Alan Bateman wrote: Bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127771 Webrev : http://cr.openjdk.java.net/~khazra/7127771/webrev.00/ What you have is fine although you could combine with the Solaris code? Should the __ALLBSD_SOURCE XXX be removed while you are there? -Alan
hg: jdk8/tl/jaxp: 3 new changesets
Changeset: f052abb8f374 Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f052abb8f374 Added tag jdk8-b19 for changeset dffeb62b1a7f ! .hgtags Changeset: d41eeadf5c13 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d41eeadf5c13 Added tag jdk8-b20 for changeset f052abb8f374 ! .hgtags Changeset: cf9d6ec44f89 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cf9d6ec44f89 Added tag jdk8-b21 for changeset d41eeadf5c13 ! .hgtags
hg: jdk8/tl/hotspot: 3 new changesets
Changeset: fe2c87649981 Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fe2c87649981 Added tag jdk8-b19 for changeset 9232e0ecbc2c ! .hgtags Changeset: 9952d1c439d6 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9952d1c439d6 Added tag jdk8-b20 for changeset fe2c87649981 ! .hgtags Changeset: ed621d125d02 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed621d125d02 Added tag jdk8-b21 for changeset 9952d1c439d6 ! .hgtags
hg: jdk8/tl/corba: 3 new changesets
Changeset: 51d8b6cb18c0 Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/51d8b6cb18c0 Added tag jdk8-b19 for changeset e1366c5d84ef ! .hgtags Changeset: f157fc2a71a3 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/f157fc2a71a3 Added tag jdk8-b20 for changeset 51d8b6cb18c0 ! .hgtags Changeset: a11d0062c445 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a11d0062c445 Added tag jdk8-b21 for changeset f157fc2a71a3 ! .hgtags
hg: jdk8/tl/jaxws: 5 new changesets
Changeset: 2b2818e3386f Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/2b2818e3386f Added tag jdk8-b19 for changeset b73b733214aa ! .hgtags Changeset: dc2ee8b87884 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/dc2ee8b87884 Added tag jdk8-b20 for changeset 2b2818e3386f ! .hgtags Changeset: e67d51254533 Author:ohair Date: 2012-01-09 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e67d51254533 7096063: /META-INF/mimetypes.default missing in jre\lib\resources.jar Reviewed-by: dholmes ! build-defs.xml Changeset: c266cab0e3ff Author:katleman Date: 2012-01-11 16:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c266cab0e3ff Merge Changeset: 8d3df89b0f2d Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8d3df89b0f2d Added tag jdk8-b21 for changeset c266cab0e3ff ! .hgtags
hg: jdk8/tl: 3 new changesets
Changeset: 5a5eaf6374bc Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5a5eaf6374bc Added tag jdk8-b19 for changeset 237bc29afbfc ! .hgtags Changeset: cc771d92284f Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cc771d92284f Added tag jdk8-b20 for changeset 5a5eaf6374bc ! .hgtags Changeset: 7ad075c80995 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7ad075c80995 Added tag jdk8-b21 for changeset cc771d92284f ! .hgtags
hg: jdk8/tl/langtools: 6 new changesets
Changeset: ffd294128a48 Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ffd294128a48 Added tag jdk8-b19 for changeset 77b2c066084c ! .hgtags Changeset: 020819eb56d2 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/020819eb56d2 Added tag jdk8-b20 for changeset ffd294128a48 ! .hgtags Changeset: 4e8aa6eca726 Author:lana Date: 2012-01-04 10:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4e8aa6eca726 Merge Changeset: bcb21abf1c41 Author:lana Date: 2012-01-09 19:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bcb21abf1c41 Merge Changeset: 390a7828ae18 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/390a7828ae18 Added tag jdk8-b21 for changeset bcb21abf1c41 ! .hgtags Changeset: f00afa80f1f0 Author:lana Date: 2012-01-18 11:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f00afa80f1f0 Merge
hg: jdk8/tl/jdk: 20 new changesets
Changeset: 60dd940eb58e Author:yhuang Date: 2011-12-12 18:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60dd940eb58e 7003124: In Bulgarian Locale DateFormat is wrong Reviewed-by: naoto, peytoia ! src/share/classes/sun/text/resources/FormatData_bg.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: cd03cd0e0965 Author:mfang Date: 2011-12-15 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd03cd0e0965 Merge Changeset: 3778f8577305 Author:katleman Date: 2011-12-28 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3778f8577305 Merge Changeset: 80350ee39fa8 Author:katleman Date: 2011-12-29 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80350ee39fa8 Added tag jdk8-b19 for changeset 3778f8577305 ! .hgtags Changeset: 172d70c50c65 Author:cgruszka Date: 2011-09-15 13:59 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/172d70c50c65 7066713: Separate demos from the bundles on Solaris and Linux Summary: add new license files to demos and samples, new directory for bundling Reviewed-by: katleman, ohair, billyh ! make/common/Release.gmk ! make/common/shared/Defs-control.gmk Changeset: eaf967fd25c5 Author:cgruszka Date: 2011-10-18 14:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eaf967fd25c5 7099017: jdk7u2-dev does not build Summary: changes to skip demo/DEMOS_LICENSE and sample/SAMPLES_LICENSE when building OPENJDK Reviewed-by: ohair, billyh ! make/common/Release.gmk Changeset: 39b7f01203c9 Author:cgruszka Date: 2011-11-17 16:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39b7f01203c9 Merge Changeset: b64e7263b4fd Author:cgruszka Date: 2011-11-18 01:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b64e7263b4fd Merge Changeset: e98869ff9f1e Author:cgruszka Date: 2011-12-05 12:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e98869ff9f1e Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: ffa36a6a46f5 Author:cgruszka Date: 2011-12-16 15:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffa36a6a46f5 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun
hg: jdk8/tl/langtools: 7130768: Clarify behavior of Element.getEnclosingElements in subtypes
Changeset: cf2496340fef Author:darcy Date: 2012-01-18 16:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cf2496340fef 7130768: Clarify behavior of Element.getEnclosingElements in subtypes Reviewed-by: mcimadamore, jjg ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/PackageElement.java ! src/share/classes/javax/lang/model/element/TypeElement.java
hg: jdk8/tl/langtools: 7131308: Three regression tests fail due to bad fix for 7127924
Changeset: 99261fc7d95d Author:jjh Date: 2012-01-18 18:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99261fc7d95d 7131308: Three regression tests fail due to bad fix for 7127924 Reviewed-by: jjg ! test/tools/javac/diags/CheckExamples.java ! test/tools/javac/diags/MessageInfo.java ! test/tools/javac/diags/RunExamples.java
