Code review request: 7127660 (macosx) *Socket Async close not working
Could I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/7127660/webrev.1/ The asynchronous close mechanism was not being compiled for Mac OS. Also, the pthread mutexes used by this code, need to be explicitly initialized on Mac, which was not being done previously (on Linux). Thanks, Michael.
Re: Code review request: 7127660 (macosx) *Socket Async close not working
On 09/01/2012 16:03, Michael McMahon wrote: Could I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/7127660/webrev.1/ The asynchronous close mechanism was not being compiled for Mac OS. Also, the pthread mutexes used by this code, need to be explicitly initialized on Mac, which was not being done previously (on Linux). This looks okay to me. Do you also need to changes in src/solaris/native/sun/nio/ch/NativeThread.c? -Alan.
Re: Code review request: 7127660 (macosx) *Socket Async close not working
On 09/01/12 16:15, Alan Bateman wrote: On 09/01/2012 16:03, Michael McMahon wrote: Could I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/7127660/webrev.1/ The asynchronous close mechanism was not being compiled for Mac OS. Also, the pthread mutexes used by this code, need to be explicitly initialized on Mac, which was not being done previously (on Linux). This looks okay to me. Do you also need to changes in src/solaris/native/sun/nio/ch/NativeThread.c? -Alan. Yes, that needs to be changed. But, I'd prefer to do that under a nio specific CR along with other changes needed for NIO. Thanks Michael.
hg: jdk8/tl/jdk: 7030573: test/java/io/FileInputStream/LargeFileAvailable.java fails when there is insufficient disk space
Changeset: 74c92c3e66ad Author:gadams Date: 2012-01-09 19:33 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74c92c3e66ad 7030573: test/java/io/FileInputStream/LargeFileAvailable.java fails when there is insufficient disk space Reviewed-by: alanb ! test/java/io/FileInputStream/LargeFileAvailable.java
hg: jdk8/tl/jdk: 7128441: StrictMath performance improvement note shared with Math
Changeset: 858038d89fd5 Author:darcy Date: 2012-01-09 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858038d89fd5 7128441: StrictMath performance improvement note shared with Math Reviewed-by: darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java
hg: jdk8/tl/jdk: 7128512: Javadoc typo in java.lang.invoke.MethodHandle
Changeset: dd69d3695cee Author:darcy Date: 2012-01-09 20:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd69d3695cee 7128512: Javadoc typo in java.lang.invoke.MethodHandle Reviewed-by: mduigou ! src/share/classes/java/lang/invoke/MethodHandle.java
