Re: Question about getaddrinfo in Inet4AddressImpl.c
On 11/15/11 06:57 AM, Charles Lee wrote: Sigh. Chris, I still fail to see those warnings, even if I do a very clean remove of my build directory and rebuild the whole jdk The warning are being generated on Solaris when using the Sun compilers ( both full and incremental builds ). Here is the new (big) patch(attached) according to the comments from you and Mike. Thank you guys :-) I can't apply the patch you sent. Is it possible to generate a webrev, another patch, or let me know how to apply the the one you sent? Thanks, -Chris.
Re: Question about getaddrinfo in Inet4AddressImpl.c
On 11/15/2011 07:10 PM, Chris Hegarty wrote: On 11/15/11 06:57 AM, Charles Lee wrote: Sigh. Chris, I still fail to see those warnings, even if I do a very clean remove of my build directory and rebuild the whole jdk The warning are being generated on Solaris when using the Sun compilers ( both full and incremental builds ). Here is the new (big) patch(attached) according to the comments from you and Mike. Thank you guys :-) I can't apply the patch you sent. Is it possible to generate a webrev, another patch, or let me know how to apply the the one you sent? Thanks, -Chris. Hi Chris, patch -p0 < mypatch under the jdk directory will do the trick. I will try to find a solaris to test my patch. -- Yours Charles
Re: Question about getaddrinfo in Inet4AddressImpl.c
On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: > On 11/15/2011 07:10 PM, Chris Hegarty wrote: > > On 11/15/11 06:57 AM, Charles Lee wrote: > >> > > >>> > >> Sigh. Chris, I still fail to see those warnings, even if I do a very > >> clean remove of my build directory and rebuild the whole jdk > > > > The warning are being generated on Solaris when using the Sun > > compilers ( both full and incremental builds ). > > > >> Here is the new (big) patch(attached) according to the comments from you > >> and Mike. Thank you guys :-) > > > > I can't apply the patch you sent. Is it possible to generate a webrev, > > another patch, or let me know how to apply the the one you sent? > > > > Thanks, > > -Chris. > > > Hi Chris, > > patch -p0 < mypatch under the jdk directory will do the trick. > > I will try to find a solaris to test my patch. > Here is Charles' latest patch in webrev form [1]. Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/ -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: Question about getaddrinfo in Inet4AddressImpl.c
On 11/16/2011 01:00 AM, Neil Richards wrote: On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: On 11/15/2011 07:10 PM, Chris Hegarty wrote: On 11/15/11 06:57 AM, Charles Lee wrote: Sigh. Chris, I still fail to see those warnings, even if I do a very clean remove of my build directory and rebuild the whole jdk The warning are being generated on Solaris when using the Sun compilers ( both full and incremental builds ). Here is the new (big) patch(attached) according to the comments from you and Mike. Thank you guys :-) I can't apply the patch you sent. Is it possible to generate a webrev, another patch, or let me know how to apply the the one you sent? Thanks, -Chris. Hi Chris, patch -p0< mypatch under the jdk directory will do the trick. I will try to find a solaris to test my patch. Here is Charles' latest patch in webrev form [1]. Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/ Thanks Neil. Hi Chris, With the latest patch, the warning of Inet4AddressImpl seems gone :-P (I have reordered the statement and declaration). They used to happen on the solaris indeed. Do you see other warnings now? -- Yours Charles
hg: jdk8/tl/jdk: 7111579: klist starttime, renewtill, ticket etype
Changeset: c740519fe83a Author:weijun Date: 2011-11-16 11:53 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c740519fe83a 7111579: klist starttime, renewtill, ticket etype Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: cd6d236e863b Author:okutsu Date: 2011-11-16 12:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd6d236e863b 7111903: (tz) Windows-only: tzmappings needs update for KB2570791 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 1266e72f7896 Author:okutsu Date: 2011-11-16 13:17 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1266e72f7896 Merge
