Re: JEP 125: Network Interface Aliases, Events, and Defaults

2011-11-06 Thread Dr Andrew John Hughes 
On 12:29 Thu 03 Nov , mark.reinh...@oracle.com wrote:
> Posted: http://openjdk.java.net/jeps/125
> 
> - Mark

Could these not be posted in the mail with a link to the online
version?  They're just text after all.  It's annoying to have numerous
mails with just a link in, and it means having to move away from the
mail client to the browser all the time.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07


signature.asc
Description: Digital signature

Re: Question about getaddrinfo in Inet4AddressImpl.c

2011-11-06 Thread Charles Lee 

On 11/03/2011 12:33 AM, Neil Richards wrote:

On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote:

On 10/26/2011 06:31 PM, Chris Hegarty wrote:

On 26/10/2011 10:36, Alan Bateman wrote:

On 26/10/2011 10:24, Charles Lee wrote:


/>>>  I don't think this code has changed too much since then and
probably could do with a clean-up./
Not true.

I'm talking about the InetAddress* code, that hasn't changed
significantly and probably could do with some modernization now.

Yes, please submit a patch for this cleanup and we'll review it.

-Chris.


-Alan.

Hi Chris, Alan and Neil,

Here is the rest of the patch (attached). The patch is a little big
because some formats.


For ease of review, I've uploaded this change (ie. the combination of
Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1].

My initial (and picky) observation is that the code indentation needs a
little work to comply with the OpenJDK coding conventions [2].
(Particularly using a standard indentation for 4 spaces).

Regards, Neil

[1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/
[2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf


Thanks Neil. I will change it.

--
Yours Charles