hg: jdk7/tl/langtools: 7023233: False positive for -Xlint:try with nested try with resources blocks

2011-03-03 Thread maurizio . cimadamore
Changeset: e9b8fbb30f5a
Author:mcimadamore
Date:  2011-03-03 09:43 +
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e9b8fbb30f5a

7023233: False positive for -Xlint:try with nested try with resources blocks
Summary: Wrong lint warning issued about unused resource when nested 
try-with-resource blocks are found
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Flow.java
+ test/tools/javac/TryWithResources/UnusedResourcesTest.java



hg: jdk7/tl/jaxp: 7023289: jaxp 1.4.5 development jdk7 2nd integration

2011-03-03 Thread kelly . ohair
Changeset: 877fd25c5a2f
Author:ohair
Date:  2011-03-02 12:00 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/877fd25c5a2f

7023289: jaxp 1.4.5 development jdk7 2nd integration
Reviewed-by: joehw, mchung, alanb

! jaxp.properties



Code Review 7018137: HTML4 compliance issues

2011-03-03 Thread Chris Hegarty

Alan, Michael,

Trivially, embedded lists should be within the outer lists list item. 
Remove unnecessary 


http://cr.openjdk.java.net/~chegar/7018137/webrev.00/webrev/

-Chris.


hg: jdk7/tl/jdk: 7018606: (process) test/java/lang/ProcessBuilder/Basic.java failing intermittently (win)

2011-03-03 Thread michael . x . mcmahon
Changeset: 75064373ed6b
Author:michaelm
Date:  2011-03-03 15:34 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75064373ed6b

7018606: (process) test/java/lang/ProcessBuilder/Basic.java failing 
intermittently (win)
Reviewed-by: alanb

! test/java/lang/ProcessBuilder/Basic.java



Re: Code Review 7018137: HTML4 compliance issues

2011-03-03 Thread Alan Bateman

Chris Hegarty wrote:

Alan, Michael,

Trivially, embedded lists should be within the outer lists list item. 
Remove unnecessary 


http://cr.openjdk.java.net/~chegar/7018137/webrev.00/webrev/

-Chris.

Looks good to me.

-Alan


hg: jdk7/tl/jdk: 7018137: HTML4 compliance issues

2011-03-03 Thread chris . hegarty
Changeset: 7cfb0693eb33
Author:chegar
Date:  2011-03-03 16:44 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7cfb0693eb33

7018137: HTML4 compliance issues
Summary: move end list items tags to after nested list
Reviewed-by: alanb

! src/share/classes/java/net/URI.java
! src/share/classes/java/net/package.html



hg: jdk7/tl/jdk: 6721694: java/lang/Thread/StartOOMTest.java fails with timeout or with crash

2011-03-03 Thread chris . hegarty
Changeset: 9b99a14375bc
Author:chegar
Date:  2011-03-03 16:48 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b99a14375bc

6721694: java/lang/Thread/StartOOMTest.java fails with timeout or with crash
Summary: the test is not suitable to be run automatically
Reviewed-by: alanb

! test/java/lang/Thread/StartOOMTest.java



hg: jdk7/tl/jdk: 2 new changesets

2011-03-03 Thread sean . coffey
Changeset: 732faed56eb0
Author:coffeys
Date:  2011-03-03 16:51 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/732faed56eb0

6750362: Very large LDAP requests throw a OOM on LDAP servers which aren't 
aware of Paged Results Controls
6748156: add an new JNDI property to control the boolean flag WaitForReply
Reviewed-by: vinnie, robm

! src/share/classes/com/sun/jndi/ldap/Connection.java
! src/share/classes/com/sun/jndi/ldap/LdapClient.java
! src/share/classes/com/sun/jndi/ldap/LdapCtx.java
! src/share/classes/com/sun/jndi/ldap/LdapRequest.java
+ test/com/sun/jndi/ldap/NoWaitForReplyTest.java

Changeset: 0bd32f96187d
Author:coffeys
Date:  2011-03-03 17:00 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bd32f96187d

Merge




hg: jdk7/tl/jdk: 2 new changesets

2011-03-03 Thread michael . x . mcmahon
Changeset: b645b5bc460b
Author:michaelm
Date:  2011-03-03 17:14 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b645b5bc460b

7024264: HttpURLConnection/NetPermission doc issue
Reviewed-by: chegar

! src/share/classes/java/net/HttpURLConnection.java
! src/share/classes/java/net/NetPermission.java

Changeset: 6e596210bf01
Author:michaelm
Date:  2011-03-03 17:16 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e596210bf01

Merge




hg: jdk7/tl/langtools: 2 new changesets

2011-03-03 Thread maurizio . cimadamore
Changeset: c15d788cb381
Author:mcimadamore
Date:  2011-03-03 17:32 +
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c15d788cb381

7023703: Valid code doesn't compile
Summary: leftovers cause problems when analyzing loops in Flow.java
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Flow.java
+ test/tools/javac/7023703/T7023703neg.java
+ test/tools/javac/7023703/T7023703neg.out
+ test/tools/javac/7023703/T7023703pos.java

Changeset: 32565546784b
Author:mcimadamore
Date:  2011-03-03 17:34 +
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/32565546784b

7022054: Invalid compiler error on covariant overriding methods with the same 
erasure
Summary: Rules for method clash use notion of subsignature, which is sometimes 
too strict and incompatible with JDK 6
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/generics/7022054/T7022054neg1.java
+ test/tools/javac/generics/7022054/T7022054neg1.out
+ test/tools/javac/generics/7022054/T7022054neg2.java
+ test/tools/javac/generics/7022054/T7022054neg2.out
+ test/tools/javac/generics/7022054/T7022054pos1.java
+ test/tools/javac/generics/7022054/T7022054pos2.java



hg: jdk7/tl/langtools: 7024212: TestWarnErrorCount fails

2011-03-03 Thread maurizio . cimadamore
Changeset: 8fb48a9ac9ec
Author:mcimadamore
Date:  2011-03-03 18:05 +
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8fb48a9ac9ec

7024212: TestWarnErrorCount fails
Summary: TestWarnErrorCount should be executed with -Xlint:all,-path to avoid 
spurious failures
Reviewed-by: jjg

! test/tools/javac/processing/TestWarnErrorCount.java



Re: URLConnection.guessContentTypeFromStream() does not support UTF8 and UTF32 with BOM

2011-03-03 Thread Charles Lee

On 03/03/2011 12:48 AM, Alan Bateman wrote:

Charles Lee wrote:

Hi guys,

With test case[1] below, you can see guessContent does not support 
UTF8/32 BOM. 
I don't see a problem with this proposal but I just wonder if this 
method is even used these days. It is a legacy method and I don't 
think anyone can rely on it to reliably detect any content type. I'm 
curious how you ran into this, was it a test or custom protocol 
handler that overrides getContentType and uses 
guessContentTypeFromStream as a fallback?


-Alan.

Hi Alan,

Sorry for the late reply. This test case comes from a big test case, 
which test more types of stream. I am not sure if no one use it. But 
from the spec:


/Ideally, this routine would not be needed. But many |http| servers 
return the incorrect content type; in addition, there are many 
nonstandard extensions. Direct inspection of the bytes to determine the 
content type is often more accurate than believing the content type 
claimed by the |http| server.


/guessContentTypeFromStream is needed as a fallback.