Re: Request to backport 6644726
On 11:35 Fri 11 Feb , Joe Darcy wrote:
> Networking team,
>
> Any comments on backporting this change to OpenJDK 6? My inclination is
> to approve the backport, but I want your input on the issue.
>
> -Joe
>
> On 2/8/2011 1:19 AM, Florian Weimer wrote:
> > This change:
> >
> > # User jccollet
> > # Date 1208423133 -7200
> > # Node ID d44e3bf49ffbcbc5c6ce9a8fa4113153f8368a60
> > # Parent a954a6f3be6fa69014f00488f52b2da12e6634bf
> > 6644726: Cookie management issues
> > Summary: Many changes to accomodate RFC 2965 and old Netscape specs
> > Reviewed-by: chegar
> >
> > diff -r a954a6f3be6f -r d44e3bf49ffb
> > src/share/classes/java/net/CookieManager.java
> > --- a/src/share/classes/java/net/CookieManager.java Wed Apr 16 14:17:54
> > 2008 +0100
> > +++ b/src/share/classes/java/net/CookieManager.java Thu Apr 17 11:05:33
> > 2008 +0200
> > @@ -205,11 +205,31 @@
> > if (cookieJar == null)
> > return Collections.unmodifiableMap(cookieMap);
> >
> > +boolean secureLink = "https".equalsIgnoreCase(uri.getScheme());
> > List cookies = new java.util.ArrayList();
> > +String path = uri.getPath();
> > +if (path == null || path.isEmpty()) {
> > +path = "/";
> > +}
> > for (HttpCookie cookie : cookieJar.get(uri)) {
> > // apply path-matches rule (RFC 2965 sec. 3.3.4)
> > -if (pathMatches(uri.getPath(), cookie.getPath())) {
> > -cookies.add(cookie);
> > +// and check for the possible "secure" tag (i.e. don't send
> > +// 'secure' cookies over unsecure links)
> > +if (pathMatches(path, cookie.getPath())&&
> > +(secureLink || !cookie.getSecure())) {
> > [...]
> >
> > is arguably a security fix (sending HTTPS-only cookies over HTTP is a
> > problem). The whole patch seems to be quite important for
> > interoperability. (Further changes from JDK 7 and maybe even new
> > development may be required to get cookie support working; I will
> > check that if backporting such changes is fine in principle.)
> >
>
This is only a fragment of 6644726. Please only use the existing bug ID
if the whole patch is going to be backported.
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
hg: jdk7/tl/jdk: 6637230: 2/3 jps doesn't work for application waiting for direct attach
Changeset: b04e86b3e27e Author:dcubed Date: 2011-02-14 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b04e86b3e27e 6637230: 2/3 jps doesn't work for application waiting for direct attach Summary: Properly handle exceptions thrown when querying a monitored VM. Reviewed-by: dsamersoff, swamyv ! src/share/classes/sun/tools/jps/Jps.java
Re: Request to backport 6644726
Dr Andrew John Hughes wrote: On 11:35 Fri 11 Feb , Joe Darcy wrote: Networking team, Any comments on backporting this change to OpenJDK 6? My inclination is to approve the backport, but I want your input on the issue. -Joe On 2/8/2011 1:19 AM, Florian Weimer wrote: [snip] This is only a fragment of 6644726. Please only use the existing bug ID if the whole patch is going to be backported. Yes, good point Andrew. The entire patch should be considered for backporting (or not). Chris, please confirm the entire patch is suitable for porting to OpenJDK 6. Thanks, -Joe
hg: jdk7/tl/jdk: 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx)
Changeset: fefc740bff52 Author:alanb Date: 2011-02-14 18:30 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fefc740bff52 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx) Reviewed-by: forax ! test/java/nio/file/Files/walkFileTree/PrintFileTree.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 28037efa90a3 Author:mduigou Date: 2011-02-14 10:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28037efa90a3 6934356: Vector.writeObject() serialization may deadlock Summary: No longer synchronize on self while writing other objects. Reviewed-by: alanb, forax, mduigou, peterjones Contributed-by: Neil Richards ! src/share/classes/java/util/Vector.java + test/java/util/Vector/SerializationDeadlock.java + test/java/util/Vector/SimpleSerialization.java Changeset: 2633daa325ed Author:mduigou Date: 2011-02-14 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2633daa325ed Merge
hg: jdk7/tl/jdk: 6927486: Hashtable writeObject() may deadlock
Changeset: 338c5b815ff2 Author:mduigou Date: 2011-02-14 11:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/338c5b815ff2 6927486: Hashtable writeObject() may deadlock Summary: Do not synchronize on self while writing hash table elements Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java/util/Hashtable.java + test/java/util/Hashtable/SerializationDeadlock.java + test/java/util/Hashtable/SimpleSerialization.java
hg: jdk7/tl/jdk: 7018897: CertPath validation cannot handle self-signed cert with bad KeyUsage
Changeset: 44c99f30f9df Author:xuelei Date: 2011-02-14 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44c99f30f9df 7018897: CertPath validation cannot handle self-signed cert with bad KeyUsage Summary: Remove KeyUsage checking for trust anchors Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java
hg: jdk7/tl/langtools: 7008433: Minor copyright changes
Changeset: ef6c66215a93 Author:jjg Date: 2011-02-14 14:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ef6c66215a93 7008433: Minor copyright changes Reviewed-by: jjg Contributed-by: kelly.oh...@oracle.com ! test/tools/javac/4917091/Test255.java ! test/tools/javac/4917091/Test256a.java ! test/tools/javac/4917091/Test256b.java
hg: jdk7/tl/jdk: 7018928: test failure: sun/security/krb5/auto/SSL.java
Changeset: 9024288330c4 Author:weijun Date: 2011-02-15 12:11 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9024288330c4 7018928: test failure: sun/security/krb5/auto/SSL.java Reviewed-by: valeriep ! test/sun/security/krb5/auto/BadKdc1.java ! test/sun/security/krb5/auto/BadKdc2.java ! test/sun/security/krb5/auto/BadKdc3.java ! test/sun/security/krb5/auto/BadKdc4.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/CrossRealm.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/IgnoreChannelBinding.java ! test/sun/security/krb5/auto/KerberosHashEqualsTest.java ! test/sun/security/krb5/auto/LifeTimeInSeconds.java ! test/sun/security/krb5/auto/LoginModuleOptions.java ! test/sun/security/krb5/auto/MaxRetries.java ! test/sun/security/krb5/auto/MoreKvno.java ! test/sun/security/krb5/auto/NewSalt.java ! test/sun/security/krb5/auto/NonMutualSpnego.java ! test/sun/security/krb5/auto/SSL.java ! test/sun/security/krb5/auto/SpnegoReqFlags.java ! test/sun/security/krb5/auto/Test5653.java
