Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi
On 01/20/11 04:33 PM, Alan Bateman wrote: ... One small suggestion is to rename B6442088.java while you are there (it looks odd given that the rest of the tests have proper names). All tests now have "real" names, and I updated the @build to @compile to compile with -XDignore.symbol.file=true, for source that uses sun private APIs. http://cr.openjdk.java.net/~chegar/7012768/webrev.02/webrev/ -Chris. -Alan.
Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi
Chris Hegarty wrote: On 01/20/11 04:33 PM, Alan Bateman wrote: ... One small suggestion is to rename B6442088.java while you are there (it looks odd given that the rest of the tests have proper names). All tests now have "real" names, and I updated the @build to @compile to compile with -XDignore.symbol.file=true, for source that uses sun private APIs. http://cr.openjdk.java.net/~chegar/7012768/webrev.02/webrev/ -Chris. Thanks for doing this. Thumbs up from me. -Alan.
Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi
Alan Bateman wrote: Chris Hegarty wrote: On 01/20/11 04:33 PM, Alan Bateman wrote: ... One small suggestion is to rename B6442088.java while you are there (it looks odd given that the rest of the tests have proper names). All tests now have "real" names, and I updated the @build to @compile to compile with -XDignore.symbol.file=true, for source that uses sun private APIs. http://cr.openjdk.java.net/~chegar/7012768/webrev.02/webrev/ -Chris. Thanks for doing this. Thumbs up from me. -Alan. Me too. - Michael
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 2a8d1a0a2418 Author:chegar Date: 2011-01-21 17:02 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a8d1a0a2418 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi Reviewed-by: alanb, michaelm ! src/share/classes/java/net/InetAddress.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/chaining/Providers.java + test/sun/net/InetAddress/nameservice/chaining/Simple1NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/Simple2NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/SimpleNameService.java + test/sun/net/InetAddress/nameservice/deadlock/Hang.java + test/sun/net/InetAddress/nameservice/deadlock/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameService.java + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/simple/CacheTest.java + test/sun/net/InetAddress/nameservice/simple/DefaultCaching.java + test/sun/net/InetAddress/nameservice/simple/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/simple/SimpleNameService.java + test/sun/net/InetAddress/nameservice/simple/SimpleNameServiceDescriptor.java Changeset: 6a7b8406a1b9 Author:chegar Date: 2011-01-21 17:04 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a7b8406a1b9 Merge
hg: jdk7/tl/jdk: 2 new changesets
Changeset: f26d1a7fe4d2 Author:mchung Date: 2011-01-21 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f26d1a7fe4d2 6912013: Remove the temporary launcher fix to add modules in the bootclasspath Reviewed-by: ksrini ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/classes/sun/launcher/LauncherHelper.java Changeset: 9c18818e7a5f Author:mchung Date: 2011-01-21 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c18818e7a5f Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 2381e810330b Author:zgu Date: 2011-01-20 10:45 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2381e810330b 6983248: net/net001 and net/net003 fail on WinXP with JDK7-B108 Summary: Using closesocket to close socket handler to avoid invalid C runtime parameter exception. Reviewed-by: alanb, phh, dcubed, dsamersoff, coleenp, acorn ! src/windows/demo/jvmti/hprof/hprof_md.c Changeset: d03e47de3a89 Author:zgu Date: 2011-01-21 11:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d03e47de3a89 Merge
