Code Review 7004439: SCTP_SET_PEER_PRIMARY_ADDR throws SocketException on Linux

2010-12-08 Thread Chris Hegarty

Hi Michael,

The native sockaddr is not being correctly set in sctp_setpeerprim. 
Also, the value of SCTP_SET_PEER_PRIMARY_ADDR should not be an 
IPv4-mapped address for IPv4 addresses on lksctp. It should be an IPv4 
address, in a similar way to how we handle addresses being passed to bindx.


Webrev:
  http://cr.openjdk.java.net/~chegar/7004439/webrev.00/webrev/

Thanks,
-Chris.


Re: Code Review 7004439: SCTP_SET_PEER_PRIMARY_ADDR throws SocketException on Linux

2010-12-08 Thread Michael McMahon

Chris Hegarty wrote:

Hi Michael,

The native sockaddr is not being correctly set in sctp_setpeerprim. 
Also, the value of SCTP_SET_PEER_PRIMARY_ADDR should not be an 
IPv4-mapped address for IPv4 addresses on lksctp. It should be an IPv4 
address, in a similar way to how we handle addresses being passed to 
bindx.


Webrev:
  http://cr.openjdk.java.net/~chegar/7004439/webrev.00/webrev/

Thanks,
-Chris.

Looks fine.

Thanks
Michael.


hg: jdk7/tl/jdk: 6998860: Signed jar file verification is currently creating many extra new Sun providers.

2010-12-08 Thread sean . mullan
Changeset: 291128e77395
Author:mullan
Date:  2010-12-08 10:21 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/291128e77395

6998860: Signed jar file verification is currently creating many extra new Sun 
providers.
Reviewed-by: mchung

! src/share/classes/sun/security/util/ManifestEntryVerifier.java



hg: jdk7/tl/jdk: 6977034: Thread.getState() very slow

2010-12-08 Thread mandy . chung
Changeset: acce526a49a7
Author:mchung
Date:  2010-12-08 10:45 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/acce526a49a7

6977034: Thread.getState() very slow
Summary: Directly map the threadStatus value to Thread.State
Reviewed-by: emcmanus, dholmes

! src/share/classes/java/lang/Thread.java
! src/share/classes/sun/misc/VM.java



hg: jdk7/tl/jdk: 6527572: (cs) Charset.forName can throw NullPointerException when testing bug level

2010-12-08 Thread xueming . shen
Changeset: 01b6d147db50
Author:sherman
Date:  2010-12-08 12:15 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01b6d147db50

6527572: (cs) Charset.forName can throw NullPointerException when testing bug 
level
Summary: fixed the race condition
Reviewed-by: alanb

! src/share/classes/java/nio/charset/Charset.java



hg: jdk7/tl/jdk: 6415373: (cs) UnicodeEncoder emits BOM when there are no bytes to encode

2010-12-08 Thread xueming . shen
Changeset: 956de70712e0
Author:sherman
Date:  2010-12-08 12:54 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/956de70712e0

6415373: (cs) UnicodeEncoder emits BOM when there are no bytes to encode
Summary: no BOM output if no byte to encode
Reviewed-by: alanb

! src/share/classes/sun/nio/cs/UTF_32Coder.java
! src/share/classes/sun/nio/cs/UnicodeEncoder.java
+ test/sun/nio/cs/EncodingNothing.java



hg: jdk7/tl/langtools: 7004698: javap does not output CharacterRangeTable attributes correctly

2010-12-08 Thread jonathan . gibbons
Changeset: acb02e1d5119
Author:jjg
Date:  2010-12-08 13:42 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/acb02e1d5119

7004698: javap does not output CharacterRangeTable attributes correctly
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javap/AttributeWriter.java
+ test/tools/javap/T7004698.java



hg: jdk7/tl/corba: 6877056: SVUID calculated for java.lang.Enum is not 0L

2010-12-08 Thread abhi . saha
Changeset: 5d9708346d50
Author:miroslawzn
Date:  2010-12-08 10:43 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/corba/rev/5d9708346d50

6877056: SVUID calculated for java.lang.Enum is not 0L
Reviewed-by: raginip

! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java



hg: jdk7/tl/jdk: 5076980: (fmt) FormattableFlags specifies unsupported '^' format flag

2010-12-08 Thread xueming . shen
Changeset: 03513756704c
Author:sherman
Date:  2010-12-08 20:11 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03513756704c

5076980: (fmt) FormattableFlags specifies unsupported '^' format flag
Summary: replaced '^' with 'S' in spec
Reviewed-by: darcy

! src/share/classes/java/util/FormattableFlags.java



hg: jdk7/tl/langtools: 7003550: Loosen modeling requirements for annotation processing erroneous code

2010-12-08 Thread joe . darcy
Changeset: 23fc45d3a572
Author:darcy
Date:  2010-12-08 21:21 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/23fc45d3a572

7003550: Loosen modeling requirements for annotation processing erroneous code
Reviewed-by: jjg

! src/share/classes/javax/lang/model/element/package-info.java