hg: jdk7/tl/jdk: 6968584: Thread should not be Cloneable
Changeset: fd28003bc1d6 Author:chegar Date: 2010-08-23 14:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd28003bc1d6 6968584: Thread should not be Cloneable Reviewed-by: dholmes ! src/share/classes/java/lang/Thread.java
hg: jdk7/tl/jdk: 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe
Changeset: 03218163f4d5 Author:chegar Date: 2010-08-23 16:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03218163f4d5 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java
Code Review 6977851: NPE from FileURLConnection.connect
Michael, The file handler can fail with NPE in cases where permission is denied to the directory. Small change, throw FileNotFoundException where a directory listing is not available. Webrev: http://cr.openjdk.java.net/~chegar/6977851/webrev.00/webrev/ Thanks, -Chris.
hg: jdk7/tl/langtools: 2 new changesets
Changeset: 995bcdb9a41d Author:mcimadamore Date: 2010-08-23 16:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/995bcdb9a41d 6932571: Compiling Generics causing Inconvertible types Summary: Types.rewriteQuantifiers() does not work well with recursive type-variable bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6270087/T6270087.java + test/tools/javac/cast/6270087/T6270087neg.java + test/tools/javac/cast/6270087/T6270087neg.out + test/tools/javac/cast/6507317/T6507317.java + test/tools/javac/cast/6569057/T6569057.java + test/tools/javac/cast/6932571/T6932571a.java + test/tools/javac/cast/6932571/T6932571b.java + test/tools/javac/cast/6932571/T6932571neg.java + test/tools/javac/cast/6932571/T6932571neg.out Changeset: 594b3c2ef585 Author:mcimadamore Date: 2010-08-23 17:00 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/594b3c2ef585 6978574: return statement in try block with multi-catch causes ClassFormatError Summary: Wrong nested loops in Gen.java causes javac to generate bad bytecode Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/multicatch/T6978574.java
Re: Code Review 6977851: NPE from FileURLConnection.connect
Chris Hegarty wrote: Michael, The file handler can fail with NPE in cases where permission is denied to the directory. Small change, throw FileNotFoundException where a directory listing is not available. Webrev: http://cr.openjdk.java.net/~chegar/6977851/webrev.00/webrev/ Thanks, -Chris. One minor comment, and maybe it's not worth the hassle. But, when file.list() returns null, you could call file.exists() and then use the result of that to customise the exception text. false ==> new FileNotFoundException (filename); true ==> new FileNotFoundException(filename + " exists, but is not accessible"); - Michael
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 47ab0dcec3e8 Author:alanb Date: 2010-08-23 17:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/47ab0dcec3e8 6978511: (file) Path.toRealPath should fail if not resolving links and file does not exist Reviewed-by: forax, chegar ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/nio/file/Path/Misc.java Changeset: f4a2b4e7a831 Author:alanb Date: 2010-08-23 17:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4a2b4e7a831 6431344: (fc) FileChannel.transferTo() doesn't work if address space runs out Reviewed-by: forax, chegar ! src/share/classes/sun/nio/ch/FileChannelImpl.java
Re: Code Review 6977851: NPE from FileURLConnection.connect
Michael McMahon wrote: Chris Hegarty wrote: Michael, The file handler can fail with NPE in cases where permission is denied to the directory. Small change, throw FileNotFoundException where a directory listing is not available. Webrev: http://cr.openjdk.java.net/~chegar/6977851/webrev.00/webrev/ Thanks, -Chris. One minor comment, and maybe it's not worth the hassle. But, when file.list() returns null, you could call file.exists() and then use the result of that to customise the exception text. false ==> new FileNotFoundException (filename); true ==> new FileNotFoundException(filename + " exists, but is not accessible"); I agree, a more descriptive message is always a good thing. Actually, we don't even need to call exists because isDirectory ( called a few lines before ) will only return true if the file denoted by the abstract pathname exists and is a directory; so we know already that it must exist. I wonder what other issues there may be that would cause list to return null? Actually, your extended message description seem generic enough to cover most. I think I'll go with your message. -Chris. - Michael
hg: jdk7/tl/langtools: 6975005: improve JavacProcessingEnvironment.Round abstraction
Changeset: 6b95dd682538 Author:jjg Date: 2010-08-23 11:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6b95dd682538 6975005: improve JavacProcessingEnvironment.Round abstraction Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/T6358024.java ! test/tools/javac/T6403466.out ! test/tools/javac/processing/filer/TestLastRound.out
hg: jdk7/tl/jdk: 6531345: Memory leak in unpack200
Changeset: 6317f7e2c4fd Author:ksrini Date: 2010-08-23 08:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6317f7e2c4fd 6531345: Memory leak in unpack200 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java + test/tools/pack200/UnpackerMemoryTest.java ! test/tools/pack200/Utils.java
hg: jdk7/tl/jdk: 6977851: NPE from FileURLConnection.connect
Changeset: cb67f0263bd4 Author:chegar Date: 2010-08-23 21:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb67f0263bd4 6977851: NPE from FileURLConnection.connect Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/file/FileURLConnection.java + test/sun/net/www/protocol/file/DirPermissionDenied.java + test/sun/net/www/protocol/file/DirPermissionDenied.sh
hg: jdk7/tl/langtools: 6976747: JCDiagnostic: replace "boolean mandatory" with new "Set"
Changeset: a626d8c1de6e Author:jjg Date: 2010-08-23 15:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a626d8c1de6e 6976747: JCDiagnostic: replace "boolean mandatory" with new "Set" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 2585368bfc7c Author:ksrini Date: 2010-08-23 10:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2585368bfc7c 6969063: (pack200) The default value of Pack200.Packer.SEGMENT_LIMIT property is empty string instead of -1 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java + test/tools/pack200/Pack200Props.java - test/tools/pack200/SegmentLimit.java Changeset: 732f59013e78 Author:ksrini Date: 2010-08-23 10:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/732f59013e78 6966740: (pack200) need to add the timezone regression test Reviewed-by: jrose + test/tools/pack200/TimeStamp.java ! test/tools/pack200/Utils.java
