Request for Review: 6916922
see discussion on sctp-dev: http://mail.openjdk.java.net/pipermail/sctp-dev/2010-January/000151.html Essentially, on Linux SO_SNDBUF/SO_RCVBUF aren't symmetric. This stems from additional socket structures in the send and receive buffers. Net_GetSockOpt handles this by dividing the retrieved values by 2. CR 6916922: SO_RCVBUF & SO_SNDBUF returns twice the value set Webrev: http://cr.openjdk.java.net/~chegar/6916922/webrev.0/webrev/ -Chris.
Request for review: 6916890
In the case where a heap buffer is supplied the implementation copies the data into a temporary native buffer before going native. The position and remaining data is incorrectly determined for this temporary buffer when the position of the original buffer is not 0. Also, remove incorrect assertion from implementation. CR 6916890: SctpChannel.send may cause IAE if given a heap buffer with an offset Webrev: http://cr.openjdk.java.net/~chegar/6916890/webrev.0/webrev/ Thanks, -Chris.
Re: Request for Review: 6916922
Christopher Hegarty -Sun Microsystems Ireland wrote: see discussion on sctp-dev: http://mail.openjdk.java.net/pipermail/sctp-dev/2010-January/000151.html Essentially, on Linux SO_SNDBUF/SO_RCVBUF aren't symmetric. This stems from additional socket structures in the send and receive buffers. Net_GetSockOpt handles this by dividing the retrieved values by 2. CR 6916922: SO_RCVBUF & SO_SNDBUF returns twice the value set Webrev: http://cr.openjdk.java.net/~chegar/6916922/webrev.0/webrev/ -Chris. Good okay to me. -Alan.
hg: jdk7/tl/jdk: 6916922: (sctp) SO_RCVBUF & SO_SNDBUF returns twice the value set
Changeset: b019cdae32dd Author:chegar Date: 2010-01-15 16:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b019cdae32dd 6916922: (sctp) SO_RCVBUF & SO_SNDBUF returns twice the value set Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/SctpNet.c ! test/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java
hg: jdk7/tl: Added tag jdk7-b79 for changeset 20aeeb517139
Changeset: b1952d19290d Author:katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b1952d19290d Added tag jdk7-b79 for changeset 20aeeb517139 ! .hgtags
hg: jdk7/tl/corba: Added tag jdk7-b79 for changeset ec0421b5703b
Changeset: fdbc85b2d15c Author:katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/fdbc85b2d15c Added tag jdk7-b79 for changeset ec0421b5703b ! .hgtags
hg: jdk7/tl/hotspot: 74 new changesets
Changeset: f334aec453a1 Author:kvn Date: 2009-10-29 16:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f334aec453a1 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks Summary: Set narrow_oop_base and narrow_oop_use_implicit_null_checks in Universe::preferred_heap_base(). Reviewed-by: twisti, jcoomes ! src/share/vm/memory/universe.cpp Changeset: 73a726751507 Author:cfang Date: 2009-10-30 10:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/73a726751507 6852078: HSX 14/16 in jdk 5.0: api/javax_management api/org_omg jck tests crashes or make tnameserv crash Summary: Disable SuperWord optimization for unsafe read/write Reviewed-by: kvn, phh ! src/share/vm/opto/superword.cpp + test/compiler/6852078/Test6852078.java Changeset: 389049f3f393 Author:jrose Date: 2009-10-30 16:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/389049f3f393 6858164: invokedynamic code needs some cleanup (post-6655638) Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl Reviewed-by: kvn ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/generateOopMap.cpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/methodHandles.cpp Changeset: 323bd24c6520 Author:roland Date: 2009-11-02 11:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/323bd24c6520 6769124: various 64-bit fixes for c1 Reviewed-by: never ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/runtime/arguments.cpp + test/compiler/6769124/TestArrayCopy6769124.java + test/compiler/6769124/TestDeoptInt6769124.java + test/compiler/6769124/TestUnalignedLoad6769124.java Changeset: 09572fede9d1 Author:kvn Date: 2009-11-04 14:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/09572fede9d1 6896370: CTW fails share/vm/opto/matcher.cpp:1475 "duplicating node that's already been matched" Summary: Move DecodeN code outside the memory nodes only code. Reviewed-by: never ! src/share/vm/opto/matcher.cpp Changeset: dcdcc8c16e20 Author:kvn Date: 2009-11-04 14:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/dcdcc8c16e20 6896352: CTW fails hotspot/src/share/vm/opto/escape.cpp:1155 Summary: Always call C->get_alias_index(phase->type(address)) during parsing. Reviewed-by: never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/memnode.cpp Changeset: 2f1ec89b9995 Author:cfang Date: 2009-11-10 17:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2f1ec89b9995 Merge ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp Changeset: 473cce303f13 Author:phh Date: 2009-10-28 16:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/473cce303f13 6887571: Increase default heap config sizes Summary: Apply modification of existing server heap size ergo to all collectors except CMS. Reviewed-by: jmasa, ysr, xlu ! src/cpu/sparc/vm/c1_globals_sparc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/c1_globals_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp ! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp ! src/share/vm/gc_implementation/pa
hg: jdk7/tl/jaxp: Added tag jdk7-b79 for changeset b1005c504358
Changeset: 9219574db593 Author:katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/9219574db593 Added tag jdk7-b79 for changeset b1005c504358 ! .hgtags
hg: jdk7/tl/jaxws: Added tag jdk7-b79 for changeset c08894f5b6e5
Changeset: 447767dee56a Author:katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/447767dee56a Added tag jdk7-b79 for changeset c08894f5b6e5 ! .hgtags
hg: jdk7/tl/jdk: 7 new changesets
Changeset: 9c352f7ed4a3 Author:jrose Date: 2009-10-21 23:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c352f7ed4a3 6891770: JSR 292 API needs initial unit tests Summary: backport working mlvm regression test to M3 implementation of JSR 292; requires jtreg 4.1 Reviewed-by: twisti + test/java/dyn/MethodHandlesTest.java Changeset: fc3d21b50545 Author:jrose Date: 2010-01-06 16:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc3d21b50545 Merge Changeset: dbcf6cafa65c Author:jrose Date: 2010-01-07 16:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbcf6cafa65c 6914665: update jdk code for JSR 292 (post 6858164) Summary: Fill in missing API implementations, fix numerous bugs, adjust APIs towards EG design. Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/InvokeDynamic.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/JavaMethodHandle.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/LinkagePermission.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/BoundMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/MethodTypeImpl.java + src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/empty/Empty.java + src/share/classes/sun/dyn/util/BytecodeDescriptor.java ! src/share/classes/sun/dyn/util/BytecodeName.java - src/share/classes/sun/dyn/util/BytecodeSignature.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! src/share/classes/sun/dyn/util/VerifyType.java ! src/share/classes/sun/dyn/util/Wrapper.java ! test/java/dyn/MethodHandlesTest.java Changeset: 918920710d65 Author:jcoomes Date: 2010-01-13 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/918920710d65 Merge - src/share/classes/sun/dyn/util/BytecodeSignature.java Changeset: 756ab2266ffb Author:katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/756ab2266ffb Added tag jdk7-b79 for changeset 918920710d65 ! .hgtags Changeset: b428c8f80209 Author:jgodinez Date: 2010-01-15 09:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b428c8f80209 6915906: tests in closed/javax/print/ should not be calling System.exit() Reviewed-by: igor, prr ! test/ProblemList.txt + test/javax/print/DialogMargins.java + test/javax/print/StreamPrintingOrientation.java + test/javax/print/attribute/AttributeTest.java + test/javax/print/attribute/ServiceDialogTest.java ! test/javax/print/attribute/SidesPageRangesTest.java Changeset: 64f7b789aecc Author:lana Date: 2010-01-15 15:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/64f7b789aecc Merge - src/share/classes/sun/dyn/util/BytecodeSignature.java
hg: jdk7/tl/langtools: 2 new changesets
Changeset: f0074aa48d4e Author:katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f0074aa48d4e Added tag jdk7-b79 for changeset ac5b4c5644ce ! .hgtags Changeset: a84062774f0e Author:lana Date: 2010-01-15 15:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a84062774f0e Merge