hg: jdk7/tl/jdk: 2 new changesets

2010-01-10 Thread alan . bateman
Changeset: 755dd6bdccca
Author:alanb
Date:  2010-01-09 19:32 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/755dd6bdccca

6907760: (file) OVERFLOW event should cause pending events to be purged
Reviewed-by: chegar

! src/share/classes/sun/nio/fs/AbstractWatchKey.java
+ test/java/nio/file/WatchService/OverflowEventIsLoner.java

Changeset: 0f0aee89e282
Author:alanb
Date:  2010-01-10 12:29 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f0aee89e282

6913877: (fs) AsynchronousFileChannel.write can return wrong result under load 
[win]
Reviewed-by: chegar

! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java
! src/windows/native/sun/nio/ch/WindowsAsynchronousFileChannelImpl.c
+ test/java/nio/channels/AsynchronousFileChannel/LotsOfWrites.java



Re: Request for Review: 6915313

2010-01-10 Thread Alan Bateman

Christopher Hegarty - Sun Microsystems Ireland wrote:

Hi,

We have received several requests about porting the SCTP API to JDK6. 
This bug aims to amend the current implementation to minimize the 
amount of changes required to port it to JDK6.


1) Remove JDK7 API dependences from the implementation
2) provide all native functionality within libsctp.so

6915313: (sctp) Reorganize implementation to make it more feasible to 
port to JDK6


Webrev:
  http://cr.openjdk.java.net/~chegar/6915313/webrev.0/webrev/

Thanks,
-Chris.
If I understand correctly, you're trying to help the folks that want to 
take this code and hack on it with jdk6 - is that right? Have you 
considered creating a page on the SCTP project with the recipe. Seems 
like removing the dependency on SocketOption and AlreadyBoundException 
are trivial and maybe there isn't a need to add commented out code. As 
the implementation is very tied to the selector implementation then I 
assume it's not an issue to keep the dependency on NativeDispatcher. 
That would avoid having to duplicate close/preClose at least. Otherwise 
looks okay to me.


-Alan.