Request for Review: 6915313

2010-01-08 Thread Christopher Hegarty - Sun Microsystems Ireland

Hi,

We have received several requests about porting the SCTP API to JDK6. 
This bug aims to amend the current implementation to minimize the amount 
of changes required to port it to JDK6.


1) Remove JDK7 API dependences from the implementation
2) provide all native functionality within libsctp.so

6915313: (sctp) Reorganize implementation to make it more feasible to 
port to JDK6


Webrev:
  http://cr.openjdk.java.net/~chegar/6915313/webrev.0/webrev/

Thanks,
-Chris.


Re: Request for Review: 6915313

2010-01-08 Thread Andrew John Hughes
2010/1/8 Christopher Hegarty - Sun Microsystems Ireland
:
> Hi,
>
> We have received several requests about porting the SCTP API to JDK6. This
> bug aims to amend the current implementation to minimize the amount of
> changes required to port it to JDK6.
>
> 1) Remove JDK7 API dependences from the implementation
> 2) provide all native functionality within libsctp.so
>
> 6915313: (sctp) Reorganize implementation to make it more feasible to port
> to JDK6
>
> Webrev:
>  http://cr.openjdk.java.net/~chegar/6915313/webrev.0/webrev/
>
> Thanks,
> -Chris.
>

For OpenJDK6, I think it would be better to port over SCTP after the
b18 release which is currently undergoing final testing.  So please
don't push anything to the OpenJDK6 repositories just yet :-)
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


Re: Request for Review: 6915313

2010-01-08 Thread Christopher Hegarty - Sun Microsystems Ireland


On 08/01/2010 16:32, Andrew John Hughes wrote:



For OpenJDK6, I think it would be better to port over SCTP after the
b18 release which is currently undergoing final testing.  So please
don't push anything to the OpenJDK6 repositories just yet :-)


Oh, maybe the bug description is a little misleading. What this bug 
plans to do is simply reorganize the SCTP implementation in JDK7 so that 
it can be ripped out and bolted onto a standard Sun JDK6 (if that's the 
kind of thing you like to do!). There are no changes planned for 
OpenJDK6, just JDK7.


-Chris.


hg: jdk7/tl/langtools: 6878147: Keywords.log is declared and initialized but unused

2010-01-08 Thread jonathan . gibbons
Changeset: c315df443ff2
Author:jjg
Date:  2010-01-08 11:11 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c315df443ff2

6878147: Keywords.log is declared and initialized but unused
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/parser/Keywords.java



hg: jdk7/tl/langtools: 6878146: incorrect unused value should be deleted

2010-01-08 Thread jonathan . gibbons
Changeset: 2d15bf467aea
Author:jjg
Date:  2010-01-08 11:16 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2d15bf467aea

6878146: incorrect unused value should be deleted
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java



hg: jdk7/tl/langtools: 6665791: com.sun.source.tree.MethodTree.toString() does not output default values

2010-01-08 Thread jonathan . gibbons
Changeset: 0e75f9f6d1d4
Author:jjg
Date:  2010-01-08 11:28 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0e75f9f6d1d4

6665791: com.sun.source.tree.MethodTree.toString() does not output default 
values
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/tree/Pretty.java
+ test/tools/javac/T6665791.java



hg: jdk7/tl/langtools: 6915078: ALT_JDK_IMPORT_PATH typo in langtools/make/Makefile

2010-01-08 Thread jonathan . gibbons
Changeset: aa06467be3a2
Author:jjg
Date:  2010-01-08 11:32 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/aa06467be3a2

6915078: ALT_JDK_IMPORT_PATH typo in langtools/make/Makefile
Reviewed-by: tbell

! make/Makefile



hg: jdk7/tl/langtools: 6915152: langtools build failures with import.jdk on Windows

2010-01-08 Thread jonathan . gibbons
Changeset: 96c56220dcc2
Author:jjg
Date:  2010-01-08 13:14 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/96c56220dcc2

6915152: langtools build failures with import.jdk on Windows
Reviewed-by: ohair

! make/build.xml