Request for Review 6882384
6882384: Update http protocol handler to use PlatformLogger Webrev: http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/ Change http logging to use the PlatformLogger. We can simply remove the reflective calls to the logging API from HttpCapture as the PlatformLogger will take care of that for us. -Chris.
Re: Request for Review 6882384
Christopher Hegarty - Sun Microsystems Ireland wrote: 6882384: Update http protocol handler to use PlatformLogger Webrev: http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/ Change http logging to use the PlatformLogger. We can simply remove the reflective calls to the logging API from HttpCapture as the PlatformLogger will take care of that for us. -Chris. Looks good to me. <>
Re: Request for Review 6882384
Christopher Hegarty - Sun Microsystems Ireland wrote: 6882384: Update http protocol handler to use PlatformLogger Webrev: http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/ Change http logging to use the PlatformLogger. We can simply remove the reflective calls to the logging API from HttpCapture as the PlatformLogger will take care of that for us. -Chris. Looks good to me (and I see you've fixed a delegation issue in PlatformLogger). Minor nit is that the indent seems to be messed up in HttpClient line 809. -Alan.
Re: Request for Review 6882384
On 22/09/2009 12:58, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: 6882384: Update http protocol handler to use PlatformLogger Webrev: http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/ Change http logging to use the PlatformLogger. We can simply remove the reflective calls to the logging API from HttpCapture as the PlatformLogger will take care of that for us. -Chris. Looks good to me (and I see you've fixed a delegation issue in PlatformLogger). Minor nit is that the indent seems to be messed up in HttpClient line 809. Ah yes, thanks Alan. It is now fixed. -Chris. -Alan.
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 023063a403ed Author:chegar Date: 2009-09-22 14:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/023063a403ed 6882654: Remove dependency on java.util.concurrent from KeepAlive implementaion Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java Changeset: 44ccaa4bb8a0 Author:chegar Date: 2009-09-22 14:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44ccaa4bb8a0 6882384: Update http protocol handler to use PlatformLogger Reviewed-by: jccollet, alanb ! src/share/classes/sun/net/www/http/HttpCapture.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/share/classes/sun/util/logging/PlatformLogger.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: b8004f6f4812 Author:kevinw Date: 2009-09-22 17:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8004f6f4812 6882768: (launcher) test for 6842838 is broken Summary: Testcase correction. Reviewed-by: ksrini ! test/tools/launcher/6842838/Test6842838.sh Changeset: f708138c9aca Author:kevinw Date: 2009-09-22 17:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f708138c9aca Merge
hg: jdk7/tl/jdk: 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes.
Changeset: c715b68cdcaf Author:darcy Date: 2009-09-22 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c715b68cdcaf 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes. Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: bbb543254c63 Author:martin Date: 2009-09-22 18:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbb543254c63 4245470: algorithm of java.lang.Byte.hashCode() is not specified Summary: Specify some hashCode methods are equivalent to intValue Reviewed-by: darcy ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Short.java + test/java/lang/HashCode.java Changeset: eb92c939b8a7 Author:martin Date: 2009-09-22 18:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb92c939b8a7 6582946: Add suite of compare(T, T) methods for ints, longs etc Reviewed-by: darcy Contributed-by: kev...@google.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java + test/java/lang/Compare.java
