hg: jdk7/tl/jdk: 6737819: sun.misc.net.DefaultProxySelector doesn't use proxy setting to localhost
Changeset: ee68feef41d2 Author:jccollet Date: 2009-09-18 10:51 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee68feef41d2 6737819: sun.misc.net.DefaultProxySelector doesn't use proxy setting to localhost Summary: Move default nonProxyHosts from hardcoded to property default value Reviewed-by: chegar ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/lib/net.properties + test/java/net/ProxySelector/B6737819.java
Re: Request for Review 6882594
On 17/09/2009 21:18, Alan Bateman wrote:
Christopher Hegarty -Sun Microsystems Ireland wrote:
Max (Weijun) Wang wrote:
HttpURLConnection.java:
I think "if (authScheme.equals(BASIC))" can be written as
"authScheme == BASIC", and possibly you can use switch/case in
several places
Thanks Max, these changes certainly make the code more readable.
Updated webrev can be found at:
http://cr.openjdk.java.net/~chegar/6882594/webrev.1/webrev/
This looks much better.
In HttpURLConnection there are a few places where there are have
expressions like
!(proxyAuthenitcation.getAuthScheme() == NTLM)
I assume this would be neater as:
(proxAuthenitcation.getAuthScheme() != NTLM)
Good catch! Done.
Are tryTransparentNTLMServer/Proxy needed? I'm not too familiar with the
NTLM code but it looks like they are always initialized to
NTLMAuthentication.supportsTransparentAuth which makes me wonder why the
code can't just be:
if (NTLMAuthentication.supportsTransparentAuth()) { ... }
What we're trying to do here is to check if the platform supports
transparent authentication and then try it once only (if transparent
fails it will prompt the user for credentials). I reuse the
tryTransparentNTLMServer/Proxy as it can have 3 states, null (first time
through), true, false.
If this looks a little messy/confusing I can swap it out use a pair of
booleans to represent this.
For the logging is it necessary to check the logger level? (just
wondering if HttpCapture can be called directly).
No I don't believe it is necessary to check the level, but I see this
kind of thing all the time (just recently when looking at Mandys
PlatformLogger webrevs). I don't see why we ever check the log level
since Logger.fine will do that anyway.
In NTLMAuthenticationProxy should you be using the 3-arg Class.forName?
You mean Class.forName(clazzStr, true, null), right? To force the class
to be loaded with the boot classloader. Ditto for Negotiate. Done.
Also, if the constructors aren't present then I would think it is a
fatal error.
Yes, good point. Now I log the CNFE and throw an AssertionError for
every thing else. Ditto for Negotiate. Done.
Updated webrev can be found at:
http://cr.openjdk.java.net/~chegar/6882594/webrev.1/webrev/
-Chris.
Otherwise looks okay to me.
-Alan.
Code review needed for 6873543
Here are my proposed changes to fix 6873543 (httpOnly cookies). Also took the opportunity to clarify the javadoc of a few methods. http://cr.openjdk.java.net/~jccollet/6873543/webrev.00/
Re: Request for Review 6882594
Christopher Hegarty - Sun Microsystems Ireland wrote:
On 17/09/2009 21:18, Alan Bateman wrote:
Christopher Hegarty -Sun Microsystems Ireland wrote:
Max (Weijun) Wang wrote:
HttpURLConnection.java:
I think "if (authScheme.equals(BASIC))" can be written as
"authScheme == BASIC", and possibly you can use switch/case in
several places
Thanks Max, these changes certainly make the code more readable.
Updated webrev can be found at:
http://cr.openjdk.java.net/~chegar/6882594/webrev.1/webrev/
This looks much better.
In HttpURLConnection there are a few places where there are have
expressions like
!(proxyAuthenitcation.getAuthScheme() == NTLM)
I assume this would be neater as:
(proxAuthenitcation.getAuthScheme() != NTLM)
Good catch! Done.
Are tryTransparentNTLMServer/Proxy needed? I'm not too familiar with
the NTLM code but it looks like they are always initialized to
NTLMAuthentication.supportsTransparentAuth which makes me wonder why
the code can't just be:
if (NTLMAuthentication.supportsTransparentAuth()) { ... }
What we're trying to do here is to check if the platform supports
transparent authentication and then try it once only (if transparent
fails it will prompt the user for credentials). I reuse the
tryTransparentNTLMServer/Proxy as it can have 3 states, null (first
time through), true, false.
If this looks a little messy/confusing I can swap it out use a pair of
booleans to represent this.
For the logging is it necessary to check the logger level? (just
wondering if HttpCapture can be called directly).
No I don't believe it is necessary to check the level, but I see this
kind of thing all the time (just recently when looking at Mandys
PlatformLogger webrevs). I don't see why we ever check the log level
since Logger.fine will do that anyway.
In NTLMAuthenticationProxy should you be using the 3-arg Class.forName?
You mean Class.forName(clazzStr, true, null), right? To force the
class to be loaded with the boot classloader. Ditto for Negotiate. Done.
Also, if the constructors aren't present then I would think it is a
fatal error.
Yes, good point. Now I log the CNFE and throw an AssertionError for
every thing else. Ditto for Negotiate. Done.
Updated webrev can be found at:
http://cr.openjdk.java.net/~chegar/6882594/webrev.1/webrev/
Looks reasonable to me. I see you've reverted
tryTransparentNTLMServer/Proxy to two booleans which makes it a bit
easier to understanding One small suggestion is to add a description to
NTLMAuthenticationProxy's static methods to make it easier for future
maintainers.
-Alan.
hg: jdk7/tl/jdk: 6882745: Add DISABLE_INTREE_EC option to make new EC provider optional.
Changeset: 39c15c0a71f7 Author:andrew Date: 2009-09-10 19:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/39c15c0a71f7 6882745: Add DISABLE_INTREE_EC option to make new EC provider optional. Summary: Don't build the ec subdirectory when DISABLE_INTREE_EC is defined. Reviewed-by: vinnie ! make/sun/security/Makefile
hg: jdk7/tl: Added tag jdk7-b72 for changeset 0d7e03b426df
Changeset: 4c4fe09fb670 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4c4fe09fb670 Added tag jdk7-b72 for changeset 0d7e03b426df ! .hgtags
hg: jdk7/tl/corba: Added tag jdk7-b72 for changeset c793a3120926
Changeset: 12991b453239 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/12991b453239 Added tag jdk7-b72 for changeset c793a3120926 ! .hgtags
hg: jdk7/tl/hotspot: Added tag jdk7-b72 for changeset a94714c55065
Changeset: 1e5f0e56d242 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e5f0e56d242 Added tag jdk7-b72 for changeset a94714c55065 ! .hgtags
hg: jdk7/tl/jaxp: Added tag jdk7-b72 for changeset 37c805b6156f
Changeset: 93dfa6e0fe76 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/93dfa6e0fe76 Added tag jdk7-b72 for changeset 37c805b6156f ! .hgtags
hg: jdk7/tl/jaxws: Added tag jdk7-b72 for changeset 4c990aa99bc0
Changeset: d79f0d601c2b Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d79f0d601c2b Added tag jdk7-b72 for changeset 4c990aa99bc0 ! .hgtags
hg: jdk7/tl/jdk: 2 new changesets
Changeset: f09a2bfba691 Author:xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f09a2bfba691 Added tag jdk7-b72 for changeset 460639b036f3 ! .hgtags Changeset: f119e21c0ca7 Author:tbell Date: 2009-09-18 08:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f119e21c0ca7 Merge
hg: jdk7/tl/langtools: 2 new changesets
Changeset: bfad32768345 Author:xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bfad32768345 Added tag jdk7-b72 for changeset 261c54b2312e ! .hgtags Changeset: 5dd400fd62d9 Author:tbell Date: 2009-09-18 08:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5dd400fd62d9 Merge
hg: jdk7/tl/jdk: 3 new changesets
Changeset: c9cbd2a09fd4 Author:chegar Date: 2009-09-18 16:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9cbd2a09fd4 6882609: Move default InMemoryCookieStore to java.net Summary: remove static dependency on sun.net.www.protocol.http Reviewed-by: alanb, jccollet ! make/sun/net/FILES_java.gmk ! src/share/classes/java/net/CookieManager.java + src/share/classes/java/net/InMemoryCookieStore.java - src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java Changeset: 9cd7133ea287 Author:chegar Date: 2009-09-18 22:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9cd7133ea287 6882594: Remove static dependancy on NTLM authentication Reviewed-by: alanb, weijun ! make/sun/net/FILES_java.gmk ! src/share/classes/sun/net/www/protocol/http/AuthCache.java ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java + src/share/classes/sun/net/www/protocol/http/AuthScheme.java ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java Changeset: 45a343706f73 Author:chegar Date: 2009-09-18 22:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/45a343706f73 Merge
hg: jdk7/tl/jdk: 2 new changesets
Changeset: d3281fa8e46c Author:mchung Date: 2009-09-17 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3281fa8e46c 6882376: Add internal support for JRE implementation to eliminate the dependency on logging Summary: Added sun.util.logging.PlatformLogger for JRE implementation to log messages. Reviewed-by: alanb, naoto ! make/java/logging/Makefile ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java + src/share/classes/sun/util/logging/PlatformLogger.java ! src/windows/classes/java/util/prefs/WindowsPreferences.java + test/sun/util/logging/PlatformLoggerTest.java Changeset: 7b4e73ca6fd7 Author:mchung Date: 2009-09-18 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b4e73ca6fd7 Merge
