CR 6667108 code review
CR 6667108: "typo in javadoc for java.net.Socket.getRemoteSocketAddress()" Trivial cleanup of a typo in getRemoteSocketAddress specification. diff -r fa6948bdc4b0 src/share/classes/java/net/Socket.java --- a/src/share/classes/java/net/Socket.javaThu Mar 06 10:35:28 2008 -0800 +++ b/src/share/classes/java/net/Socket.javaFri Mar 07 09:51:14 2008 + @@ -731,7 +731,7 @@ class Socket implements java.io.Closeabl * then this method will continue to return the connected address * after the socket is closed. * - * @return a SocketAddress reprensenting the remote endpoint of this + * @return a SocketAddress representing the remote endpoint of this * socket, or null if it is not connected yet. * @see #getInetAddress() * @see #getPort() -Chris.
Re: CR 6667108 code review
Approved. Christopher Hegarty - Sun Microsystems Ireland wrote: CR 6667108: "typo in javadoc for java.net.Socket.getRemoteSocketAddress()" Trivial cleanup of a typo in getRemoteSocketAddress specification. diff -r fa6948bdc4b0 src/share/classes/java/net/Socket.java --- a/src/share/classes/java/net/Socket.javaThu Mar 06 10:35:28 2008 -0800 +++ b/src/share/classes/java/net/Socket.javaFri Mar 07 09:51:14 2008 + @@ -731,7 +731,7 @@ class Socket implements java.io.Closeabl * then this method will continue to return the connected address * after the socket is closed. * - * @return a SocketAddress reprensenting the remote endpoint of this + * @return a SocketAddress representing the remote endpoint of this * socket, or null if it is not connected yet. * @see #getInetAddress() * @see #getPort() -Chris.
hg: jdk7/jsn/jdk: 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress()
Changeset: a100f699c155 Author:chegar Date: 2008-03-07 09:57 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a100f699c155 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress() Summary: Simple typo in method specification. Reviewed-by: jccollet ! src/share/classes/java/net/Socket.java
Re: JSN gate notifications.
Thanks Brad, this is great. -Chris. Brad Wetmore wrote: Hi net-dev'ers, This is Brad Wetmore, your friendly neighborhood JSN gatekeeper. For some reason, pushes to the various JSN gates were initially configured to send notifications only to the security group's aliases. That problem has been fixed, and notifications should now go to both the security and network groups. If you're interested in seeing what's gone back to the JSN gate so far, see the security group mail archives (below). Here's the ones I though might be of interest to the net group: 6638560: APPCRASH in "SPNEGO_HTTP_AUTH/PROXY_FALLBACK" test case with 64 bit JDK on Win2008 x64, VinVista x64 christopher.hegarty at sun.com 6641309: Wrong Cookie separator used in HttpURLConnection jean-christophe.collet at sun.com 6660405: HttpURLConnection returns the wrong InputStream jean-christophe.collet at sun.com 6651717: Debug output statement left in MailToURLConnection jean-christophe.collet at sun.com More details about these putbacks can be found at: http://mail.openjdk.java.net/pipermail/security-dev/2008-March/thread.html Look for the the subject line "hg:" Thanks, please be careful out there. Brad
hg: jdk7/jsn/jdk: 6615656: Removed unimplemented java.net methods
Changeset: 328415dfe347 Author:chegar Date: 2008-03-07 11:30 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/328415dfe347 6615656: Removed unimplemented java.net methods Reviewed-by: jccollet ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/NetworkInterface.java ! src/solaris/classes/java/net/PlainSocketImpl.java ! src/windows/classes/java/net/DualStackPlainSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainSocketImpl.java
Re: CR 6591358 code review
Approved.
Christopher Hegarty - Sun Microsystems Ireland wrote:
Another trivial documentation change.
CR 6591358:
"documentation error in URLConnection.setRequestProperty("accept", ...)"
-Chris.
hg: jdk7/jsn/jdk: 6591358: documentation error in URLConnection.setRequestProperty("accept", ...)
Changeset: 10d5be3e1fa8
Author:chegar
Date: 2008-03-07 11:51 +
URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/10d5be3e1fa8
6591358: documentation error in URLConnection.setRequestProperty("accept", ...)
Summary: Simple doc change, "accept" -> "Accept"
Reviewed-by: jccollet
! src/share/classes/java/net/URLConnection.java
CR 6591358 code review
Another trivial documentation change.
CR 6591358:
"documentation error in URLConnection.setRequestProperty("accept", ...)"
-Chris.
--- old/src/share/classes/java/net/URLConnection.java Fri Mar 7 11:19:24 2008
+++ new/src/share/classes/java/net/URLConnection.java Fri Mar 7 11:19:24 2008
@@ -1072,7 +1072,7 @@
* properties to be appended into a single property.
*
* @param key the keyword by which the request is known
- * (e.g., "accept").
+ * (e.g., "Accept").
* @param value the value associated with it.
* @throws IllegalStateException if already connected
* @throws NullPointerException if key is null
@@ -1096,7 +1096,7 @@
* existing values associated with the same key.
*
* @param key the keyword by which the request is known
- * (e.g., "accept").
+ * (e.g., "Accept").
* @param value the value associated with it.
* @throws IllegalStateException if already connected
* @throws NullPointerException if key is null
@@ -1120,7 +1120,7 @@
* Returns the value of the named general request property for this
* connection.
*
- * @param key the keyword by which the request is known (e.g., "accept").
+ * @param key the keyword by which the request is known (e.g., "Accept").
* @return the value of the named general request property for this
* connection. If key is null, then null is returned.
* @throws IllegalStateException if already connected
@@ -1164,7 +1164,7 @@
* these properties.
*
* @param key the keyword by which the request is known
- * (e.g., "accept").
+ * (e.g., "Accept").
* @param value the value associated with the key.
*
* @see
java.net.URLConnection#setRequestProperty(java.lang.String,java.lang.String)
@@ -1183,7 +1183,7 @@
* Returns the value of the default request property. Default request
* properties are set for every connection.
*
- * @param key the keyword by which the request is known (e.g., "accept").
+ * @param key the keyword by which the request is known (e.g., "Accept").
* @return the value of the default request property
* for the specified key.
*
hg: jdk7/jsn/jdk: 6628576: InterfaceAddress.equals() NPE when broadcast field == null
Changeset: 50a8b5ca8f39 Author:chegar Date: 2008-03-07 13:00 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/50a8b5ca8f39 6628576: InterfaceAddress.equals() NPE when broadcast field == null Summary: Update logic in equals to correctly handle nulls. Reviewed-by: michaelm ! src/share/classes/java/net/InterfaceAddress.java + test/java/net/InterfaceAddress/Equals.java
