mp guide: sections -> leaks

2004-05-04 Thread Brad Bowman
Hello,

I've had problems with  sections causing leaks with
graceful restart, at least with some versions/setups of mod_perl.
I thought the problem should be noted in the guide.

A patch is attached for:
http://perl.apache.org/docs/1.0/guide/troubleshooting.pod.orig

I no longer have my test code, it was a while ago.
Here's the link and mail exchange that confirmed my tests:

http://aspn.activestate.com/ASPN/Mail/Message/modperl/304620

> >> > I have a static Solaris compilation, and have the same problems
> >> > where the parent seems to grow by 1M each HUP.
> >> 
> >> that's strange, do you have PerlFreshRestart On or some  sections?
> >> otherwise, kill -HUP with a static modperl is a noop.
> > 
> >You got me!  I have   sections ... but I didn't know
> >it was such a crime.  Pretty bizarre behavior if you ask me.
> 
> it's not a crime, but if you're running Perl code during restart there's a
> strong chance you'll be growing the server size.  i agree 1M is bizarre
> though.

Brad

-- 
... There is dignity in paucity of words. ... -- Hagakure
--- troubleshooting.pod.orig	2004-05-04 16:57:24.0 +1000
+++ troubleshooting.pod.new	2004-05-04 17:03:48.0 +1000
@@ -767,6 +767,10 @@
 See the I explanation at the section:
 L
 
+Also, be aware that  sections can also cause leaks during
+graceful restarts.  See the (sub)thread:
+http://aspn.activestate.com/ASPN/Mail/Message/modperl/304620
+
 =head1 OS Specific Notes
 
 =head2 RedHat Linux

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html

Re: mp guide: sections -> leaks

2004-05-04 Thread Brad Bowman


> Thanks for the patch, Brad. But are you sure this is still the case with the 
> latest mp1? This thread that you've quoted is 4 years old. And it doesn't show 
> any code that may cause such a leak.

I'm reasonable sure I got the leaks with apache 1.3.27 and 
mod_perl 1.27.  I don't know about newer versions.

I've looked again and can't find the code I used, I think it
was defining a sub which was probably the leak.

> >>it's not a crime, but if you're running Perl code during restart there's a
> >>strong chance you'll be growing the server size.  i agree 1M is bizarre
> >>though.
> 
> In which case this should probably mention:
> 
> > +Also, be aware that  sections can also cause leaks during
> > +graceful restarts.  See the (sub)thread:
> > +http://aspn.activestate.com/ASPN/Mail/Message/modperl/304620
> 
> "when running some perl code"? as in 'besides using  sections to do 
> dynamic configuration'?

I took the "if you're running Perl code during restart" to include
dynamic configuration code.  I don't really understand the process
so I'll defer to you.  I'd just like to see  sections mentioned
as a possible culprit.

Brad

-- 
 Ikuno Oribe said, "If a retainer will just think about what he is to do
 for the day at hand, he will be able to do anything. If it is a single
 day's work, one should be able to put up with it. Tomorrow, too, is but
 another single day."-- Hagakure http://bereft.net/hagakure/



-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html