Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Removed braces for single statement block
On 7/21/22 17:00, Abhijeet Srivastava wrote:
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index 26f978a1cc72..0c138d47d0c3 100644
--- a/drivers/staging/media/zoran/zoran_card.c
+++ b/drivers/staging/media/zoran/zoran_card.c
@@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
BUZ_NUM_STAT_COM * sizeof(u32),
&zr->p_sc, GFP_KERNEL);
- if (!zr->stat_com) {
+ if (!zr->stat_com)
return -ENOMEM;
- }
+
for (j = 0; j < BUZ_NUM_STAT_COM; j++)
zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to
zr36057 */
Why does the subject line start with "media:" The subsystem is
"staging:" so the subject should start with "staging: media: ..."
I have no clue if this is accepted.
Regards,
Philipp
___
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Fixed Block comments
On Thu, Jul 21, 2022 at 11:07:22PM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava
> ---
> drivers/staging/media/zoran/zoran_driver.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c
> b/drivers/staging/media/zoran/zoran_driver.c
> index 4304b7e21709..b408c1d4e0a7 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,9 +746,11 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> .vidioc_enum_input = zoran_enum_input,
> .vidioc_g_input = zoran_g_input,
> .vidioc_s_input = zoran_s_input,
> +
> /* .vidioc_enum_output = zoran_enum_output,
> - .vidioc_g_output= zoran_g_output,
> - .vidioc_s_output= zoran_s_output,*/
> + * .vidioc_g_output= zoran_g_output,
> + * .vidioc_s_output= zoran_s_output,
> + */
Always, just delete dead code.
regards,
dan carpenter
___
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Deleted dead code
On 7/22/22 20:26, Abhijeet Srivastava wrote:
Deleted part of code in block comment
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_driver.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zoran_driver.c
index b408c1d4e0a7..836edf623571 100644
--- a/drivers/staging/media/zoran/zoran_driver.c
+++ b/drivers/staging/media/zoran/zoran_driver.c
@@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
.vidioc_enum_input = zoran_enum_input,
.vidioc_g_input = zoran_g_input,
.vidioc_s_input = zoran_s_input,
-
-/* .vidioc_enum_output = zoran_enum_output,
- * .vidioc_g_output= zoran_g_output,
- * .vidioc_s_output= zoran_s_output,
- */
.vidioc_g_std = zoran_g_std,
.vidioc_s_std = zoran_s_std,
.vidioc_create_bufs = vb2_ioctl_create_bufs,
@@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
.vidioc_streamon= vb2_ioctl_streamon,
.vidioc_streamoff = vb2_ioctl_streamoff,
.vidioc_enum_fmt_vid_cap= zoran_enum_fmt_vid_cap,
-/* .vidioc_enum_fmt_vid_out= zoran_enum_fmt_vid_out,*/
.vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
-/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
.vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
-/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
.vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
-/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
};
Why does the subject line start with "media:" The subsystem is
"staging:" so the subject should start with "staging: media: ..."
I have no clue if this is accepted.
Regards,
Philipp
___
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Deleted dead code
Em Fri, 22 Jul 2022 20:52:29 +0200
Philipp Hortmann escreveu:
> On 7/22/22 20:26, Abhijeet Srivastava wrote:
> > Deleted part of code in block comment
> >
> > Signed-off-by: Abhijeet Srivastava
> > ---
> > drivers/staging/media/zoran/zoran_driver.c | 9 -
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/staging/media/zoran/zoran_driver.c
> > b/drivers/staging/media/zoran/zoran_driver.c
> > index b408c1d4e0a7..836edf623571 100644
> > --- a/drivers/staging/media/zoran/zoran_driver.c
> > +++ b/drivers/staging/media/zoran/zoran_driver.c
> > @@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> > .vidioc_enum_input = zoran_enum_input,
> > .vidioc_g_input = zoran_g_input,
> > .vidioc_s_input = zoran_s_input,
> > -
> > -/* .vidioc_enum_output = zoran_enum_output,
> > - * .vidioc_g_output= zoran_g_output,
> > - * .vidioc_s_output= zoran_s_output,
> > - */
> > .vidioc_g_std = zoran_g_std,
> > .vidioc_s_std = zoran_s_std,
> > .vidioc_create_bufs = vb2_ioctl_create_bufs,
> > @@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> > .vidioc_streamon= vb2_ioctl_streamon,
> > .vidioc_streamoff = vb2_ioctl_streamoff,
> > .vidioc_enum_fmt_vid_cap= zoran_enum_fmt_vid_cap,
> > -/* .vidioc_enum_fmt_vid_out= zoran_enum_fmt_vid_out,*/
> > .vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
> > -/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
> > .vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
> > -/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
> > .vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
> > -/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
> > .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
> > .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> > };
>
> Why does the subject line start with "media:" The subsystem is
> "staging:" so the subject should start with "staging: media: ..."
>
> I have no clue if this is accepted.
The subsystem is media. The drivers for both drivers/media and
drivers/staging/media have the same maintainers. The "staging" is
just a place where we place stuff that are either not ready for
upstream or are under deprecation.
So, we expect that all subjects start with media:. I prefer if
they don't have "staging" at the subject, as makes the driver
logs more coherent when they're moved in/out staging dir.
Regards,
Mauro
___
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
[Mjpeg-users] [PATCH] media: staging: media: zoran: Deleted dead code
Deleted part of code in block comment
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_driver.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zoran_driver.c
index b408c1d4e0a7..836edf623571 100644
--- a/drivers/staging/media/zoran/zoran_driver.c
+++ b/drivers/staging/media/zoran/zoran_driver.c
@@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
.vidioc_enum_input = zoran_enum_input,
.vidioc_g_input = zoran_g_input,
.vidioc_s_input = zoran_s_input,
-
-/* .vidioc_enum_output = zoran_enum_output,
- * .vidioc_g_output= zoran_g_output,
- * .vidioc_s_output= zoran_s_output,
- */
.vidioc_g_std = zoran_g_std,
.vidioc_s_std = zoran_s_std,
.vidioc_create_bufs = vb2_ioctl_create_bufs,
@@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
.vidioc_streamon= vb2_ioctl_streamon,
.vidioc_streamoff = vb2_ioctl_streamoff,
.vidioc_enum_fmt_vid_cap= zoran_enum_fmt_vid_cap,
-/* .vidioc_enum_fmt_vid_out= zoran_enum_fmt_vid_out,*/
.vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
-/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
.vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
-/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
.vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
-/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
};
--
2.34.1
___
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
