Re: [Mjpeg-users] [PATCH v2 65/67] media: Kconfig: cleanup VIDEO_DEV dependencies

2022-03-18 Thread Lukasz Stelmach
It was <2022-03-14 pon 17:35>, when Mauro Carvalho Chehab wrote:
> media Kconfig has two entries associated to V4L API:
> VIDEO_DEV and VIDEO_V4L2.
>
> On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
> VIDEO_DEV were meant to:
>   1) enable Video4Linux and make its Kconfig options to appear;
>   2) it makes the Kernel build the V4L core.
>
> while VIDEO_V4L2 where used to distinguish between drivers that
> implement the newer API and drivers that implemented the former one.
>
> With time, such meaning changed, specially after the removal of
> all V4L version 1 drivers.
>
> At the current implementation, VIDEO_DEV only does (1): it enables
> the media options related to V4L, that now has:
>
>   menu "Video4Linux options"
>   visible if VIDEO_DEV
>
>   source "drivers/media/v4l2-core/Kconfig"
>   endmenu
>
> but it doesn't affect anymore the V4L core drivers.
>
> The rationale is that the V4L2 core has a "soft" dependency
> at the I2C bus, and now requires to select a number of other
> Kconfig options:
>
>   config VIDEO_V4L2
>   tristate
>   depends on (I2C || I2C=n) && VIDEO_DEV
>   select RATIONAL
>   select VIDEOBUF2_V4L2 if VIDEOBUF2_CORE
>   default (I2C || I2C=n) && VIDEO_DEV
>
> In the past, merging them would be tricky, but it seems that it is now
> possible to merge those symbols, in order to simplify V4L dependencies.
>
> Let's keep VIDEO_DEV, as this one is used on some make *defconfig
> configurations.
>
> Suggested-by: Laurent Pinchart 
> Reviewed-by: Laurent Pinchart 
> Reviewed-by: Jacopo Mondi 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C 
> on the cover.
> See [PATCH v2 00/67] at: 
> https://lore.kernel.org/all/cover.1647274406.git.mche...@kernel.org/
>
>  drivers/input/rmi4/Kconfig|   2 +-
>  drivers/input/touchscreen/Kconfig |   4 +-
>  drivers/media/Kconfig |   3 +
>  drivers/media/common/saa7146/Kconfig  |   2 +-
>  drivers/media/dvb-core/Kconfig|   2 +-
>  drivers/media/dvb-frontends/Kconfig   |   4 +-
>  drivers/media/i2c/Kconfig | 250 +-
>  drivers/media/i2c/ccs/Kconfig |   2 +-
>  drivers/media/i2c/cx25840/Kconfig |   2 +-
>  drivers/media/i2c/et8ek8/Kconfig  |   2 +-
>  drivers/media/i2c/m5mols/Kconfig  |   2 +-
>  drivers/media/pci/Kconfig |   2 +-
>  drivers/media/pci/bt8xx/Kconfig   |   2 +-
>  drivers/media/pci/cobalt/Kconfig  |   2 +-
>  drivers/media/pci/cx18/Kconfig|   2 +-
>  drivers/media/pci/dt3155/Kconfig  |   2 +-
>  drivers/media/pci/intel/ipu3/Kconfig  |   2 +-
>  drivers/media/pci/ivtv/Kconfig|   2 +-
>  drivers/media/pci/meye/Kconfig|   2 +-
>  drivers/media/pci/saa7146/Kconfig |   6 +-
>  drivers/media/pci/sta2x11/Kconfig |   2 +-
>  drivers/media/pci/tw5864/Kconfig  |   2 +-
>  drivers/media/pci/tw68/Kconfig|   2 +-
>  drivers/media/pci/tw686x/Kconfig  |   2 +-
>  drivers/media/platform/Kconfig|   6 +-
>  drivers/media/platform/allegro-dvt/Kconfig|   2 +-
>  .../platform/allwinner/sun4i-csi/Kconfig  |   2 +-
>  .../platform/allwinner/sun6i-csi/Kconfig  |   2 +-
>  .../media/platform/allwinner/sun8i-di/Kconfig |   2 +-
>  .../platform/allwinner/sun8i-rotate/Kconfig   |   2 +-
>  .../media/platform/amlogic/meson-ge2d/Kconfig |   2 +-
>  drivers/media/platform/amphion/Kconfig|   1 -
>  drivers/media/platform/aspeed/Kconfig |   2 +-
>  drivers/media/platform/atmel/Kconfig  |   8 +-
>  drivers/media/platform/cadence/Kconfig|   4 +-
>  drivers/media/platform/chips-media/Kconfig|   2 +-
>  drivers/media/platform/intel/Kconfig  |   2 +-
>  drivers/media/platform/marvell/Kconfig|   4 +-
>  .../media/platform/mediatek/mtk-jpeg/Kconfig  |   2 +-
>  .../media/platform/mediatek/mtk-mdp/Kconfig   |   2 +-
>  .../platform/mediatek/mtk-vcodec/Kconfig  |   2 +-
>  .../media/platform/mediatek/mtk-vpu/Kconfig   |   2 +-
>  .../media/platform/nvidia/tegra-vde/Kconfig   |   2 +-
>  drivers/media/platform/nxp/Kconfig|   6 +-
>  drivers/media/platform/nxp/imx-jpeg/Kconfig   |   2 +-
>  drivers/media/platform/qcom/camss/Kconfig |   2 +-
>  drivers/media/platform/qcom/venus/Kconfig |   2 +-
>  drivers/media/platform/renesas/Kconfig|  30 +--
>  .../media/platform/renesas/rcar-vin/Kconfig   |   4 +-
>  drivers/media/platform/rockchip/rga/Kconfig   |   2 +-
>  .../media/platform/rockchip/rkisp1/Kconfig|   2 +-
>  .../media/platform/samsung/exynos-gsc/Kconfig |   2 +-
>  .../media/platform/samsung/exynos4-is/Kconfig |   2 +-
>  .../medi

Re: [Mjpeg-users] [PATCH 64/64] media: Kconfig: cleanup VIDEO_DEV dependencies

2022-03-18 Thread Shuah Khan

On 3/14/22 1:55 AM, Mauro Carvalho Chehab wrote:

media Kconfig has two entries associated to V4L API:
VIDEO_DEV and VIDEO_V4L2.

On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
VIDEO_DEV were meant to:
1) enable Video4Linux and make its Kconfig options to appear;
2) it makes the Kernel build the V4L core.

while VIDEO_V4L2 where used to distinguish between drivers that
implement the newer API and drivers that implemented the former one.

With time, such meaning changed, specially after the removal of
all V4L version 1 drivers.

At the current implementation, VIDEO_DEV only does (1): it enables
the media options related to V4L, that now has:

menu "Video4Linux options"
visible if VIDEO_DEV

source "drivers/media/v4l2-core/Kconfig"
endmenu

but it doesn't affect anymore the V4L core drivers.

The rationale is that the V4L2 core has a "soft" dependency
at the I2C bus, and now requires to select a number of other
Kconfig options:

config VIDEO_V4L2
tristate
depends on (I2C || I2C=n) && VIDEO_DEV
select RATIONAL
select VIDEOBUF2_V4L2 if VIDEOBUF2_CORE
default (I2C || I2C=n) && VIDEO_DEV

In the past, merging them would be tricky, but it seems that it is now
possible to merge those symbols, in order to simplify V4L dependencies.

Let's keep VIDEO_DEV, as this one is used on some make *defconfig
configurations.

Suggested-by: Laurent Pinchart 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab 
---




  drivers/media/test-drivers/vicodec/Kconfig|   2 +-
  drivers/media/test-drivers/vimc/Kconfig   |   2 +-
  drivers/media/test-drivers/vivid/Kconfig  |   2 +-



For vimc change: (trimmed the recipient list to send response)

Acked-by: Shuah Khan 

thanks,
-- Shuah





___
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users