[Mjpeg-users] Bug in yuv2lav 1.9.0
As distributed, lines 245-250 in yuv2lav.c are: #ifdef HAVE_LIBQUICKTIME dotptr = strrchr(param_output, '.'); if ( (!strcasecmp(dotptr+1, "mov")) && (param_format == 'x') ) param_format = 'q'; #endif if ( (!strcasecmp(dotptr+1, "avi")) && (param_format == 'x') ) param_format = 'a'; If HAVE_LIBQUICKTIME is not defined, then the test for an avi extension is performed with dotptr uninitialized, resulting in a segmentation fault. Note that because the test for param_format is done after the strcasecmp, setting the format on the command line makes no difference. Apparently, the version compiled for SUSE 11.0 does not have HAVE_LIBQUICKTIME defined (which might just be a pkg-config issue), and so yuv2lav is broken. Graham Murphy Email: g...@cyberonic.com Home: woofpax.us Dogs have masters, cats have slaves. -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users
Re: [Mjpeg-users] Bug in yuv2lav 1.9.0
On Sun, 19 Apr 2009, Graham Murphy wrote: > As distributed, lines 245-250 in yuv2lav.c are: > > #ifdef HAVE_LIBQUICKTIME > dotptr = strrchr(param_output, '.'); > if ( (!strcasecmp(dotptr+1, "mov")) && (param_format == 'x') ) > param_format = 'q'; > #endif > if ( (!strcasecmp(dotptr+1, "avi")) && (param_format == 'x') ) > param_format = 'a'; > > Apparently, the version compiled for SUSE 11.0 does not have > HAVE_LIBQUICKTIME defined > (which might just be a pkg-config issue), and so yuv2lav is broken. To me the way I would prefer to fix the problem is require Quicktime support but that idea has been shot down in the past. I've checked in a change to not only initialize 'dotptr' but also check for a NULL pointer (if there is no extension on the filename). Cheers, Steven Schultz -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users
