Re: [Mesa-dev] frontends/va/postproc: Use the actual image height when blitting
Hi Ilia, This was the issue I was trying to fix: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6736#note_626808 It's doing a blit from 1088px (the actual video is only 1080px) to 1440px. The blit code scales and uses both the 1080 box height and 1088 resource height, but I'm guessing the small difference is the problem I'm dealing with: u_bitcast_f2u(x_scale / src->width0), u_bitcast_f2u(y_scale / src->height0), p y_scale / src->height0 $4 = 0.000689338252 p y_scale / 1080 $6 = 0.00069461 I'm not sure how to properly fix it though... any ideas would be appreciated. Thanks, Thong Thai On 2020-11-30 10:52 a.m., Liu, Leo wrote: +Thong. -Original Message- From: mesa-dev On Behalf Of Ilia Mirkin Sent: November 25, 2020 5:48 PM To: ML Mesa-dev ; Thai, Thong Subject: Re: [Mesa-dev] frontends/va/postproc: Use the actual image height when blitting Hi Thong, In this change: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fmesa%2Fmesa%2Fcommit%2F%3Fid%3D49465babdb35d88ed8a283e925d6cd346255d50c&data=04%7C01%7Cleo.liu%40amd.com%7C92b8ad99a46447208c3008d891943b09%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637419413135677095%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=g1pJUxsSM68kEjNZ6VDJGufaOF1Wwcezl1ehezq8mqo%3D&reserved=0 You appear to change the height of the underlying resource while doing a blit. This is never legal though -- the height of the resource is effectively immutable (and subject to various constraints). I'm not sure what issue you're having, but this is not the way to fix it. Cheers, -ilia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=04%7C01%7Cleo.liu%40amd.com%7C92b8ad99a46447208c3008d891943b09%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637419413135687091%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ug6N9kvs1JzjDhHPpB%2F9ttrCaahVgm7NJ6Bk0zCxc4A%3D&reserved=0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] frontends/va/postproc: Use the actual image height when blitting
Doh, sorry. I just found out, the problem is not with the height0 and scaling, it's with the y offset calculation: (blit_info->src.box.y + 0.5) / (float)src->height0 Everything seems to work if I revert the offending code that modifies height0, and just use this for the y offset: blit_info->src.box.y I'll look into a bit more... Thanks for the help, Thong Thai On 2020-11-30 1:07 p.m., Ilia Mirkin wrote: Many (most?) codecs decode stuff in 16px increments. So even though the video is 1080 in height, the decoded surface is 1088. However the video decoder should know that only 1080 pixels are valid. The src/dst regions should account for this. I suspect that there's an issue in the vl_compositor_cs logic which might not account for ... something? It's trying to scale texture coordinates, so using the full texture width/height is clearly right for scaling. However perhaps the thing being scaled is wrong if it's in the coordinate system of the destination surface rather than the video texture. It's a bit hard to follow the shaders without pseudocode like there is in vl_compositor_gfx. Perhaps writing such pseudocode will make the problem more apparent? Cheers, -ilia On Mon, Nov 30, 2020 at 12:35 PM Thong Thai wrote: Hi Ilia, This was the issue I was trying to fix: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2F-%2Fmerge_requests%2F6736%23note_626808&data=04%7C01%7Cthong.thai%40amd.com%7C4d9cd68ad841465f4d8508d8955ac609%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637423564389321354%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=eP4K8SCqvmr6E2ebfZKfMtbtKoboSTv8eXTzZdn8lto%3D&reserved=0 It's doing a blit from 1088px (the actual video is only 1080px) to 1440px. The blit code scales and uses both the 1080 box height and 1088 resource height, but I'm guessing the small difference is the problem I'm dealing with: u_bitcast_f2u(x_scale / src->width0), u_bitcast_f2u(y_scale / src->height0), p y_scale / src->height0 $4 = 0.000689338252 p y_scale / 1080 $6 = 0.00069461 I'm not sure how to properly fix it though... any ideas would be appreciated. Thanks, Thong Thai On 2020-11-30 10:52 a.m., Liu, Leo wrote: +Thong. -Original Message- From: mesa-dev On Behalf Of Ilia Mirkin Sent: November 25, 2020 5:48 PM To: ML Mesa-dev ; Thai, Thong Subject: Re: [Mesa-dev] frontends/va/postproc: Use the actual image height when blitting Hi Thong, In this change: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fmesa%2Fmesa%2Fcommit%2F%3Fid%3D49465babdb35d88ed8a283e925d6cd346255d50c&data=04%7C01%7Cthong.thai%40amd.com%7C4d9cd68ad841465f4d8508d8955ac609%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637423564389331348%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=i5nSRYtxTMmp8C8Y%2FfF1xXcoPq5u9ZGYbNgeNbuqb1w%3D&reserved=0 You appear to change the height of the underlying resource while doing a blit. This is never legal though -- the height of the resource is effectively immutable (and subject to various constraints). I'm not sure what issue you're having, but this is not the way to fix it. Cheers, -ilia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=04%7C01%7Cthong.thai%40amd.com%7C4d9cd68ad841465f4d8508d8955ac609%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637423564389331348%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3ZaXKDZcHEYZPiRTRHe3Q1ZqZEwZgskrSE%2FqQVIZjkI%3D&reserved=0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [mesa-20.3.2] NULL pointer dereference in vl_compositor_yuv_deint_full
Hi Alexander,
Guess I should add a check to see if it can create a non-interlaced
video buffer, and if not, return what it would have returned before,
when trying to derive an image from an interlaced buffer:
return VA_STATUS_ERROR_OPERATION_FAILED;
Thanks,
Thong Thai
On 2021-01-03 3:38 p.m., Alexander Kapshuk wrote:
NVIDIA chip affected:
01:00.0 VGA compatible controller: NVIDIA Corporation GT216 [GeForce
210] (rev a1)
The null pointer dereference occurs here:
Thread 27 "vlc" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff8f7c1640 (LWP 79292)]
0x7fff8d59d1da in vl_compositor_yuv_deint_full (s=0x7fff980e8518,
c=0x7fff980e83d8, src=0x7fff98670030, dst=0x0,
src_rect=0x7fff8f7c0470, dst_rect=0x7fff8f7c0460,
deinterlace=VL_COMPOSITOR_WEAVE) at
../mesa-20.3.2/src/gallium/auxiliary/vl/vl_compositor.c:689
689 dst_surfaces = dst->get_surfaces(dst); //dst==NULL
=> 0x7fff8d5981da <+42>:call *0x38(%rcx) //rcx is dst
(gdb) i r rcx
rcx0x0 0
(gdb) bt
#0 0x7fff8d59d1da in vl_compositor_yuv_deint_full
(s=0x7fff980e8518, c=0x7fff980e83d8, src=0x7fff98670030, dst=0x0,
src_rect=0x7fff8f7c0470, dst_rect=0x7fff8f7c0460,
deinterlace=VL_COMPOSITOR_WEAVE) at
../mesa-20.3.2/src/gallium/auxiliary/vl/vl_compositor.c:689
#1 0x7fff8d58a29b in vlVaDeriveImage (ctx=0x7fff980c1590,
surface=, image=0x7fff8f7c05e0)at
../mesa-20.3.2/src/gallium/frontends/va/image.c:321
#2 0x7fff91485799 in vaDeriveImage () at /usr/lib/libva.so.2
#3 0x7fff8e2256d2 in () at
/usr/lib/vlc/plugins/video_output/libglconv_vaapi_x11_plugin.so
#4 0x7fff8e224189 in () at
/usr/lib/vlc/plugins/video_output/libglconv_vaapi_x11_plugin.so
#5 0x7fff8f6b1896 in () at
/usr/lib/vlc/plugins/video_output/libgl_plugin.so
#6 0x7fff8f6b86db in () at
/usr/lib/vlc/plugins/video_output/libgl_plugin.so
#7 0x77d07cee in () at /usr/lib/libvlccore.so.9
#8 0x77cfa019 in () at /usr/lib/libvlccore.so.9
#9 0x77cfbf9e in () at /usr/lib/libvlccore.so.9
#10 0x77f623e9 in start_thread () at /usr/lib/libpthread.so.0
#11 0x77e8a293 in clone () at /usr/lib/libc.so.6
mesa-20.3.2/src/gallium/frontends/va/image.c:312,313
VAStatus
vlVaDeriveImage(VADriverContextP ctx, VASurfaceID surface, VAImage *image)
{
...
new_template.interlaced = false; //create_video_buffer
returns NULL if new_template.interlaced is set to false See below.
new_buffer = drv->pipe->create_video_buffer(drv->pipe, &new_template);
...
vl_compositor_yuv_deint_full(&drv->cstate, &drv->compositor,
surf->buffer, new_buffer,
&src_rect, &dst_rect,
VL_COMPOSITOR_WEAVE);
...
}
mesa-20.3.2/src/gallium/drivers/nouveau/nv50/nv84_video.c:618,621
struct pipe_video_buffer *
nv84_video_buffer_create(struct pipe_context *pipe,
const struct pipe_video_buffer *template)
{
...
if (!template->interlaced) { //set to false in vlVaDeriveImage. See above
debug_printf("Require interlaced video buffers\n");
return NULL;
}
...
}
Here's the commit that introduced the null pointer dereference in
question,
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2F-%2Fcommit%2Ffcb558321e65b62244a11e0066bb8713b1854721&data=04%7C01%7Cthong.thai%40amd.com%7C05879305275d42ce31ff08d8b0279037%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637453031560482800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Cx3j7nIJU5Qoc%2BNpP5UTdRHJyS7hguLbWmoJsybTu0Q%3D&reserved=0.
Please advise on the further course of action.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=04%7C01%7Cthong.thai%40amd.com%7C05879305275d42ce31ff08d8b0279037%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637453031560482800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=QqIG2scFQxNzQFG04%2F5NRihMO6pgivupkCoHzGoaUOM%3D&reserved=0
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
