[Mesa-dev] [PATCH] opencl: use versioned .so in mesa.icd
We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Cc: "10.6" Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/gallium/targets/opencl/Makefile.am | 2 +- src/gallium/targets/opencl/mesa.icd| 1 - src/gallium/targets/opencl/mesa.icd.in | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) delete mode 100644 src/gallium/targets/opencl/mesa.icd create mode 100644 src/gallium/targets/opencl/mesa.icd.in diff --git a/configure.ac b/configure.ac index d240c06..a7141a3 100644 --- a/configure.ac +++ b/configure.ac @@ -64,6 +64,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Set internal versions OSMESA_VERSION=8 AC_SUBST([OSMESA_VERSION]) +OPENCL_VERSION=1 +AC_SUBST([OPENCL_VERSION]) dnl Versions for external dependencies LIBDRM_REQUIRED=2.4.38 @@ -2376,6 +2378,7 @@ AC_CONFIG_FILES([Makefile src/gallium/targets/libgl-xlib/Makefile src/gallium/targets/omx/Makefile src/gallium/targets/opencl/Makefile + src/gallium/targets/opencl/mesa.icd src/gallium/targets/osmesa/Makefile src/gallium/targets/osmesa/osmesa.pc src/gallium/targets/pipe-loader/Makefile diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 70e60e2..af6d760 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targets/opencl/Makefile.am @@ -5,7 +5,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la lib@OPENCL_LIBNAME@_la_LDFLAGS = \ $(LLVM_LDFLAGS) \ -no-undefined \ - -version-number 1:0 \ + -version-number @OPENCL_VERSION@:0 \ $(GC_SECTIONS) \ $(LD_NO_UNDEFINED) diff --git a/src/gallium/targets/opencl/mesa.icd b/src/gallium/targets/opencl/mesa.icd deleted file mode 100644 index 6a6a870..000 --- a/src/gallium/targets/opencl/mesa.icd +++ /dev/null @@ -1 +0,0 @@ -libMesaOpenCL.so diff --git a/src/gallium/targets/opencl/mesa.icd.in b/src/gallium/targets/opencl/mesa.icd.in new file mode 100644 index 000..1b77b4e --- /dev/null +++ b/src/gallium/targets/opencl/mesa.icd.in @@ -0,0 +1 @@ +lib@OPENCL_LIBNAME@.so.@OPENCL_VERSION@ -- 2.4.5 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-maintainers] Proposal of date-based Mesa versioning for 2017
On Mon, Dec 12, 2016 at 4:28 PM, Emil Velikov wrote:
> [adding mesa-maintainers to the mix]
>
> On 1 October 2016 at 20:46, Marek Olšák wrote:
>> Hi,
>>
>> I propose that we use versioning in the form of "year.quarter".
>>
>> 2017 would start with 17.0, then 17.1, 17.2, 17.3 for following
>> quarters of the year, respectively.
>> 2018 would start with 18.0, then 18.1, 18.2, 18.3.
>>
>> The motivation is that you can easily tell when a specific Mesa
>> version was released with an accuracy of 3 months.
>>
>> That's the only scheme that seems practical to me. Everything else
>> seems arbitrary or random.
>>
> Afaict the only expectation from version numbers, is to never go back
> in time. Anything else is a manner of personal interpretation and
> there is will always someone who get confused.
> Look at how [some] projects steadily roll in their 50s ;-)
>
> That said, having a bit of a change is a good idea, esp. since we're
> unlikely to have a major bump anytime soon.
>
> As mentioned by others - having the second number represent the month
> would be better, afaict.
> Namely: YY.MM.PP. Thus 17.02.01 provides direct and clear feedback that
> - 2017 release, from the second month (Feb).
> - first bugfix release.
>
> * Distro/package maintainers, let us know if the above sounds fine on your
> end.
>
> Since this will have an impact on the tarball URL I'm bringing forward
> a question which has been asked a few times:
>
> * Should we drop the $VERSION directory in the URL, since it causes a
> fair bit of nuisance during RC stage.
> Namely from:
> https://mesa.freedesktop.org/archive/$VERSION/mesa-$VERSION.tar.{xz,gz}
> to:
> https://mesa.freedesktop.org/archive/mesa-$VERSION.tar.{xz,gz}
>
> Maintainers, kindly reply on both topics, even if you're neutral.
Like this idea, not sure how painful it will be to manage bugfixes and
under which terms will be stable branches (and which branches are
going to be stable).
>
> Thanks
> Emil
> ___
> Mesa-maintainers mailing list
> mesa-maintain...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-maintainers
--
-Igor Gnatenko
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-maintainers] [PATCH 06/28] configure: rename --with-{egl-, }platforms
On Tue, Dec 13, 2016 at 2:29 PM, Emil Velikov wrote: > On 13 December 2016 at 11:08, Eric Engestrom > wrote: >> On Thursday, 2016-12-08 19:21:46 +, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Since day 1, Vulkan has depended on --with-egl-platforms to select the >>> platforms build. >>> >>> With earlier commits, we've attributed for that internally by renaming >>> the [internal] conditionals in our build. At the same time having the >>> --enable-egl and --with-egl-platforms dependency for Vulkan makes no >>> sense. >>> >>> Since where' on the bridge we want to make the conditional generic, thus >>> others (such as the gallium VL targets) can honour the respective >>> platforms. >>> >>> Cc: mesa-maintain...@lists.freedesktop.org >>> Signed-off-by: Emil Velikov >>> --- >>> Should we keep the old configure and error out when anyone provides a >>> non-default value ? This way they'll have direct feedback how to move >>> forward. Otherwise they'll likely miss the warning message. >> >> Yes, I think we should do this for at least a release or two :) > I think you're right. It's a bit silly for me to expect that everyone > will pick up the change straight away. I will ;) > > -Emil > ___ > Mesa-maintainers mailing list > mesa-maintain...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-maintainers -- -Igor Gnatenko ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] opencl: improved auto-gen .icd
>From 5b2bf87f1238e44150492a39f5db0ae90d59459b Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Sun, 12 Jan 2014 02:09:16 +0400 Subject: [PATCH] opencl: improved auto-gen .icd v2: Use @OPENCL_VERSION@:0 for library replace /etc with @sysconfdir@ macros Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/gallium/targets/opencl/Makefile.am | 4 ++-- src/gallium/targets/opencl/mesa.icd| 1 - src/gallium/targets/opencl/mesa.icd.in | 1 + 4 files changed, 6 insertions(+), 3 deletions(-) delete mode 100644 src/gallium/targets/opencl/mesa.icd create mode 100644 src/gallium/targets/opencl/mesa.icd.in diff --git a/configure.ac b/configure.ac index 4b55140..3452e15 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Set internal versions OSMESA_VERSION=8 AC_SUBST([OSMESA_VERSION]) +OPENCL_VERSION=1 +AC_SUBST([OPENCL_VERSION]) dnl Versions for external dependencies LIBDRM_REQUIRED=2.4.24 @@ -2023,6 +2025,7 @@ AC_CONFIG_FILES([Makefile src/gallium/targets/egl-static/Makefile src/gallium/targets/gbm/Makefile src/gallium/targets/opencl/Makefile + src/gallium/targets/opencl/mesa.icd src/gallium/targets/osmesa/Makefile src/gallium/targets/osmesa/osmesa.pc src/gallium/targets/pipe-loader/Makefile diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 653302c..923316c 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targets/opencl/Makefile.am @@ -4,7 +4,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la lib@OPENCL_LIBNAME@_la_LDFLAGS = \ $(LLVM_LDFLAGS) \ - -version-number 1:0 + -version-number @OPENCL_VERSION@:0 lib@OPENCL_LIBNAME@_la_LIBADD = \ $(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader.la \ @@ -34,7 +34,7 @@ lib@OPENCL_LIBNAME@_la_SOURCES = nodist_EXTRA_lib@OPENCL_LIBNAME@_la_SOURCES = dummy.cpp if HAVE_CLOVER_ICD -icddir = /etc/OpenCL/vendors/ +icddir = @sysconfdir@/OpenCL/vendors/ icd_DATA = mesa.icd endif diff --git a/src/gallium/targets/opencl/mesa.icd b/src/gallium/targets/opencl/mesa.icd deleted file mode 100644 index 6a6a870..000 --- a/src/gallium/targets/opencl/mesa.icd +++ /dev/null @@ -1 +0,0 @@ -libMesaOpenCL.so diff --git a/src/gallium/targets/opencl/mesa.icd.in b/src/gallium/targets/opencl/mesa.icd.in new file mode 100644 index 000..a0b6489 --- /dev/null +++ b/src/gallium/targets/opencl/mesa.icd.in @@ -0,0 +1 @@ +@libdir@/lib@OPENCL_LIBNAME@.so.@OPENCL_VERSION@ -- 1.8.4.2 -- -Igor Gnatenko ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH v3] opencl: improved auto-gen .icd
>From 91796da9c00c0756b90b9e09d404a5357ff32ec6 Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Sun, 12 Jan 2014 02:09:16 +0400 Subject: [PATCH] opencl: improved auto-gen .icd v2: Use @OPENCL_VERSION@:0 for library replace /etc with @sysconfdir@ macros v3: Drop libdir from icd, because libMesaOpenCL isn't private Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/gallium/targets/opencl/Makefile.am | 4 ++-- src/gallium/targets/opencl/mesa.icd| 1 - src/gallium/targets/opencl/mesa.icd.in | 1 + 4 files changed, 6 insertions(+), 3 deletions(-) delete mode 100644 src/gallium/targets/opencl/mesa.icd create mode 100644 src/gallium/targets/opencl/mesa.icd.in diff --git a/configure.ac b/configure.ac index 4b55140..3452e15 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Set internal versions OSMESA_VERSION=8 AC_SUBST([OSMESA_VERSION]) +OPENCL_VERSION=1 +AC_SUBST([OPENCL_VERSION]) dnl Versions for external dependencies LIBDRM_REQUIRED=2.4.24 @@ -2023,6 +2025,7 @@ AC_CONFIG_FILES([Makefile src/gallium/targets/egl-static/Makefile src/gallium/targets/gbm/Makefile src/gallium/targets/opencl/Makefile + src/gallium/targets/opencl/mesa.icd src/gallium/targets/osmesa/Makefile src/gallium/targets/osmesa/osmesa.pc src/gallium/targets/pipe-loader/Makefile diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 653302c..923316c 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targets/opencl/Makefile.am @@ -4,7 +4,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la lib@OPENCL_LIBNAME@_la_LDFLAGS = \ $(LLVM_LDFLAGS) \ - -version-number 1:0 + -version-number @OPENCL_VERSION@:0 lib@OPENCL_LIBNAME@_la_LIBADD = \ $(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader.la \ @@ -34,7 +34,7 @@ lib@OPENCL_LIBNAME@_la_SOURCES = nodist_EXTRA_lib@OPENCL_LIBNAME@_la_SOURCES = dummy.cpp if HAVE_CLOVER_ICD -icddir = /etc/OpenCL/vendors/ +icddir = @sysconfdir@/OpenCL/vendors/ icd_DATA = mesa.icd endif diff --git a/src/gallium/targets/opencl/mesa.icd b/src/gallium/targets/opencl/mesa.icd deleted file mode 100644 index 6a6a870..000 --- a/src/gallium/targets/opencl/mesa.icd +++ /dev/null @@ -1 +0,0 @@ -libMesaOpenCL.so diff --git a/src/gallium/targets/opencl/mesa.icd.in b/src/gallium/targets/opencl/mesa.icd.in new file mode 100644 index 000..1b77b4e --- /dev/null +++ b/src/gallium/targets/opencl/mesa.icd.in @@ -0,0 +1 @@ +lib@OPENCL_LIBNAME@.so.@OPENCL_VERSION@ -- 1.8.4.2 -- -Igor Gnatenko ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] opencl: improved auto-gen .icd
On Mon, 2014-01-13 at 15:17 -0800, Matt Turner wrote: > On Mon, Jan 13, 2014 at 11:12 AM, Tom Stellard wrote: > > On Sun, Jan 12, 2014 at 03:08:56AM +0400, Igor Gnatenko wrote: > >> From 5b2bf87f1238e44150492a39f5db0ae90d59459b Mon Sep 17 00:00:00 2001 > >> From: Igor Gnatenko > >> Date: Sun, 12 Jan 2014 02:09:16 +0400 > >> Subject: [PATCH] opencl: improved auto-gen .icd > >> > >> v2: Use @OPENCL_VERSION@:0 for library > >> replace /etc with @sysconfdir@ macros > >> > >> Reported-by: Fabian Deutsch > >> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 > >> Signed-off-by: Igor Gnatenko > >> --- > >> configure.ac | 3 +++ > >> src/gallium/targets/opencl/Makefile.am | 4 ++-- > >> src/gallium/targets/opencl/mesa.icd| 1 - > >> src/gallium/targets/opencl/mesa.icd.in | 1 + > >> 4 files changed, 6 insertions(+), 3 deletions(-) > >> delete mode 100644 src/gallium/targets/opencl/mesa.icd > >> create mode 100644 src/gallium/targets/opencl/mesa.icd.in > >> > >> diff --git a/configure.ac b/configure.ac > >> index 4b55140..3452e15 100644 > >> --- a/configure.ac > >> +++ b/configure.ac > >> @@ -25,6 +25,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) > >> dnl Set internal versions > >> OSMESA_VERSION=8 > >> AC_SUBST([OSMESA_VERSION]) > >> +OPENCL_VERSION=1 > >> +AC_SUBST([OPENCL_VERSION]) > >> > >> dnl Versions for external dependencies > >> LIBDRM_REQUIRED=2.4.24 > >> @@ -2023,6 +2025,7 @@ AC_CONFIG_FILES([Makefile > >> src/gallium/targets/egl-static/Makefile > >> src/gallium/targets/gbm/Makefile > >> src/gallium/targets/opencl/Makefile > >> + src/gallium/targets/opencl/mesa.icd > >> src/gallium/targets/osmesa/Makefile > >> src/gallium/targets/osmesa/osmesa.pc > >> src/gallium/targets/pipe-loader/Makefile > >> diff --git a/src/gallium/targets/opencl/Makefile.am > >> b/src/gallium/targets/opencl/Makefile.am > >> index 653302c..923316c 100644 > >> --- a/src/gallium/targets/opencl/Makefile.am > >> +++ b/src/gallium/targets/opencl/Makefile.am > >> @@ -4,7 +4,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la > >> > >> lib@OPENCL_LIBNAME@_la_LDFLAGS = \ > >> $(LLVM_LDFLAGS) \ > >> - -version-number 1:0 > >> + -version-number @OPENCL_VERSION@:0 > >> > >> lib@OPENCL_LIBNAME@_la_LIBADD = \ > >> $(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader.la \ > >> @@ -34,7 +34,7 @@ lib@OPENCL_LIBNAME@_la_SOURCES = > >> nodist_EXTRA_lib@OPENCL_LIBNAME@_la_SOURCES = dummy.cpp > >> > >> if HAVE_CLOVER_ICD > >> -icddir = /etc/OpenCL/vendors/ > >> +icddir = @sysconfdir@/OpenCL/vendors/ > > > > As I mentioned in the bug report, the ICD spec says that OpenCL/vendors/ > > should be in /etc/ I don't think we can change this and still be spec > > compliant. Why do you want to install the *.icd files in sysconfdir? > > sysconfdir basically is etc. This hunk would allow you to install into > a prefix and not have this file installed into /etc outside of your > prefix. Unfortunately ocl-icd HARDLY defined /etc. Resending new patch. -- -Igor Gnatenko ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH v4] opencl: improved auto-gen .icd
>From 8c47b170c1f6152e337bf333662a3e561853a171 Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Sun, 12 Jan 2014 02:09:16 +0400 Subject: [PATCH] opencl: improved auto-gen .icd v2: Use @OPENCL_VERSION@:0 for library replace /etc with @sysconfdir@ macros v3: Drop libdir from icd, because libMesaOpenCL isn't private v4: install ocl vendor always to /etc Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/gallium/targets/opencl/Makefile.am | 2 +- src/gallium/targets/opencl/mesa.icd| 1 - src/gallium/targets/opencl/mesa.icd.in | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) delete mode 100644 src/gallium/targets/opencl/mesa.icd create mode 100644 src/gallium/targets/opencl/mesa.icd.in diff --git a/configure.ac b/configure.ac index 4b55140..3452e15 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Set internal versions OSMESA_VERSION=8 AC_SUBST([OSMESA_VERSION]) +OPENCL_VERSION=1 +AC_SUBST([OPENCL_VERSION]) dnl Versions for external dependencies LIBDRM_REQUIRED=2.4.24 @@ -2023,6 +2025,7 @@ AC_CONFIG_FILES([Makefile src/gallium/targets/egl-static/Makefile src/gallium/targets/gbm/Makefile src/gallium/targets/opencl/Makefile + src/gallium/targets/opencl/mesa.icd src/gallium/targets/osmesa/Makefile src/gallium/targets/osmesa/osmesa.pc src/gallium/targets/pipe-loader/Makefile diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 653302c..3b257ca 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targets/opencl/Makefile.am @@ -4,7 +4,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la lib@OPENCL_LIBNAME@_la_LDFLAGS = \ $(LLVM_LDFLAGS) \ - -version-number 1:0 + -version-number @OPENCL_VERSION@:0 lib@OPENCL_LIBNAME@_la_LIBADD = \ $(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader.la \ diff --git a/src/gallium/targets/opencl/mesa.icd b/src/gallium/targets/opencl/mesa.icd deleted file mode 100644 index 6a6a870..000 --- a/src/gallium/targets/opencl/mesa.icd +++ /dev/null @@ -1 +0,0 @@ -libMesaOpenCL.so diff --git a/src/gallium/targets/opencl/mesa.icd.in b/src/gallium/targets/opencl/mesa.icd.in new file mode 100644 index 000..1b77b4e --- /dev/null +++ b/src/gallium/targets/opencl/mesa.icd.in @@ -0,0 +1 @@ +lib@OPENCL_LIBNAME@.so.@OPENCL_VERSION@ -- 1.8.4.2 -- -Igor Gnatenko ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] xwayland: device isn't even open that explains why drmGetCap fails and it advertises no Prime capabilities
Since d9769c193765ac303ad4d4760e57ff368df1f663 DRI_PRIME=1 works
isn't correctly.
1. $ xrandr --listproviders
Providers: number : 2
Provider 0: id: 0x7b cap: 0x0 crtcs: 2 outputs: 4 associated
providers: 0 name:Intel
Provider 1: id: 0x55 cap: 0xf, Source Output, Sink Output, Source
Offload, Sink Offload crtcs: 6 outputs: 0 associated providers: 0
name:radeon
2. $ xrandr --setprovideroffloadsink 0x55 0x7b
X Error of failed request: BadValue (integer parameter out of range
for operation)
Major opcode of failed request: 139 (RANDR)
Minor opcode of failed request: 34 ()
Value in failed request: 0x7b
Serial number of failed request: 16
Current serial number in output stream: 17
Reported-and-tested-by: Kirill Rusinov
Signed-off-by: Igor Gnatenko
Signed-off-by: Axel Davy
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1033903
---
src/uxa/intel_driver.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
index 1c38075..c5d85c8 100644
--- a/src/uxa/intel_driver.c
+++ b/src/uxa/intel_driver.c
@@ -549,6 +549,12 @@ static Bool I830PreInit(ScrnInfoPtr scrn, int flags)
intel->PciInfo = xf86GetPciInfoForEntity(intel->pEnt->index);
+ if (!xorgWayland && (!intel_open_drm_master(scrn))) {
+ xf86DrvMsg(scrn->scrnIndex, X_ERROR,
+ "Failed to become DRM master.\n");
+ return FALSE;
+ }
+
scrn->monitor = scrn->confScreen->monitor;
scrn->progClock = TRUE;
scrn->rgbBits = 8;
@@ -604,14 +610,13 @@ static Bool I830PreInit(ScrnInfoPtr scrn, int flags)
}
intel->drmSubFD = xwl_screen_get_drm_fd(intel->xwl_screen);
+
+ if (!intel->xwl_screen && !intel_open_drm_master(scrn))
+ xf86DrvMsg(scrn->scrnIndex, X_ERROR,
+ "Failed to become DRM master.\n");
}
#endif
- if (!intel->xwl_screen && !intel_open_drm_master(scrn))
- xf86DrvMsg(scrn->scrnIndex, X_ERROR,
- "Failed to become DRM master.\n");
-
-
if (!intel_init_bufmgr(intel)) {
PreInitCleanup(scrn);
return FALSE;
--
1.8.4.2
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] opencl: use versioned .so in mesa.icd
We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/gallium/targets/opencl/Makefile.am | 2 +- src/gallium/targets/opencl/mesa.icd| 1 - src/gallium/targets/opencl/mesa.icd.in | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) delete mode 100644 src/gallium/targets/opencl/mesa.icd create mode 100644 src/gallium/targets/opencl/mesa.icd.in diff --git a/configure.ac b/configure.ac index 4da6c51..c195b1b 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Set internal versions OSMESA_VERSION=8 AC_SUBST([OSMESA_VERSION]) +OPENCL_VERSION=1 +AC_SUBST([OPENCL_VERSION]) dnl Versions for external dependencies LIBDRM_REQUIRED=2.4.24 @@ -2023,6 +2025,7 @@ AC_CONFIG_FILES([Makefile src/gallium/targets/egl-static/Makefile src/gallium/targets/gbm/Makefile src/gallium/targets/opencl/Makefile + src/gallium/targets/opencl/mesa.icd src/gallium/targets/osmesa/Makefile src/gallium/targets/osmesa/osmesa.pc src/gallium/targets/pipe-loader/Makefile diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 653302c..3b257ca 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targets/opencl/Makefile.am @@ -4,7 +4,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la lib@OPENCL_LIBNAME@_la_LDFLAGS = \ $(LLVM_LDFLAGS) \ - -version-number 1:0 + -version-number @OPENCL_VERSION@:0 lib@OPENCL_LIBNAME@_la_LIBADD = \ $(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader.la \ diff --git a/src/gallium/targets/opencl/mesa.icd b/src/gallium/targets/opencl/mesa.icd deleted file mode 100644 index 6a6a870..000 --- a/src/gallium/targets/opencl/mesa.icd +++ /dev/null @@ -1 +0,0 @@ -libMesaOpenCL.so diff --git a/src/gallium/targets/opencl/mesa.icd.in b/src/gallium/targets/opencl/mesa.icd.in new file mode 100644 index 000..1b77b4e --- /dev/null +++ b/src/gallium/targets/opencl/mesa.icd.in @@ -0,0 +1 @@ +lib@OPENCL_LIBNAME@.so.@OPENCL_VERSION@ -- 1.8.4.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH rebased] opencl: use versioned .so in mesa.icd
We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/gallium/targets/opencl/Makefile.am | 2 +- src/gallium/targets/opencl/mesa.icd| 1 - src/gallium/targets/opencl/mesa.icd.in | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) delete mode 100644 src/gallium/targets/opencl/mesa.icd create mode 100644 src/gallium/targets/opencl/mesa.icd.in diff --git a/configure.ac b/configure.ac index 7397341..6d063a8 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Set internal versions OSMESA_VERSION=8 AC_SUBST([OSMESA_VERSION]) +OPENCL_VERSION=1 +AC_SUBST([OPENCL_VERSION]) dnl Versions for external dependencies LIBDRM_REQUIRED=2.4.38 @@ -2202,6 +2204,7 @@ AC_CONFIG_FILES([Makefile src/gallium/targets/egl-static/Makefile src/gallium/targets/gbm/Makefile src/gallium/targets/opencl/Makefile + src/gallium/targets/opencl/mesa.icd src/gallium/targets/xa/Makefile src/gallium/targets/xa/xatracker.pc src/gallium/targets/omx-nouveau/Makefile diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 55a73b4..3a6fafe 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targets/opencl/Makefile.am @@ -5,7 +5,7 @@ lib_LTLIBRARIES = lib@OPENCL_LIBNAME@.la lib@OPENCL_LIBNAME@_la_LDFLAGS = \ $(LLVM_LDFLAGS) \ -no-undefined \ - -version-number 1:0 \ + -version-number @OPENCL_VERSION@:0 \ if HAVE_LD_VERSION_SCRIPT -Wl,--version-script=$(top_srcdir)/src/gallium/targets/opencl/opencl.sym \ endif diff --git a/src/gallium/targets/opencl/mesa.icd b/src/gallium/targets/opencl/mesa.icd deleted file mode 100644 index 6a6a870..000 --- a/src/gallium/targets/opencl/mesa.icd +++ /dev/null @@ -1 +0,0 @@ -libMesaOpenCL.so diff --git a/src/gallium/targets/opencl/mesa.icd.in b/src/gallium/targets/opencl/mesa.icd.in new file mode 100644 index 000..1b77b4e --- /dev/null +++ b/src/gallium/targets/opencl/mesa.icd.in @@ -0,0 +1 @@ +lib@OPENCL_LIBNAME@.so.@OPENCL_VERSION@ -- 1.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] gen_llvm_ir_macros.py: error: argument --output/-o: can't open 'rasterizer/jitter/builder_gen.h': [Errno 2] No such file or directory: 'rasterizer/jitter/builder_gen.h'
_MACROS -D_GNU_SOURCE -DUSE_SSE41 -DNDEBUG -DTEXTURE_FLOAT_ENABLED -DUSE_X86_64_ASM -DHAVE_XLOCALE_H -DHAVE_SYS_SYSCTL_H -DHAVE_STRTOF -DHAVE_MKOSTEMP -DHAVE_DLOPEN -DHAVE_POSIX_MEMALIGN -DMESA_SELINUX -DHAVE_LIBDRM -DGLX_USE_DRM -DHAVE_LIBUDEV -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DGLX_USE_TLS -DHAVE_ALIAS -DHAVE_DRI3 -DHAVE_MINCORE -DHAVE_ST_VDPAU -DHAVE_LLVM=0x0308 -DMESA_LLVM_VERSION_PATCH=0 -fvisibility=hidden -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -frtti -fexceptions -Wall -fno-strict-aliasing -fno-builtin-memcmp -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -static-libstdc++ -o libmesaswr.la swr_loader.lo libtool: link: ar cru .libs/libmesaswr.a .libs/swr_loader.o libtool: link: ranlib .libs/libmesaswr.a libtool: link: ( cd ".libs" && rm -f "libmesaswr.la" && ln -s "../libmesaswr.la" "libmesaswr.la" ) make[3]: Leaving directory '/builddir/build/BUILD/mesa-ea2bff1/src/gallium/drivers/swr' Making all in drivers/swr/avx make[3]: Entering directory '/builddir/build/BUILD/mesa-ea2bff1/src/gallium/drivers/swr/avx' python2.7 \ ./../rasterizer/scripts/gen_knobs.py \ rasterizer/scripts python2.7 \ ./../rasterizer/scripts/gen_knobs.py \ rasterizer/scripts python2.7 \ ./../rasterizer/jitter/scripts/gen_llvm_types.py \ --input ./../rasterizer/core/state.h \ --output rasterizer/jitter/state_llvm.h python2.7 \ ./../rasterizer/jitter/scripts/gen_llvm_ir_macros.py \ --input /usr/include/llvm/IR/IRBuilder.h \ --output rasterizer/jitter/builder_gen.h \ --gen_h usage: gen_llvm_types.py [-h] --input INPUT --output OUTPUT [--scalar] usage: gen_llvm_ir_macros.py [-h] [--input INPUT] --output OUTPUT [--gen_h] [--gen_cpp] [--gen_x86_h] [--gen_x86_cpp] gen_llvm_ir_macros.py: error: argument --output/-o: can't open 'rasterizer/jitter/builder_gen.h': [Errno 2] No such file or directory: 'rasterizer/jitter/builder_gen.h' gen_llvm_types.py: error: argument --output/-o: can't open 'rasterizer/jitter/state_llvm.h': [Errno 2] No such file or directory: 'rasterizer/jitter/state_llvm.h' Makefile:1270: recipe for target 'rasterizer/jitter/builder_gen.h' failed make[3]: *** [rasterizer/jitter/builder_gen.h] Error 2 make[3]: *** Waiting for unfinished jobs Makefile:1264: recipe for target 'rasterizer/jitter/state_llvm.h' failed make[3]: *** [rasterizer/jitter/state_llvm.h] Error 2 ERROR: Could not create output directory: rasterizer/scripts Makefile:1259: recipe for target 'rasterizer/scripts/gen_knobs.h' failed make[3]: *** [rasterizer/scripts/gen_knobs.h] Error 1 make[3]: Leaving directory '/builddir/build/BUILD/mesa-ea2bff1/src/gallium/drivers/swr/avx' Makefile:596: recipe for target 'all-recursive' failed make[2]: Leaving directory '/builddir/build/BUILD/mesa-ea2bff1/src/gallium' make[2]: *** [all-recursive] Error 1 Makefile:688: recipe for target 'all-recursive' failed make[1]: Leaving directory '/builddir/build/BUILD/mesa-ea2bff1/src' make[1]: *** [all-recursive] Error 1 Makefile:638: recipe for target 'all-recursive' failed make: *** [all-recursive] Error 1 -- -Igor Gnatenko ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] virgl: pipe_virgl_create_screen is not static
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=93063
Signed-off-by: Igor Gnatenko
---
src/gallium/auxiliary/target-helpers/drm_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/target-helpers/drm_helper.h
b/src/gallium/auxiliary/target-helpers/drm_helper.h
index 73a80b6..332b1cb 100644
--- a/src/gallium/auxiliary/target-helpers/drm_helper.h
+++ b/src/gallium/auxiliary/target-helpers/drm_helper.h
@@ -223,7 +223,7 @@ pipe_freedreno_create_screen(int fd)
#include "virgl/drm/virgl_drm_public.h"
#include "virgl/virgl_public.h"
-static struct pipe_screen *
+struct pipe_screen *
pipe_virgl_create_screen(int fd)
{
struct virgl_winsys *vws;
--
2.6.3
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] link mesautil with pthreads
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname': /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np' ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join': /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join' ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create': /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask' ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create': /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create' ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create': /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask' /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask' ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once': /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once' ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano': /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid' collect2: error: ld returned 1 exit status Signed-off-by: Igor Gnatenko --- src/util/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/Makefile.am b/src/util/Makefile.am index a5241ad27b..633907b9fd 100644 --- a/src/util/Makefile.am +++ b/src/util/Makefile.am @@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \ libxmlconfig.la AM_CPPFLAGS = \ + $(PTHREAD_CFLAGS) \ -I$(top_srcdir)/include libmesautil_la_CPPFLAGS = \ @@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \ $(MESA_UTIL_GENERATED_FILES) libmesautil_la_LIBADD = \ + $(PTHREAD_LIBS) \ $(CLOCK_LIB) \ $(ZLIB_LIBS) \ $(LIBATOMIC_LIBS) -- 2.15.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] auxiliary/vl: fix linkage with xcb_dri
../../../../src/gallium/auxiliary/.libs/libgalliumvlwinsys.a(libgalliumvlwinsys_la-vl_winsys_dri.o): In function `vl_dri2_get_flush_reply': /builddir/build/BUILD/mesa-17.3.1/src/gallium/auxiliary/vl/vl_winsys_dri.c:108: undefined reference to `xcb_dri2_swap_buffers_reply' /builddir/build/BUILD/mesa-17.3.1/src/gallium/auxiliary/vl/vl_winsys_dri.c:110: undefined reference to `xcb_dri2_wait_sbc_reply' ../../../../src/gallium/auxiliary/.libs/libgalliumvlwinsys.a(libgalliumvlwinsys_la-vl_winsys_dri.o): In function `vl_dri2_flush_frontbuffer': /builddir/build/BUILD/mesa-17.3.1/src/gallium/auxiliary/vl/vl_winsys_dri.c:138: undefined reference to `xcb_dri2_swap_buffers_unchecked' /builddir/build/BUILD/mesa-17.3.1/src/gallium/auxiliary/vl/vl_winsys_dri.c:140: undefined reference to `xcb_dri2_wait_sbc_unchecked' /builddir/build/BUILD/mesa-17.3.1/src/gallium/auxiliary/vl/vl_winsys_dri.c:141: undefined reference to `xcb_dri2_get_buffers_unchecked' ... Signed-off-by: Igor Gnatenko --- src/gallium/auxiliary/Makefile.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/auxiliary/Makefile.am index a64ead28e3..d96232e427 100644 --- a/src/gallium/auxiliary/Makefile.am +++ b/src/gallium/auxiliary/Makefile.am @@ -72,7 +72,6 @@ if NEED_GALLIUM_VL COMMON_VL_CFLAGS = \ $(AM_CFLAGS) \ $(VL_CFLAGS) \ - $(XCB_DRI3_CFLAGS) \ $(DRI2PROTO_CFLAGS) \ $(LIBDRM_CFLAGS) @@ -93,9 +92,13 @@ libgalliumvlwinsys_la_SOURCES = $(VL_WINSYS_SOURCES) if HAVE_PLATFORM_X11 libgalliumvlwinsys_la_SOURCES += $(VL_WINSYS_DRI2_SOURCES) +libgalliumvlwinsys_la_CFLAGS += $(XCB_DRI2_CFLAGS) +libgalliumvlwinsys_la_LIBADD += $(XCB_DRI2_LIBS) if HAVE_DRI3 libgalliumvlwinsys_la_SOURCES += $(VL_WINSYS_DRI3_SOURCES) +libgalliumvlwinsys_la_CFLAGS += $(XCB_DRI3_CFLAGS) +libgalliumvlwinsys_la_LIBADD += $(XCB_DRI3_LIBS) endif endif -- 2.15.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/3] Add meson build system
option('vmwgfx', type : 'combo', value : 'true', choices : ['true',
> 'false', 'auto'])
> +option('omap',type : 'combo', value : 'false', choices : ['true',
> 'false', 'auto'])
> +option('exynos', type : 'combo', value : 'false', choices : ['true',
> 'false', 'auto'])
> +option('freedreno', type : 'combo', value : 'auto', choices : ['true',
> 'false', 'auto'])
> +option('tegra', type : 'combo', value : 'false', choices : ['true',
> 'false', 'auto'])
> +option('vc4', type : 'combo', value : 'auto', choices : ['true',
> 'false', 'auto'])
> +option('etnaviv', type : 'combo', value : 'false', choices : ['true',
> 'false', 'auto'])
> +option('cairo_tests', type : 'combo', value : 'auto', choices : ['true',
> 'false', 'auto'])
> +option('man_pages', type : 'combo', value : 'auto', choices : ['true',
> 'false', 'auto'])
> +option('valgrind',type : 'combo', value : 'auto', choices : ['true',
> 'false', 'auto'])
> +option('freedreno-kgls',type : 'boolean', value : false)
Probably using `_` would be better for consistency..
Also, option should be named kgsl, not kgls (note sl vs ls).
> +option('install_test_programs', type : 'boolean', value : false)
> +option('udev', type : 'boolean', value : false)
Having description on all those options would be extremely useful 😉
[...]
Still testing it, once will have more results -- will come back.
- --
- -Igor Gnatenko
-BEGIN PGP SIGNATURE-
iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlpNZbwACgkQaVcUvRu8
X0xuQRAAulgnkHdNb2LCq6R+4A+IwEbyVD3uNIBv0eF0X/k/8w7IT7PcNwdS8VN3
XBrSLqFTxHTsghtMXSDXDW6LqA3Zv8VCkWZb3G/bek4w6iwwHmEVLGawiO1jVlHY
uX7bQEf/bdrM/UnXY1PnBmzmfhIcu6LhAry+pPS0iYxJWgcv6XbFil5fYu+N9T1H
vdlj8WJtZA9u4VhHdqFaf8JN8OwuBC2+87mNvuZMwKF1d4BD9r77WRuhDnyRWzJs
NoxufXz9JPx2YRbg6V8V5V4fsCV5oFpSpkpnTqIasjWlyJXo2Dhatt6oCbtu+ip4
Vf5Nr7WzIbXhT8WAYnLPc8E2mtWK5HG8NhrLJnqY4kdyiJ+w7X0PXKYeBPXRN1NG
zrF+h7Kd4LJvPwh0KMl1idGiGa5Mmr/vF/apIKrMBMvJ++E9zs+sPCNbSjnI3aWe
47LIqTkVxCLjwHIpQqDWZ+bUNanpwFaWtVWm9xvlPcpZ35pP2PqeyZ6abpqykP8b
OSQK9fN0PpiZsfVT25K8SaGvFzUy37lFSs/3cvTFQ+rmKo7xYxj1qbd4xvml0CU8
4IcPcFKRZRMFIE1cecqg7lNxlgfcA7bdrOSbvjHpKNlEUpRZOtNDPjgkx8RWlA3J
x1u8mcARzI5m837isa0eOatVgYXy+Eg86zWxiIy1jGliWaJTvN0=
=Rikj
-END PGP SIGNATURE-
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v4 1/3] Add meson build system
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Thu, 2018-01-04 at 10:28 -0800, Dylan Baker wrote: > This patch adds a complete meson build system, including tests and > install. It has the necessary hooks to allow it be used as a subproject > for other meson based builds such as mesa. Builds fine on all architectures supported by Fedora, boots fine on my laptop (x86_64). All nitpicks are inline. > Signed-off-by: Dylan Baker Reviewed-and-tested-by: Igor Gnatenko > diff --git a/meson_options.txt b/meson_options.txt > new file mode 100644 > index 000..08c2ccd > --- /dev/null > +++ b/meson_options.txt > @@ -0,0 +1,143 @@ > [...] > +option( > + 'intel', > + type : 'combo', > + value : 'auto', > + choices : ['true', 'false', 'auto'], > + description : '''Enable support for Intel's KMS API.''', Any reason to use `'''` here and there? > [...] > +option( > + 'man-pages', > + type : 'combo', > + value : 'auto', > + choices : ['true', 'false', 'auto'], > + description : 'Enable manpage generation and install.', "installation". > [...] > +option( > + 'valgrind', > + type : 'combo', > + value : 'auto', > + choices : ['true', 'false', 'auto'], > + description : 'build libdrm with valgrind support', "Build". And fullstop at the end of sentence. - -- - -Igor Gnatenko -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlpOoBcACgkQaVcUvRu8 X0yF9w//cgaMVkU4xTKegRJY4uuzTE3MQvMmaCoA8ivBaCWPuoX3ozlwsAgZZXaZ Vo83tZ0u80cjgoSG4I/JcNp3UhsxtGgqcrqqcof/SGn+YS43eFKPL57dowwQ5qk3 ccAUgHtAdQXuCJFaQFsTISSEj1X07RA04mIMe7QZFh7AHsKmv+ctaTUO7uJsXJzi aX7Z9rntTCnXvzZy7Y56XPCleXfi+yDzQPdDopZAEdLYT8hYUvebo6JGQUpg8iNd YuvZsbkrpyV1uMY/2feSJ3Ns4ZTAj3I4F41Xbb7CqZt/BX60EnkZJXog4RSbdlri cxMX7gPkrOXxNJbllmdN0nPdBP/atViRY7dDkE4Lv4YrmwL8oT4Mjfyb/TeINT2X 6NltSgc8+zSvQSkjWyKHzQ3ZQCQHIAheG+V2Cvnc1NIfX06AV9USRsSRzBMza+gW cWNT2g/M0jjmLTVEoLR8MSLXAB9gfsBdRDEnvqEsZCqDh1idW1Ttuk3m/h3+BT8i GMyCrswVgKLI7gBbdVFdLDarEIVtTJlYvPkGXxRyOzv1r5dM/MMmeay7P3WD+liE CLF9nRVrekQA7Mh4Y61RSyFAntzBokNKL+FrSzSuseNtgYAM3Es0JgY1ndsczvVX zUqULC0AEAEwmAIQmDlYFG+ut8nIvmk6aWHHlvLwUHgiDD+MEc4= =dAKV -END PGP SIGNATURE- ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-maintainers] Underlinking issues in 18.0.0~rc3
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Thu, 2018-02-08 at 23:58 +, Emil Velikov wrote: > On 8 February 2018 at 23:02, Igor Gnatenko > wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > I've tried to update mesa to 18.0.0~rc3 in Fedora Rawhide, but that fails > > with > > a lot of "undefined reference" errors. Any hints for available patch? > > > > https://kojipkgs.fedoraproject.org//work/tasks/2888/24852888/build.log > > That's strange. Nothing specific comes to mind wrt these errors > (missing xcb dependencies in the VL targets). > Can you please confirm that the exact same build recipe works on other > Fedora versions? Yes, it does... But there are a lot of differences between F27 and F28: * llvm (5.0.1 → 6.0.0~rc1) * gcc (7.3.1 → 8.0.1) * glibc (2.26 → 2.27 > Having a quick look at the build log - I'm suspecting that the > static-libstdc++ workaround that you guys have might be causing > side-effects. > Speaking of which ... we should really revisit and merge something > like it in Mesa. I've tried to remove it and build fails with: /usr/bin/ld: glsl/main.o: relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC Then added -fPIC to CFLAGS... And it failed with same "undefined error" messages. Seems it was done to workaround Steam bundling its own libstdc++. https://src.fedoraproject.org/rpms/mesa/c/e443b9d8776c56a7943dd501cbcb16bc92c73 22f - -- - -Igor Gnatenko -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlp9N1gACgkQaVcUvRu8 X0ymBQ/7Bx0cYYZgE2V3xNxgdsgG/8ocni9pqqr+aF1uRMqqtf3Z/le3sxY0zirQ GmRNv8hODAcsX2xVKXG5Z0CQ+mpzE29ZQmUHAz3LmRdSWjLOtWfiYZSBJsor8ikg 18epaGqno7As0tcAqkJSj1Q7FO8WbLu964iepzr1MgFz5l7Ck47dBFEZAy1Mn9Oj Ix1+OuYgyfXwj8QsJK9DRu1dpomVB5wdTevyMHRocKH8eC2Ijxo2Swe9kXTFIVLs IDFD3r7TijPxa7m65Y/x0xWmqO/qEM1i/8u3KdKy2Yp2sfYuz9eu8j/gLuIRqt8N 4SFUV5yxhE92eq+aKESd431Hz/0uD9ha5E3aUZzBfA/GnxBmVho/uAlG+J2wcoij htWEzlsYvvERfb1wJrzeVwQBObH8C+cCKGwz22U6EplfpLqa82V7YX8H5cYenZzu Vftj0D7JPnTSDrllcTHO2NZpqeLeba3jzeFlqQyOBAwjevAi3Nx6FSydzjpTMxRn 3LyU5+Ux1OW3zeVka/j/ukO5uyDyisv6VJY1Eo3Q3N+9cno8oxiDeJC1GijBpUo9 3V2DBwY62hccdq7IpE76K5p1IcKRtkhSvhu+lYMSTn1xSiGyhENhEa8t74AhS4yB i+lABlB6SYtvljDSdjgdTDdua0roMToauRvA1fQJR41WkrUHa30= =21I5 -END PGP SIGNATURE- ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] Underlinking issues in 18.0.0~rc3
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 I've tried to update mesa to 18.0.0~rc3 in Fedora Rawhide, but that fails with a lot of "undefined reference" errors. Any hints for available patch? https://kojipkgs.fedoraproject.org//work/tasks/2888/24852888/build.log - -- - -Igor Gnatenko -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlp81wYACgkQaVcUvRu8 X0wP7xAAg6sufQh8NXt3K6kZY+jqS13mSQJjA6T9cP91z6bwjeq0dP8FofsXhsSe Q/5eIpF/1vjVjB4XE3ffFOXKMT9YcJJdQBLDP3hQpo/7RTG+JCTQWT1B6E9erRIt DLb2Lz8TbwBCW5v/dQnl7vlvlST8z9gUBvYrE5zN/db8w7kTxybdhApBbmNWd/x/ upHb9s/fjq8oMhTLNsvZeSUaIlrGLgl4nifnvJQgrUXm7o0ciXDuRDd5DoyclATy 5UNJKimNUz+bMyGNHhymDy9/zldabR+CgIwGes67Hj2zD+4oLVo1B01DxjFWgJ53 EhP7R6oArxdo7mahLdYw+yxSCpLYc3Pq8h59gKMKVVVX4jZ5Odpgr5z1BZkq6auh alpnrPg18+4n4xd0UH5yVV9bQBvRM46oNsSoegOQNagfi17EkROzIV/t1GLu1uzV bSS49rzes/zB8TXiGtgsnj6aUSCvAE5ZfLN9ptIeZpfL+P0UyGnftzT4iNsG44uQ QS0kYxNy1OA+6QeD+2fmsqSMnERYnZWQNxIQH/vvBLZuSFU2aMnpve2YS51emJqu nsd6BvmjsZFFvuXCPdbygQobRimKLjtb5+I86d5nsDpEBf1Lzzq1V9Qs+M1mysyd PQ4KprQ4nJeVZrtkzIPJILW0xfMLi8tbcrV9Nzb1aFIzrawsKXg= =PsS+ -END PGP SIGNATURE- ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
