[lttng-dev] Trace Compass "Add contexts..." option displays XML file

2019-10-23 Thread Kramer, Zach
Hi,

With 2.11.0, adding contexts no longer works for me in Trace Compass (5.1.0). 
This worked before in lttng-tools 2.9.11.

When I try to add contexts to my channel I get the following options:

  *   All Contexts
 *   
 * // Entire XML file

Does anyone else experience this? Did the XML schema change in a way that 
requires Trace Compass to update its parsing?

lttng add-context –list works as expected.

Best,
Zach

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


Re: [lttng-dev] Trace Compass "Add contexts..." option displays XML file

2019-10-23 Thread Jonathan Rajotte-Julien
Hi,

On Wed, Oct 23, 2019 at 12:33:59PM +, Kramer, Zach wrote:
> Hi,
> 
> With 2.11.0, adding contexts no longer works for me in Trace Compass (5.1.0). 
> This worked before in lttng-tools 2.9.11.
> 
> When I try to add contexts to my channel I get the following options:
> 
>   *   All Contexts
>  *   
>  * // Entire XML file

Actually the mi support for listing context was added in 2.11 [1]. This seems 
to be
tracecompass expecting regular text output despite it is passing the "--mi xml"
options. Please repost this on the tracecompass mailing list [2].

[1] 
https://github.com/lttng/lttng-tools/commit/59deec0c09b544d548711deaa6d8206efe99ea0d
[2] https://accounts.eclipse.org/mailing-list/tracecompass-dev

Cheers

> 
> Does anyone else experience this? Did the XML schema change in a way that 
> requires Trace Compass to update its parsing?
> 
> lttng add-context –list works as expected.
> 
> Best,
> Zach
> 

> ___
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


-- 
Jonathan Rajotte-Julien
EfficiOS
___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


Re: [lttng-dev] [EXTERNAL] Re: Trace Compass "Add contexts..." option displays XML file

2019-10-23 Thread Kramer, Zach
Hi,

Thanks for the answer. I forwarded this along to them.

(I also confirmed that this problem only exists in 2.11.0 -- 2.10.X is safe 
from it).

Thanks,
Zach

-Original Message-
From: Jonathan Rajotte-Julien  
Sent: Wednesday, October 23, 2019 3:49 PM
To: Kramer, Zach 
Cc: lttng-dev 
Subject: [EXTERNAL] Re: [lttng-dev] Trace Compass "Add contexts..." option 
displays XML file

Hi,

On Wed, Oct 23, 2019 at 12:33:59PM +, Kramer, Zach wrote:
> Hi,
> 
> With 2.11.0, adding contexts no longer works for me in Trace Compass (5.1.0). 
> This worked before in lttng-tools 2.9.11.
> 
> When I try to add contexts to my channel I get the following options:
> 
>   *   All Contexts
>  *   
>  * // Entire XML file

Actually the mi support for listing context was added in 2.11 [1]. This seems 
to be tracecompass expecting regular text output despite it is passing the 
"--mi xml"
options. Please repost this on the tracecompass mailing list [2].

[1] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flttng%2Flttng-tools%2Fcommit%2F59deec0c09b544d548711deaa6d8206efe99ea0d&data=02%7C01%7CZach.Kramer%40cognex.com%7Cd751419f4a664c501be908d757bfbf66%7Cc12007a4882b4381b05ab783431570c7%7C1%7C0%7C637074353385404286&sdata=g7DKrd6XWw9SbdHm%2Fwg3%2FsTtX4yZoh7YHvIZf%2Beg1Fw%3D&reserved=0
[2] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Faccounts.eclipse.org%2Fmailing-list%2Ftracecompass-dev&data=02%7C01%7CZach.Kramer%40cognex.com%7Cd751419f4a664c501be908d757bfbf66%7Cc12007a4882b4381b05ab783431570c7%7C1%7C0%7C637074353385414284&sdata=wqBKE8BZS456JWvhFgIZCnF3C1lAmCknnAr0n8XYKUM%3D&reserved=0

Cheers

> 
> Does anyone else experience this? Did the XML schema change in a way that 
> requires Trace Compass to update its parsing?
> 
> lttng add-context –list works as expected.
> 
> Best,
> Zach
> 

> ___
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.lttng.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Flttng-dev&data=02%7C0
> 1%7CZach.Kramer%40cognex.com%7Cd751419f4a664c501be908d757bfbf66%7Cc120
> 07a4882b4381b05ab783431570c7%7C1%7C0%7C637074353385414284&sdata=Wr
> ZWciI7M18O4yBrUWllsS7atzIFwaK%2F%2FkJqdvUTNbE%3D&reserved=0


--
Jonathan Rajotte-Julien
EfficiOS
___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


[lttng-dev] [PATCH lttng-tools stable-2.11] fix: check for lttng-ust >= 2.11 at configure

2019-10-23 Thread Michael Jeanson
We don't support building lttng-tools against an older version of
lttng-ust, make this check explicitly at configure.

Signed-off-by: Michael Jeanson 
---
 configure.ac | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 5c4073ef8..357e2b888 100644
--- a/configure.ac
+++ b/configure.ac
@@ -562,14 +562,13 @@ AC_ARG_WITH([lttng-ust],
 
 AS_IF([test "x$with_lttng_ust" = "xyes"],
   [
-AC_CHECK_LIB([lttng-ust-ctl], [ustctl_recv_channel_from_consumer],
+AC_CHECK_LIB([lttng-ust-ctl], [lttng_ust_enum_get_from_desc],
   [
 AC_DEFINE([HAVE_LIBLTTNG_UST_CTL], [1])
   ],
   [
-AC_MSG_FAILURE([Cannot find LTTng-UST >= 2.2.x. Use [LDFLAGS]=-Ldir 
and [CPPFLAGS]=-Idir to specify its location, or specify --without-lttng-ust to 
build lttng-tools without LTTng-UST support.])
-  ],
-  [-lurcu-common -lurcu-bp -lurcu-cds -lrt -ldl]
+AC_MSG_FAILURE([Cannot find LTTng-UST >= 2.11.x. Use [LDFLAGS]=-Ldir 
and [CPPFLAGS]=-Idir to specify its location, or specify --without-lttng-ust to 
build lttng-tools without LTTng-UST support.])
+  ]
 )
   ]
 )
-- 
2.17.1

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


[lttng-dev] [PATCH lttng-ust] Add pkgconfig support for liblttng-ust-ctl

2019-10-23 Thread Michael Jeanson
Signed-off-by: Michael Jeanson 
---
 Makefile.am |  2 +-
 configure.ac|  1 +
 lttng-ust-ctl.pc.in | 12 
 3 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 lttng-ust-ctl.pc.in

diff --git a/Makefile.am b/Makefile.am
index 73b51909..cc923c1d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -32,7 +32,7 @@ SUBDIRS += tests doc
 # liblttng-ust-malloc
 
 pkgconfigdir = $(libdir)/pkgconfig
-pkgconfig_DATA = lttng-ust.pc
+pkgconfig_DATA = lttng-ust.pc lttng-ust-ctl.pc
 
 dist_doc_DATA = \
ChangeLog \
diff --git a/configure.ac b/configure.ac
index 52fc3f68..580e0ee3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -555,6 +555,7 @@ AC_CONFIG_FILES([
tests/test-app-ctx/Makefile
tests/gcc-weak-hidden/Makefile
lttng-ust.pc
+   lttng-ust-ctl.pc
 ])
 
 # Create link for python agent for the VPATH guru.
diff --git a/lttng-ust-ctl.pc.in b/lttng-ust-ctl.pc.in
new file mode 100644
index ..3170b30a
--- /dev/null
+++ b/lttng-ust-ctl.pc.in
@@ -0,0 +1,12 @@
+prefix=@prefix@
+exec_prefix=@exec_prefix@
+libdir=@libdir@
+includedir=@includedir@
+
+Name: LTTng Userspace Tracer control
+Description: The LTTng Userspace Tracer (UST) is a library accompanied by a 
set of tools to trace userspace code.
+Version: @PACKAGE_VERSION@
+Requires:
+Libs: -L${libdir} -llttng-ust-ctl
+Cflags: -I${includedir}
+
-- 
2.17.1

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


Re: [lttng-dev] [PATCH lttng-ust] Add pkgconfig support for liblttng-ust-ctl

2019-10-23 Thread Mathieu Desnoyers
Merged into master. Please let me know if it needs to be backported.

Thanks,

Mathieu

- On Oct 23, 2019, at 11:11 AM, Michael Jeanson mjean...@efficios.com wrote:

> Signed-off-by: Michael Jeanson 
> ---
> Makefile.am |  2 +-
> configure.ac|  1 +
> lttng-ust-ctl.pc.in | 12 
> 3 files changed, 14 insertions(+), 1 deletion(-)
> create mode 100644 lttng-ust-ctl.pc.in
> 
> diff --git a/Makefile.am b/Makefile.am
> index 73b51909..cc923c1d 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -32,7 +32,7 @@ SUBDIRS += tests doc
> # liblttng-ust-malloc
> 
> pkgconfigdir = $(libdir)/pkgconfig
> -pkgconfig_DATA = lttng-ust.pc
> +pkgconfig_DATA = lttng-ust.pc lttng-ust-ctl.pc
> 
> dist_doc_DATA = \
>   ChangeLog \
> diff --git a/configure.ac b/configure.ac
> index 52fc3f68..580e0ee3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -555,6 +555,7 @@ AC_CONFIG_FILES([
>   tests/test-app-ctx/Makefile
>   tests/gcc-weak-hidden/Makefile
>   lttng-ust.pc
> + lttng-ust-ctl.pc
> ])
> 
> # Create link for python agent for the VPATH guru.
> diff --git a/lttng-ust-ctl.pc.in b/lttng-ust-ctl.pc.in
> new file mode 100644
> index ..3170b30a
> --- /dev/null
> +++ b/lttng-ust-ctl.pc.in
> @@ -0,0 +1,12 @@
> +prefix=@prefix@
> +exec_prefix=@exec_prefix@
> +libdir=@libdir@
> +includedir=@includedir@
> +
> +Name: LTTng Userspace Tracer control
> +Description: The LTTng Userspace Tracer (UST) is a library accompanied by a 
> set
> of tools to trace userspace code.
> +Version: @PACKAGE_VERSION@
> +Requires:
> +Libs: -L${libdir} -llttng-ust-ctl
> +Cflags: -I${includedir}
> +
> --
> 2.17.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


[lttng-dev] [PATCH lttng-ust] Set version to 2.12-pre

2019-10-23 Thread Michael Jeanson
Signed-off-by: Michael Jeanson 
---
 configure.ac | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 580e0ee3..319cb401 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,10 +1,10 @@
 dnl Version infos
 m4_define([V_MAJOR], [2])
-m4_define([V_MINOR], [11])
+m4_define([V_MINOR], [12])
 m4_define([V_PATCH], [0])
-m4_define([V_EXTRA], [rc1])
-m4_define([V_NAME], [[Lafontaine]])
-m4_define([V_DESC], [[A modern Saison beer from Montréal's Oshlag 
microbrewery, Lafontaine is a refreshing, zesty, rice beer with hints of fruit 
and spices.]])
+m4_define([V_EXTRA], [pre])
+m4_define([V_NAME], [[Codename TBD]])
+m4_define([V_DESC], [[Description TBD]])
 
 m4_define([V_STRING], [V_MAJOR.V_MINOR.V_PATCH])
 m4_ifdef([V_EXTRA], [m4_append([V_STRING], [-V_EXTRA])])
-- 
2.17.1

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


Re: [lttng-dev] [PATCH lttng-ust] Set version to 2.12-pre

2019-10-23 Thread Mathieu Desnoyers
Merged, thanks!

Mathieu

- On Oct 23, 2019, at 11:31 AM, Michael Jeanson mjean...@efficios.com wrote:

> Signed-off-by: Michael Jeanson 
> ---
> configure.ac | 8 
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 580e0ee3..319cb401 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,10 +1,10 @@
> dnl Version infos
> m4_define([V_MAJOR], [2])
> -m4_define([V_MINOR], [11])
> +m4_define([V_MINOR], [12])
> m4_define([V_PATCH], [0])
> -m4_define([V_EXTRA], [rc1])
> -m4_define([V_NAME], [[Lafontaine]])
> -m4_define([V_DESC], [[A modern Saison beer from Montréal's Oshlag 
> microbrewery,
> Lafontaine is a refreshing, zesty, rice beer with hints of fruit and 
> spices.]])
> +m4_define([V_EXTRA], [pre])
> +m4_define([V_NAME], [[Codename TBD]])
> +m4_define([V_DESC], [[Description TBD]])
> 
> m4_define([V_STRING], [V_MAJOR.V_MINOR.V_PATCH])
> m4_ifdef([V_EXTRA], [m4_append([V_STRING], [-V_EXTRA])])
> --
> 2.17.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev