date:20181218

[lttng-dev] [PATCH urcu] Cleanup: enable signed/unsigned compare compiler warning

2018-12-18 Thread Michael Jeanson

Signed-off-by: Michael Jeanson 
---
 configure.ac  |  2 +-
 doc/examples/rculfhash/cds_lfht_add_replace.c |  2 +-
 doc/examples/rculfhash/cds_lfht_add_unique.c  |  2 +-
 doc/examples/rculfhash/cds_lfht_del.c |  2 +-
 .../cds_lfht_for_each_entry_duplicate.c   |  2 +-
 doc/examples/rculfhash/cds_lfht_lookup.c  |  2 +-
 src/rculfhash.c   | 27 ++
 src/urcu-utils.h  | 14 +
 tests/benchmark/test_mutex.c  | 27 +-
 tests/benchmark/test_perthreadlock.c  | 31 +--
 tests/benchmark/test_perthreadlock_timing.c   |  4 +-
 tests/benchmark/test_rwlock.c | 25 -
 tests/benchmark/test_rwlock_timing.c  |  6 ++-
 tests/benchmark/test_urcu.c   | 29 +-
 tests/benchmark/test_urcu_assign.c| 35 ++--
 tests/benchmark/test_urcu_bp.c| 31 ++-
 tests/benchmark/test_urcu_defer.c | 29 +-
 tests/benchmark/test_urcu_gc.c| 54 ++-
 tests/benchmark/test_urcu_hash.c  | 33 ++--
 tests/benchmark/test_urcu_lfq.c   | 36 +++--
 tests/benchmark/test_urcu_lfs.c   | 36 +++--
 tests/benchmark/test_urcu_lfs_rcu.c   | 35 ++--
 tests/benchmark/test_urcu_qsbr.c  | 29 +-
 tests/benchmark/test_urcu_qsbr_gc.c   | 53 +-
 tests/benchmark/test_urcu_qsbr_timing.c   |  4 +-
 tests/benchmark/test_urcu_timing.c|  4 +-
 tests/benchmark/test_urcu_wfcq.c  | 44 +++
 tests/benchmark/test_urcu_wfq.c   | 36 +++--
 tests/benchmark/test_urcu_wfs.c   | 43 ---
 29 files changed, 365 insertions(+), 312 deletions(-)

diff --git a/configure.ac b/configure.ac
index 017da5a..3879f8f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -381,7 +381,7 @@ AC_CHECK_FUNCS([sched_setaffinity],[
 AM_CPPFLAGS="-include config.h"
 AC_SUBST(AM_CPPFLAGS)
 
-AM_CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare $AM_CFLAGS"
+AM_CFLAGS="-Wall -Wextra -Wno-unused-parameter $AM_CFLAGS"
 AC_SUBST(AM_CFLAGS)
 
 AC_CONFIG_LINKS([
diff --git a/doc/examples/rculfhash/cds_lfht_add_replace.c 
b/doc/examples/rculfhash/cds_lfht_add_replace.c
index 19c3726..3b64ee0 100644
--- a/doc/examples/rculfhash/cds_lfht_add_replace.c
+++ b/doc/examples/rculfhash/cds_lfht_add_replace.c
@@ -41,7 +41,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
 {
struct mynode *node =
caa_container_of(ht_node, struct mynode, node);
-   const unsigned int *key = _key;
+   const int *key = _key;
 
return *key == node->value;
 }
diff --git a/doc/examples/rculfhash/cds_lfht_add_unique.c 
b/doc/examples/rculfhash/cds_lfht_add_unique.c
index 6875971..23b29f2 100644
--- a/doc/examples/rculfhash/cds_lfht_add_unique.c
+++ b/doc/examples/rculfhash/cds_lfht_add_unique.c
@@ -38,7 +38,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
 {
struct mynode *node =
caa_container_of(ht_node, struct mynode, node);
-   const unsigned int *key = _key;
+   const int *key = _key;
 
return *key == node->value;
 }
diff --git a/doc/examples/rculfhash/cds_lfht_del.c 
b/doc/examples/rculfhash/cds_lfht_del.c
index efa6d9a..f030ee1 100644
--- a/doc/examples/rculfhash/cds_lfht_del.c
+++ b/doc/examples/rculfhash/cds_lfht_del.c
@@ -37,7 +37,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
 {
struct mynode *node =
caa_container_of(ht_node, struct mynode, node);
-   const unsigned int *key = _key;
+   const int *key = _key;
 
return *key == node->value;
 }
diff --git a/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c 
b/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
index 9833280..a975128 100644
--- a/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
+++ b/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
@@ -37,7 +37,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
 {
struct mynode *node =
caa_container_of(ht_node, struct mynode, node);
-   const unsigned int *key = _key;
+   const int *key = _key;
 
return *key == node->value;
 }
diff --git a/doc/examples/rculfhash/cds_lfht_lookup.c 
b/doc/examples/rculfhash/cds_lfht_lookup.c
index 053e6dd..de2a47f 100644
--- a/doc/examples/rculfhash/cds_lfht_lookup.c
+++ b/doc/examples/rculfhash/cds_lfht_lookup.c
@@ -37,7 +37,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
 {
struct mynode *node =
caa_container_of(ht_node, struct mynode, node);
-   const unsigned int *key = _key;
+   const int *key = _key;
 
return *key == node->value;
 }
diff --git a/src/rculfhash.c b/src/rculfhash.c
index e0c5860..ff42df0 100644
---

Re: [lttng-dev] [PATCH urcu] Cleanup: enable signed/unsigned compare compiler warning

2018-12-18 Thread Mathieu Desnoyers

Merged into master branch, thanks!

Mathieu

- On Dec 18, 2018, at 2:21 PM, Michael Jeanson mjean...@efficios.com wrote:

> Signed-off-by: Michael Jeanson 
> ---
> configure.ac  |  2 +-
> doc/examples/rculfhash/cds_lfht_add_replace.c |  2 +-
> doc/examples/rculfhash/cds_lfht_add_unique.c  |  2 +-
> doc/examples/rculfhash/cds_lfht_del.c |  2 +-
> .../cds_lfht_for_each_entry_duplicate.c   |  2 +-
> doc/examples/rculfhash/cds_lfht_lookup.c  |  2 +-
> src/rculfhash.c   | 27 ++
> src/urcu-utils.h  | 14 +
> tests/benchmark/test_mutex.c  | 27 +-
> tests/benchmark/test_perthreadlock.c  | 31 +--
> tests/benchmark/test_perthreadlock_timing.c   |  4 +-
> tests/benchmark/test_rwlock.c | 25 -
> tests/benchmark/test_rwlock_timing.c  |  6 ++-
> tests/benchmark/test_urcu.c   | 29 +-
> tests/benchmark/test_urcu_assign.c| 35 ++--
> tests/benchmark/test_urcu_bp.c| 31 ++-
> tests/benchmark/test_urcu_defer.c | 29 +-
> tests/benchmark/test_urcu_gc.c| 54 ++-
> tests/benchmark/test_urcu_hash.c  | 33 ++--
> tests/benchmark/test_urcu_lfq.c   | 36 +++--
> tests/benchmark/test_urcu_lfs.c   | 36 +++--
> tests/benchmark/test_urcu_lfs_rcu.c   | 35 ++--
> tests/benchmark/test_urcu_qsbr.c  | 29 +-
> tests/benchmark/test_urcu_qsbr_gc.c   | 53 +-
> tests/benchmark/test_urcu_qsbr_timing.c   |  4 +-
> tests/benchmark/test_urcu_timing.c|  4 +-
> tests/benchmark/test_urcu_wfcq.c  | 44 +++
> tests/benchmark/test_urcu_wfq.c   | 36 +++--
> tests/benchmark/test_urcu_wfs.c   | 43 ---
> 29 files changed, 365 insertions(+), 312 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 017da5a..3879f8f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -381,7 +381,7 @@ AC_CHECK_FUNCS([sched_setaffinity],[
> AM_CPPFLAGS="-include config.h"
> AC_SUBST(AM_CPPFLAGS)
> 
> -AM_CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare $AM_CFLAGS"
> +AM_CFLAGS="-Wall -Wextra -Wno-unused-parameter $AM_CFLAGS"
> AC_SUBST(AM_CFLAGS)
> 
> AC_CONFIG_LINKS([
> diff --git a/doc/examples/rculfhash/cds_lfht_add_replace.c
> b/doc/examples/rculfhash/cds_lfht_add_replace.c
> index 19c3726..3b64ee0 100644
> --- a/doc/examples/rculfhash/cds_lfht_add_replace.c
> +++ b/doc/examples/rculfhash/cds_lfht_add_replace.c
> @@ -41,7 +41,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
> {
>   struct mynode *node =
>   caa_container_of(ht_node, struct mynode, node);
> - const unsigned int *key = _key;
> + const int *key = _key;
> 
>   return *key == node->value;
> }
> diff --git a/doc/examples/rculfhash/cds_lfht_add_unique.c
> b/doc/examples/rculfhash/cds_lfht_add_unique.c
> index 6875971..23b29f2 100644
> --- a/doc/examples/rculfhash/cds_lfht_add_unique.c
> +++ b/doc/examples/rculfhash/cds_lfht_add_unique.c
> @@ -38,7 +38,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
> {
>   struct mynode *node =
>   caa_container_of(ht_node, struct mynode, node);
> - const unsigned int *key = _key;
> + const int *key = _key;
> 
>   return *key == node->value;
> }
> diff --git a/doc/examples/rculfhash/cds_lfht_del.c
> b/doc/examples/rculfhash/cds_lfht_del.c
> index efa6d9a..f030ee1 100644
> --- a/doc/examples/rculfhash/cds_lfht_del.c
> +++ b/doc/examples/rculfhash/cds_lfht_del.c
> @@ -37,7 +37,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
> {
>   struct mynode *node =
>   caa_container_of(ht_node, struct mynode, node);
> - const unsigned int *key = _key;
> + const int *key = _key;
> 
>   return *key == node->value;
> }
> diff --git a/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
> b/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
> index 9833280..a975128 100644
> --- a/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
> +++ b/doc/examples/rculfhash/cds_lfht_for_each_entry_duplicate.c
> @@ -37,7 +37,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
> {
>   struct mynode *node =
>   caa_container_of(ht_node, struct mynode, node);
> - const unsigned int *key = _key;
> + const int *key = _key;
> 
>   return *key == node->value;
> }
> diff --git a/doc/examples/rculfhash/cds_lfht_lookup.c
> b/doc/examples/rculfhash/cds_lfht_lookup.c
> index 053e6dd..de2a47f 100644
> --- a/doc/examples/rculfhash/cds_lfht_lookup.c
> +++ b/doc/examples/rculfhash/cds_lfht_lookup.c
> @@ -37,7 +37,7 @@ int match(struct cds_lfht_node *ht_node, const void *_key)
> {
>   struct mynode *node =
>

[lttng-dev] [PATCH urcu] Cleanup: enable signed/unsigned compare compiler warning

Re: [lttng-dev] [PATCH urcu] Cleanup: enable signed/unsigned compare compiler warning

2 matches

Site Navigation

Mail list logo

Footer information