[llvm-branch-commits] [llvm] [clang] [clang] Function Multi Versioning supports IFunc lowerings on Darwin platforms (PR #73688)
tahonermann wrote: I recommend extending testing via additional `RUN` lines to all of the following tests: - `clang/test/CodeGen/attr-cpuspecific.c` - `clang/test/CodeGen/attr-target-clones.c` - `clang/test/CodeGen/attr-target-mv-func-ptrs.c` - `clang/test/CodeGen/attr-target-mv-va-args.c` (already done) - `clang/test/CodeGen/attr-target-mv.c` - `clang/test/CodeGenCXX/attr-cpuspecific.cpp` - `clang/test/CodeGenCXX/attr-target-mv-diff-ns.cpp` - `clang/test/CodeGenCXX/attr-target-mv-inalloca.cpp` - `clang/test/CodeGenCXX/attr-target-mv-member-funcs.cpp` - `clang/test/CodeGenCXX/attr-target-mv-modules.cpp` - `clang/test/CodeGenCXX/attr-target-mv-out-of-line-defs.cpp` - `clang/test/CodeGenCXX/attr-target-mv-overloads.cpp` - `clang/test/CodeGenCXX/attr-target-clones.cpp` Note that, for many of the above tests, changes planned in #71706 will impact the expected behavior. https://github.com/llvm/llvm-project/pull/73688 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [llvm] [clang] [clang] Function Multi Versioning supports IFunc lowerings on Darwin platforms (PR #73688)
tahonermann wrote: Added @erichkeane as a reviewer as well. Will this cause an ABI compatibility issue for any existing use of the function multiversioning attributes on Darwin? I think it might, but I haven't tried to confirm. https://github.com/llvm/llvm-project/pull/73688 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [llvm] [clang] [clang] Support __attribute__((ifunc(...))) on Darwin platforms (PR #73687)
tahonermann wrote: Added @erichkeane as a reviewer. I recommend extending test coverage to all of the following tests: - `clang/test/CodeGenCXX/externc-ifunc-resolver.cpp` - `clang/test/SemaCXX/externc-ifunc-resolver.cpp` - `clang/test/CodeGen/ifunc.c` (already done) - `clang/test/CodeGen/attr-ifunc.cpp` - `clang/test/CodeGen/attr-ifunc.c` https://github.com/llvm/llvm-project/pull/73687 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
