[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

2024-07-22 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL commented:

Except pointed out issues, looks fine for me.

https://github.com/llvm/llvm-project/pull/99681
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] release/19.x: [clang-tidy] Fix crash in modernize-use-ranges (#100427) (PR #101482)

2024-08-01 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL approved this pull request.


https://github.com/llvm/llvm-project/pull/101482
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] release/19.x: [clang-tidy] Fix crash in C language in readability-non-const-parameter (#100461) (PR #101878)

2024-08-04 Thread Piotr Zegar via llvm-branch-commits

PiotrZSL wrote:

I'm fine with updating release notes, but would prefer to do that in separate 
PR. Will do that tomorrow.

https://github.com/llvm/llvm-project/pull/101878
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] release/19.x: [clang-tidy] Fix crash in C language in readability-non-const-parameter (#100461) (PR #101878)

2024-08-08 Thread Piotr Zegar via llvm-branch-commits

PiotrZSL wrote:

```
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -496,6 +496,10 @@ Changes in existing checks
   ``static_cast``. Fixed false positives in C++20 spaceship operator by 
ignoring
   casts in implicit and defaulted functions.

+- Improved :doc:`readability-non-const-parameter
+  ` check to not crash when
+  redeclaration have fewer parameters than expected.
+
 - Improved :doc:`readability-redundant-inline-specifier
   ` check to properly
   emit warnings for static data member with an in-class initializer.

```

https://github.com/llvm/llvm-project/pull/101878
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] [clang-tools-extra] Revise IDE folder structure (PR #89744)

2024-05-21 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL commented:

For me this entire change doesn't make sense.

https://github.com/llvm/llvm-project/pull/89744
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] [clang-tools-extra] Revise IDE folder structure (PR #89744)

2024-05-21 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL edited 
https://github.com/llvm/llvm-project/pull/89744
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] [clang-tools-extra] Revise IDE folder structure (PR #89744)

2024-05-21 Thread Piotr Zegar via llvm-branch-commits


@@ -51,6 +52,7 @@ add_clang_library(clangTidyMiscModule
   genconfusable
   ClangDriverOptions
   )
+set_target_properties(clangTidyMiscModule PROPERTIES FOLDER "Clang Tools 
Extra/Libraries")

PiotrZSL wrote:

why this is set for Misc module, but not for other check modules.

https://github.com/llvm/llvm-project/pull/89744
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] [clang-tidy] fix wrong float to float conversion check when floating point type is not standard type (PR #122637)

2025-01-13 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/122637
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] release/20.x: [clang-tidy] Do not pass any file when listing checks in run_clang_ti… (#137286) (PR #137775)

2025-05-03 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/137775
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang] [AstMatcher]`templateArgumentCountIs` support `FunctionDecl` (PR #130416)

2025-03-10 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL requested changes to this pull request.

You may need to update documentation for this matcher in 
clang/docs/LibASTMatchersReference.html

https://github.com/llvm/llvm-project/pull/130416
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang-tools-extra] release/20.x: [clang-tidy] Fix broken HeaderFilterRegex when read from config file (#133582) (PR #134215)

2025-04-04 Thread Piotr Zegar via llvm-branch-commits

https://github.com/PiotrZSL approved this pull request.

It's ok as far as it works.
Personally if we do not utilize that optional, then probably it should be 
removed.

https://github.com/llvm/llvm-project/pull/134215
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits