[llvm-branch-commits] [clang] Revert "[clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (#122095)" (PR #134407)

[Jack Styles via llvm-branch-commits]

https://github.com/Stylie777 approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/134407
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AArch64] Correct position of CFI Instruction for Pointer Authentication (PR #137800)

[Jack Styles via llvm-branch-commits]

https://github.com/Stylie777 approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/137800
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Use OmpDirectiveSpecification in DISPATCH (PR #148008)

[Jack Styles via llvm-branch-commits]

https://github.com/Stylie777 edited 
https://github.com/llvm/llvm-project/pull/148008
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Use OmpDirectiveSpecification in DISPATCH (PR #148008)

[Jack Styles via llvm-branch-commits]

https://github.com/Stylie777 approved this pull request.

LGTM. One small nit comment but not critical.

https://github.com/llvm/llvm-project/pull/148008
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Use OmpDirectiveSpecification in DISPATCH (PR #148008)

[Jack Styles via llvm-branch-commits]

@@ -1302,6 +1302,32 @@ TYPE_PARSER(sourced( //
 construct(
 "ALLOCATORS"_tok >= OmpAllocatorsConstructParser{})))
 
+struct OmpDispatchConstructParser {
+  using resultType = OpenMPDispatchConstruct;
+
+  std::optional Parse(ParseState &state) const {
+auto dirSpec{Parser{}.Parse(state)};
+if (!dirSpec || dirSpec->DirId() != llvm::omp::Directive::OMPD_dispatch) {
+  return std::nullopt;
+}
+
+// This should be a function call. That will be checked in semantics.
+Block block;
+if (auto stmt{attempt(Parser{}).Parse(state)}) {
+  block.emplace_back(std::move(*stmt));
+}
+// Allow empty block. Check for this in semantics.
+
+auto end{OmpEndDirectiveParser{llvm::omp::Directive::OMPD_dispatch}};
+return OpenMPDispatchConstruct{
+std::move(*dirSpec), std::move(block), *maybe(end).Parse(state)};
+  }
+};
+
+TYPE_PARSER(sourced( //

Stylie777 wrote:

nit: Extra `//`

https://github.com/llvm/llvm-project/pull/148008
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits