[llvm-branch-commits] [mlir] Add missing imports (PR #138550)

[Filip Laurentiu via llvm-branch-commits]

https://github.com/FilipLaurentiu edited 
https://github.com/llvm/llvm-project/pull/138550
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] Add missing imports (PR #138550)

[Filip Laurentiu via llvm-branch-commits]

https://github.com/FilipLaurentiu created 
https://github.com/llvm/llvm-project/pull/138550

Build fail without these improts

>From 7a5195fd542f71142e4524f4d4720305bb14c2bb Mon Sep 17 00:00:00 2001
From: Filip Laurentiu 
Date: Mon, 5 May 2025 18:56:30 +0300
Subject: [PATCH] Add missing imports

---
 mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h | 1 +
 mlir/include/mlir/Target/SPIRV/Deserialization.h | 1 +
 mlir/include/mlir/Target/SPIRV/Serialization.h   | 1 +
 3 files changed, 3 insertions(+)

diff --git a/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h 
b/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
index 451c466fa0c95..642e99d963ef6 100644
--- a/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
+++ b/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
@@ -10,6 +10,7 @@
 #define MLIR_DIALECT_AFFINE_IR_VALUEBOUNDSOPINTERFACEIMPL_H
 
 #include "mlir/Support/LLVM.h"
+#include 
 
 namespace mlir {
 class DialectRegistry;
diff --git a/mlir/include/mlir/Target/SPIRV/Deserialization.h 
b/mlir/include/mlir/Target/SPIRV/Deserialization.h
index e39258beeaac8..a346a7fd1e5f7 100644
--- a/mlir/include/mlir/Target/SPIRV/Deserialization.h
+++ b/mlir/include/mlir/Target/SPIRV/Deserialization.h
@@ -15,6 +15,7 @@
 
 #include "mlir/IR/OwningOpRef.h"
 #include "mlir/Support/LLVM.h"
+#include 
 
 namespace mlir {
 class MLIRContext;
diff --git a/mlir/include/mlir/Target/SPIRV/Serialization.h 
b/mlir/include/mlir/Target/SPIRV/Serialization.h
index 613f0a423f9f8..225777e25d607 100644
--- a/mlir/include/mlir/Target/SPIRV/Serialization.h
+++ b/mlir/include/mlir/Target/SPIRV/Serialization.h
@@ -14,6 +14,7 @@
 #define MLIR_TARGET_SPIRV_SERIALIZATION_H
 
 #include "mlir/Support/LLVM.h"
+#include 
 
 namespace mlir {
 class MLIRContext;

___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] Add missing imports (PR #138550)

[Filip Laurentiu via llvm-branch-commits]

@@ -10,6 +10,7 @@
 #define MLIR_DIALECT_AFFINE_IR_VALUEBOUNDSOPINTERFACEIMPL_H
 
 #include "mlir/Support/LLVM.h"
+#include 

FilipLaurentiu wrote:

```
[1747/5390] Building CXX object 
tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o
FAILED: 
tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/home/filip/Work/llvm-project/build/tools/mlir/lib/Dialect/Affine/IR 
-I/home/filip/Work/llvm-project/mlir/lib/Dialect/Affine/IR 
-I/home/filip/Work/llvm-project/build/include 
-I/home/filip/Work/llvm-project/llvm/include 
-I/home/filip/Work/llvm-project/mlir/include 
-I/home/filip/Work/llvm-project/build/tools/mlir/include -fPIC 
-fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time 
-fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings 
-Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long 
-Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull 
-Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move 
-Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment 
-Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color 
-ffunction-sections -fdata-sections -Wundef -O3 -DNDEBUG -std=c++17  
-fno-exceptions -funwind-tables -MD -MT 
tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o
 -MF 
tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o.d
 -o 
tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o
 -c 
/home/filip/Work/llvm-project/mlir/lib/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.cpp
In file included from 
/home/filip/Work/llvm-project/mlir/lib/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.cpp:9:
/home/filip/Work/llvm-project/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h:31:11:
 error: ‘int64_t’ was not declared in this scope
   31 | FailureOr fullyComposeAndComputeConstantDelta(Value value1,
  |   ^~~
/home/filip/Work/llvm-project/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h:13:1:
 note: ‘int64_t’ is defined in header ‘’; this is probably fixable by 
adding ‘#include ’
   12 | #include "mlir/Support/LLVM.h"
  +++ |+#include 
   13 |
/home/filip/Work/llvm-project/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h:31:18:
 error: template argument 1 is invalid
   31 | FailureOr fullyComposeAndComputeConstantDelta(Value value1,
  |  ^
/home/filip/Work/llvm-project/mlir/lib/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.cpp:107:77:
 error: ‘llvm::FailureOr 
mlir::affine::fullyComposeAndComputeConstantDelta(mlir::Value, mlir::Value)’ 
should have been declared inside ‘mlir::affine’
  107 | mlir::affine::fullyComposeAndComputeConstantDelta(Value value1, Value 
value2) {
  | 
^
/home/filip/Work/llvm-project/mlir/lib/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.cpp:107:1:
 error: ambiguating new declaration of ‘llvm::FailureOr 
mlir::affine::fullyComposeAndComputeConstantDelta(mlir::Value, mlir::Value)’
  107 | mlir::affine::fullyComposeAndComputeConstantDelta(Value value1, Value 
value2) {
  | ^~~~
/home/filip/Work/llvm-project/mlir/include/mlir/D
```

It seems that without the imports I get this error when I try to build. Adding 
the import, as it is suggested fix the problem

https://github.com/llvm/llvm-project/pull/138550
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] Add missing imports (PR #138550)

[Filip Laurentiu via llvm-branch-commits]

FilipLaurentiu wrote:

Any updates ?

https://github.com/llvm/llvm-project/pull/138550
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] Add missing imports (PR #138550)

[Filip Laurentiu via llvm-branch-commits]

FilipLaurentiu wrote:

> The LLVM 19 release is no longer supported. You'll have to apply this as a 
> local patch if you want to build and old LLVM 19 with a new libstdc++.

Some projects still use LLVM 19. I am not an LLVM developer, not even a C++ 
developer, but I am working on a project that depends on MLIR, unfortunately 
building this from scratch is anything but easy.

Documentation doesn't help much, and if you found a fix, you should suggest a 
workaround

https://github.com/llvm/llvm-project/pull/138550
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits