date:20180119

[llvm-branch-commits] [cfe-branch] r322931 - Merging r322901:

2018-01-19 Thread Hans Wennborg via llvm-branch-commits

Author: hans
Date: Fri Jan 19 02:09:28 2018
New Revision: 322931

URL: http://llvm.org/viewvc/llvm-project?rev=322931&view=rev
Log:
Merging r322901:

r322901 | nico | 2018-01-18 13:40:27 -0800 (Thu, 18 Jan 2018) | 19 lines

Remove TautologicalInRangeCompare from Extra and TautologicalCompare.

This removes the following (already default-off) warnings from -Wextra:
  -Wtautological-type-limit-compare,
  -Wtautological-unsigned-zero-compare
  -Wtautological-unsigned-enum-zero-compare

On the thread "[cfe-dev] -Wtautological-constant-compare issues", clang
code owners Richard Smith, John McCall, and Reid Kleckner as well as
libc++ code owner Marshall Clow stated that these new warnings are not
yet ready for prime time and shouldn't be part of -Wextra.

Furthermore, Vedant Kumar (Apple), Peter Hosek (Fuchsia), and me (Chromium)
expressed the same concerns (Vedant on that thread, Peter on
https://reviews.llvm.org/D39462, me on https://reviews.llvm.org/D41512).

So remove them from -Wextra, and remove TautologicalInRangeCompare from
TautologicalCompare too until they're usable with real-world code.



Modified:
cfe/branches/release_60/   (props changed)
cfe/branches/release_60/include/clang/Basic/DiagnosticGroups.td
cfe/branches/release_60/test/Sema/tautological-constant-compare.c

Propchange: cfe/branches/release_60/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jan 19 02:09:28 2018
@@ -1,4 +1,4 @@
 /cfe/branches/type-system-rewrite:134693-134817
-/cfe/trunk:321754,321771,321777,321779,321933,322018,322236,322246,322350,322390,322405,322420,322518,322593
+/cfe/trunk:321754,321771,321777,321779,321933,322018,322236,322246,322350,322390,322405,322420,322518,322593,322901
 /cfe/trunk/test:170344
 /cfe/trunk/test/SemaTemplate:126920

Modified: cfe/branches/release_60/include/clang/Basic/DiagnosticGroups.td
URL: 
http://llvm.org/viewvc/llvm-project/cfe/branches/release_60/include/clang/Basic/DiagnosticGroups.td?rev=322931&r1=322930&r2=322931&view=diff
==
--- cfe/branches/release_60/include/clang/Basic/DiagnosticGroups.td (original)
+++ cfe/branches/release_60/include/clang/Basic/DiagnosticGroups.td Fri Jan 19 
02:09:28 2018
@@ -444,8 +444,7 @@ def TautologicalInRangeCompare : DiagGro
 
TautologicalUnsignedEnumZeroCompare]>;
 def TautologicalOutOfRangeCompare : 
DiagGroup<"tautological-constant-out-of-range-compare">;
 def TautologicalConstantCompare : DiagGroup<"tautological-constant-compare",
-[TautologicalInRangeCompare,
- TautologicalOutOfRangeCompare]>;
+[TautologicalOutOfRangeCompare]>;
 def TautologicalPointerCompare : DiagGroup<"tautological-pointer-compare">;
 def TautologicalOverlapCompare : DiagGroup<"tautological-overlap-compare">;
 def TautologicalUndefinedCompare : DiagGroup<"tautological-undefined-compare">;
@@ -719,7 +718,6 @@ def IntToPointerCast : DiagGroup<"int-to
 def Move : DiagGroup<"move", [PessimizingMove, RedundantMove, SelfMove]>;
 
 def Extra : DiagGroup<"extra", [
-TautologicalInRangeCompare,
 MissingFieldInitializers,
 IgnoredQualifiers,
 InitializerOverrides,

Modified: cfe/branches/release_60/test/Sema/tautological-constant-compare.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/branches/release_60/test/Sema/tautological-constant-compare.c?rev=322931&r1=322930&r2=322931&view=diff
==
--- cfe/branches/release_60/test/Sema/tautological-constant-compare.c (original)
+++ cfe/branches/release_60/test/Sema/tautological-constant-compare.c Fri Jan 
19 02:09:28 2018
@@ -2,8 +2,8 @@
 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only 
-Wtautological-constant-in-range-compare -DTEST -verify -x c++ %s
 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only 
-Wtautological-type-limit-compare -DTEST -verify %s
 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only 
-Wtautological-type-limit-compare -DTEST -verify -x c++ %s
-// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra 
-Wno-sign-compare -DTEST -verify %s
-// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra 
-Wno-sign-compare -DTEST -verify -x c++ %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra 
-Wno-sign-compare -verify %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra 
-Wno-sign-compare -verify -x c++ %s
 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wall -verify %s
 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wall -verify -x c++ 
%s
 // RUN: %clang_cc1 -triple

[llvm-branch-commits] [llvm-branch] r322953 - Merging r322053:

2018-01-19 Thread Hans Wennborg via llvm-branch-commits

Author: hans
Date: Fri Jan 19 07:59:49 2018
New Revision: 322953

URL: http://llvm.org/viewvc/llvm-project?rev=322953&view=rev
Log:
Merging r322053:

r322053 | echristo | 2018-01-09 03:38:17 +0100 (Tue, 09 Jan 2018) | 1 line

Remove unused function HvxSelector::zerous.


Modified:
llvm/branches/release_60/   (props changed)
llvm/branches/release_60/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp

Propchange: llvm/branches/release_60/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jan 19 07:59:49 2018
@@ -1,3 +1,3 @@
 /llvm/branches/Apple/Pertwee:110850,110961
 /llvm/branches/type-system-rewrite:133420-134817
-/llvm/trunk:155241,321751,321789,321791,321806,321862,321870,321872,321878,321980,321991,321993-321994,322003,322056,322103,322106,33,322272,322313,322473,322623,322644,322724
+/llvm/trunk:155241,321751,321789,321791,321806,321862,321870,321872,321878,321980,321991,321993-321994,322003,322053,322056,322103,322106,33,322272,322313,322473,322623,322644,322724

Modified: llvm/branches/release_60/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
URL: 
http://llvm.org/viewvc/llvm-project/llvm/branches/release_60/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp?rev=322953&r1=322952&r2=322953&view=diff
==
--- llvm/branches/release_60/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp 
(original)
+++ llvm/branches/release_60/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp Fri 
Jan 19 07:59:49 2018
@@ -821,7 +821,6 @@ namespace llvm {
 MutableArrayRef NewMask, unsigned Options = None);
 OpRef packp(ShuffleMask SM, OpRef Va, OpRef Vb, ResultStack &Results,
 MutableArrayRef NewMask);
-OpRef zerous(ShuffleMask SM, OpRef Va, ResultStack &Results);
 OpRef vmuxs(ArrayRef Bytes, OpRef Va, OpRef Vb,
 ResultStack &Results);
 OpRef vmuxp(ArrayRef Bytes, OpRef Va, OpRef Vb,
@@ -1139,25 +1138,6 @@ OpRef HvxSelector::packp(ShuffleMask SM,
   return concat(Out[0], Out[1], Results);
 }
 
-OpRef HvxSelector::zerous(ShuffleMask SM, OpRef Va, ResultStack &Results) {
-  DEBUG_WITH_TYPE("isel", {dbgs() << __func__ << '\n';});
-
-  int VecLen = SM.Mask.size();
-  SmallVector UsedBytes(VecLen);
-  bool HasUnused = false;
-  for (int I = 0; I != VecLen; ++I) {
-if (SM.Mask[I] != -1)
-  UsedBytes[I] = 0xFF;
-else
-  HasUnused = true;
-  }
-  if (!HasUnused)
-return Va;
-  SDValue B = getVectorConstant(UsedBytes, SDLoc(Results.InpNode));
-  Results.push(Hexagon::V6_vand, getSingleVT(MVT::i8), {Va, OpRef(B)});
-  return OpRef::res(Results.top());
-}
-
 OpRef HvxSelector::vmuxs(ArrayRef Bytes, OpRef Va, OpRef Vb,
  ResultStack &Results) {
   DEBUG_WITH_TYPE("isel", {dbgs() << __func__ << '\n';});


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [cfe-branch] r322931 - Merging r322901:

[llvm-branch-commits] [llvm-branch] r322953 - Merging r322053:

2 matches

Site Navigation

Mail list logo

Footer information