[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

[Ulrich Weigand via Phabricator via lldb-commits]

uweigand added a comment.

This makes sense to me (although we don't currently need the options parameter 
there).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

[Ulrich Weigand via Phabricator via lldb-commits]

uweigand added a comment.

This commit causes test case failures on s390x (unfortunately hidden as the 
build bot was already red due to an unrelated issue):
http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624

http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3ADWARF-debug_info.yaml

At first glance, seems like this could be endian-related?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82622/new/

https://reviews.llvm.org/D82622



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

[Ulrich Weigand via Phabricator via lldb-commits]

uweigand added a comment.

In D82622#2122708 , @Higuoxing wrote:

> In D82622#2122562 , @uweigand wrote:
>
> > This commit causes test case failures on s390x (unfortunately hidden as the 
> > build bot was already red due to an unrelated issue):
> >  http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624
> >
> > http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3ADWARF-debug_info.yaml
> >
> > At first glance, seems like this could be endian-related?
>
>
> The failed tests are removed in 8032727a43ca678b0b923abaa04638f500a060d6 
> . Thanks.


Thanks, the build bot is now green again!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82622/new/

https://reviews.llvm.org/D82622



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits