[Lldb-commits] [PATCH] D46885: Remove append parameter to FindGlobalVariables
tromey added a comment. I don't have commit access, so could someone please land this for me? https://reviews.llvm.org/D46885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D47481: Initialize FunctionCaller::m_struct_valid
tromey added a comment. I don't have write access so someone will have to land this for me. Thanks. https://reviews.llvm.org/D47481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar
tromey added a comment. I've also noticed that int->float conversion in Scalar seems incorrect. At least, Scalar.h claims that Scalar follows C promotion rules, but int->float conversion is done using bitwise reinterpretation rather than preserving the value. I have a patch for this, but I don't know whether or not it's correct to change. https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar
tromey updated this revision to Diff 139616.
tromey added a comment.
Add unit test
https://reviews.llvm.org/D44693
Files:
source/Core/Scalar.cpp
unittests/Core/ScalarTest.cpp
Index: unittests/Core/ScalarTest.cpp
===
--- unittests/Core/ScalarTest.cpp
+++ unittests/Core/ScalarTest.cpp
@@ -132,3 +132,11 @@
EXPECT_EQ(std::to_string(std::numeric_limits::max()),
ScalarGetValue(std::numeric_limits::max()));
}
+
+TEST(ScalarTest, Division) {
+ Scalar lhs(5.0);
+ Scalar rhs(2.0);
+ Scalar r = lhs / rhs;
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(r, Scalar(2.5));
+}
Index: source/Core/Scalar.cpp
===
--- source/Core/Scalar.cpp
+++ source/Core/Scalar.cpp
@@ -2266,7 +2266,7 @@
case Scalar::e_float:
case Scalar::e_double:
case Scalar::e_long_double:
- if (b->m_float.isZero()) {
+ if (!b->m_float.isZero()) {
result.m_float = a->m_float / b->m_float;
return result;
}
Index: unittests/Core/ScalarTest.cpp
===
--- unittests/Core/ScalarTest.cpp
+++ unittests/Core/ScalarTest.cpp
@@ -132,3 +132,11 @@
EXPECT_EQ(std::to_string(std::numeric_limits::max()),
ScalarGetValue(std::numeric_limits::max()));
}
+
+TEST(ScalarTest, Division) {
+ Scalar lhs(5.0);
+ Scalar rhs(2.0);
+ Scalar r = lhs / rhs;
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(r, Scalar(2.5));
+}
Index: source/Core/Scalar.cpp
===
--- source/Core/Scalar.cpp
+++ source/Core/Scalar.cpp
@@ -2266,7 +2266,7 @@
case Scalar::e_float:
case Scalar::e_double:
case Scalar::e_long_double:
- if (b->m_float.isZero()) {
+ if (!b->m_float.isZero()) {
result.m_float = a->m_float / b->m_float;
return result;
}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar
tromey added a comment. In https://reviews.llvm.org/D44693#1046925, @davide wrote: > LGTM, thanks. Do you have commit access or you need somebody to commit this > on your behalf? I do not have commit access. https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lldb-commits@lists.llvm.org
tromey added a comment. I only found this because I tried to use it in my rust plugin. So, I would rather implement it, because if I removed it, I would have to find a new way to do this. https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44907: Remove Scalar::Cast
tromey added a comment. In https://reviews.llvm.org/D44907#1051931, @davide wrote: > @tromey thanks! do you need somebody to commit this for you? Yes. I do not have commit access. https://reviews.llvm.org/D44907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lldb-commits@lists.llvm.org
tromey added a comment. In https://reviews.llvm.org/D44752#1052027, @clayborg wrote: > Can you add this to the patch for the rust plug-in then? Yes, I already did; I just thought that since it was a latent bug in upstream that I would submit it separately. https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang
tom.tromey added a comment. > Apart from just implementing type system itself (which is much bigger scope > than this change) there are other non-trivial issues: > > 1. There is no "compiler-as-a-service" in Rust so getting expressions to work > is non-trivial. An interpreter of some sort needs to be built with subset of > Rust support My work also included a parser for some Rust expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
